[INFO] fetching crate reset-router 0.8.3... [INFO] checking reset-router-0.8.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reset-router 0.8.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate reset-router 0.8.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reset-router 0.8.3 [INFO] finished tweaking crates.io crate reset-router 0.8.3 [INFO] tweaked toml for crates.io crate reset-router 0.8.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate reset-router 0.8.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62b6ac70a27456dce08b8ba22ef758fe9b1a6f0138f99f1f3d0af28a7f15f356 [INFO] running `Command { std: "docker" "start" "-a" "62b6ac70a27456dce08b8ba22ef758fe9b1a6f0138f99f1f3d0af28a7f15f356", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62b6ac70a27456dce08b8ba22ef758fe9b1a6f0138f99f1f3d0af28a7f15f356", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62b6ac70a27456dce08b8ba22ef758fe9b1a6f0138f99f1f3d0af28a7f15f356", kill_on_drop: false }` [INFO] [stdout] 62b6ac70a27456dce08b8ba22ef758fe9b1a6f0138f99f1f3d0af28a7f15f356 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 775cfd21596aa0203277721ba2437fca94978539ed1526da894b074036b9c528 [INFO] running `Command { std: "docker" "start" "-a" "775cfd21596aa0203277721ba2437fca94978539ed1526da894b074036b9c528", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking bytes v0.5.3 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking tower-layer v0.3.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking tracing-core v0.1.9 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Compiling indexmap v1.3.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking http v0.2.0 [INFO] [stderr] Checking type-map v0.2.0 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking regex v1.3.3 [INFO] [stderr] Checking reset-recognizer v0.8.0 [INFO] [stderr] Compiling pin-project-internal v0.4.7 [INFO] [stderr] Compiling tokio-macros v0.2.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling tracing-attributes v0.1.6 [INFO] [stderr] Checking tokio v0.2.9 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking tracing v0.1.12 [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stderr] Checking pin-project v0.4.7 [INFO] [stderr] Checking tower-discover v0.3.0 [INFO] [stderr] Checking tower-load-shed v0.3.0 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking tower-limit v0.3.0 [INFO] [stderr] Checking tower-retry v0.3.0 [INFO] [stderr] Checking tower-buffer v0.3.0 [INFO] [stderr] Checking tower-timeout v0.3.0 [INFO] [stderr] Checking h2 v0.2.1 [INFO] [stderr] Checking futures-executor v0.3.1 [INFO] [stderr] Checking tower-util v0.3.0 [INFO] [stderr] Checking futures v0.3.1 [INFO] [stderr] Checking tower v0.3.1 [INFO] [stderr] Checking hyper v0.13.1 [INFO] [stderr] Checking reset-router v0.8.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:14 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Data(Arc::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:278:1 [INFO] [stdout] | [INFO] [stdout] 278 | #[pin_project::pin_project] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `::pin_project::__private::__PinProjectInternalDerive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:314:32 [INFO] [stdout] | [INFO] [stdout] 313 | fn call(&self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | HandlerFuture { inner: self(request) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:338:14 [INFO] [stdout] | [INFO] [stdout] 337 | fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Self(Arc::new(move |req: Request| { [INFO] [stdout] | ______________^ [INFO] [stdout] 339 | | let rt = t.call(req).map(|res| res.map(|s| s.into()).map_err(|e| e.into())); [INFO] [stdout] 340 | | Box::pin(rt) [INFO] [stdout] 341 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:44 [INFO] [stdout] | [INFO] [stdout] 339 | let rt = t.call(req).map(|res| res.map(|s| s.into()).map_err(|e| e.into())); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:27 [INFO] [stdout] | [INFO] [stdout] 384 | pub fn data(self, data: T) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 385 | self.wrapped_data(Data::new(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:450:12 [INFO] [stdout] | [INFO] [stdout] 436 | pub fn finish(self) -> err::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | let mut inner_router = InnerRouter { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | Ok(Router(Arc::new(inner_router))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reset-router` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:14 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Data(Arc::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:278:1 [INFO] [stdout] | [INFO] [stdout] 278 | #[pin_project::pin_project] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `::pin_project::__private::__PinProjectInternalDerive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:314:32 [INFO] [stdout] | [INFO] [stdout] 313 | fn call(&self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | HandlerFuture { inner: self(request) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:338:14 [INFO] [stdout] | [INFO] [stdout] 337 | fn new(t: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Self(Arc::new(move |req: Request| { [INFO] [stdout] | ______________^ [INFO] [stdout] 339 | | let rt = t.call(req).map(|res| res.map(|s| s.into()).map_err(|e| e.into())); [INFO] [stdout] 340 | | Box::pin(rt) [INFO] [stdout] 341 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:44 [INFO] [stdout] | [INFO] [stdout] 339 | let rt = t.call(req).map(|res| res.map(|s| s.into()).map_err(|e| e.into())); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:27 [INFO] [stdout] | [INFO] [stdout] 384 | pub fn data(self, data: T) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 385 | self.wrapped_data(Data::new(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:450:12 [INFO] [stdout] | [INFO] [stdout] 436 | pub fn finish(self) -> err::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 437 | let mut inner_router = InnerRouter { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | Ok(Router(Arc::new(inner_router))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reset-router` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "775cfd21596aa0203277721ba2437fca94978539ed1526da894b074036b9c528", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "775cfd21596aa0203277721ba2437fca94978539ed1526da894b074036b9c528", kill_on_drop: false }` [INFO] [stdout] 775cfd21596aa0203277721ba2437fca94978539ed1526da894b074036b9c528