[INFO] fetching crate reroute 0.4.1... [INFO] checking reroute-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reroute 0.4.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate reroute 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reroute 0.4.1 [INFO] finished tweaking crates.io crate reroute 0.4.1 [INFO] tweaked toml for crates.io crate reroute 0.4.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate reroute 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 40fa1ebdcab31e89ce1caa43291ecc49da1605d917089516a406ad989cba4e9f [INFO] running `Command { std: "docker" "start" "-a" "40fa1ebdcab31e89ce1caa43291ecc49da1605d917089516a406ad989cba4e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "40fa1ebdcab31e89ce1caa43291ecc49da1605d917089516a406ad989cba4e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40fa1ebdcab31e89ce1caa43291ecc49da1605d917089516a406ad989cba4e9f", kill_on_drop: false }` [INFO] [stdout] 40fa1ebdcab31e89ce1caa43291ecc49da1605d917089516a406ad989cba4e9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d633df794d849c3718dc5ce3c2b0fb014f8191dd04e1653e2907bdd7e65e038e [INFO] running `Command { std: "docker" "start" "-a" "d633df794d849c3718dc5ce3c2b0fb014f8191dd04e1653e2907bdd7e65e038e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Checking http v0.2.0 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Compiling tokio-macros v0.2.4 [INFO] [stderr] Compiling pin-project-internal v0.4.8 [INFO] [stderr] Checking tokio v0.2.11 [INFO] [stderr] Checking pin-project v0.4.8 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking h2 v0.2.1 [INFO] [stderr] Checking hyper v0.13.2 [INFO] [stderr] Checking reroute v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn finalize(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(Router { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | routes: RegexSet::new(self.routes.iter())?, [INFO] [stdout] 91 | | patterns: self [INFO] [stdout] 92 | | .routes [INFO] [stdout] ... | [INFO] [stdout] 99 | | .unwrap_or_else(|| Box::new(default_not_found)), [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn get(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | self.route(Method::GET, route, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn post(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | self.route(Method::POST, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn put(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | self.route(Method::PUT, route, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn patch(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | self.route(Method::PATCH, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn delete(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | self.route(Method::DELETE, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn options(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | self.route(Method::OPTIONS, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 164 | fn default_not_found(_: Request, _: Captures) -> Response { [INFO] [stdout] | ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | / Response::builder() [INFO] [stdout] 166 | | .status(StatusCode::NOT_FOUND) [INFO] [stdout] 167 | | .body("Not Found".into()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 197 | fn test_handler(_: Request, _: Captures) -> Response { [INFO] [stdout] | ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | / Response::builder() [INFO] [stdout] 199 | | .status(StatusCode::OK) [INFO] [stdout] 200 | | .body("Ok".into()) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn finalize(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(Router { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | routes: RegexSet::new(self.routes.iter())?, [INFO] [stdout] 91 | | patterns: self [INFO] [stdout] 92 | | .routes [INFO] [stdout] ... | [INFO] [stdout] 99 | | .unwrap_or_else(|| Box::new(default_not_found)), [INFO] [stdout] 100 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn get(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | self.route(Method::GET, route, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:20 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn post(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | self.route(Method::POST, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn put(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | self.route(Method::PUT, route, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn patch(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | self.route(Method::PATCH, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn delete(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | self.route(Method::DELETE, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:20 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn options(&mut self, route: &str, handler: H) -> &mut RouterBuilder [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | self.route(Method::OPTIONS, route, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 164 | fn default_not_found(_: Request, _: Captures) -> Response { [INFO] [stdout] | ---------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | / Response::builder() [INFO] [stdout] 166 | | .status(StatusCode::NOT_FOUND) [INFO] [stdout] 167 | | .body("Not Found".into()) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reroute` (lib test) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `reroute` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "d633df794d849c3718dc5ce3c2b0fb014f8191dd04e1653e2907bdd7e65e038e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d633df794d849c3718dc5ce3c2b0fb014f8191dd04e1653e2907bdd7e65e038e", kill_on_drop: false }` [INFO] [stdout] d633df794d849c3718dc5ce3c2b0fb014f8191dd04e1653e2907bdd7e65e038e