[INFO] fetching crate requestty-macro 0.5.0... [INFO] checking requestty-macro-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate requestty-macro 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate requestty-macro 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate requestty-macro 0.5.0 [INFO] finished tweaking crates.io crate requestty-macro 0.5.0 [INFO] tweaked toml for crates.io crate requestty-macro 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19e7b8090100f1e90125d995d45bafaa11e4ff0428dcf902601714af681c3bd3 [INFO] running `Command { std: "docker" "start" "-a" "19e7b8090100f1e90125d995d45bafaa11e4ff0428dcf902601714af681c3bd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19e7b8090100f1e90125d995d45bafaa11e4ff0428dcf902601714af681c3bd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19e7b8090100f1e90125d995d45bafaa11e4ff0428dcf902601714af681c3bd3", kill_on_drop: false }` [INFO] [stdout] 19e7b8090100f1e90125d995d45bafaa11e4ff0428dcf902601714af681c3bd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f334e5cb78bc647dc368beabc2c4c9b72c4e3ad5d7629441bd111f2c9f68e17 [INFO] running `Command { std: "docker" "start" "-a" "1f334e5cb78bc647dc368beabc2c4c9b72c4e3ad5d7629441bd111f2c9f68e17", kill_on_drop: false }` [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking requestty-macro v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn questions(item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let p = parse_macro_input!(item as Questions); [INFO] [stdout] | - ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let questions = p.questions.into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | / if p.inline { [INFO] [stdout] 35 | | iter! { proc_macro2::Span::call_site() => #(#questions),* } [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | quote::quote! { ::std::vec![ #(#questions),* ] } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | .step(|c| match c.ident() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 110 | fn from(path: syn::ExprPath) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::Expr(path.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn questions(item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let p = parse_macro_input!(item as Questions); [INFO] [stdout] | - ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | let questions = p.questions.into_iter(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | / if p.inline { [INFO] [stdout] 35 | | iter! { proc_macro2::Span::call_site() => #(#questions),* } [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | quote::quote! { ::std::vec![ #(#questions),* ] } [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | .step(|c| match c.ident() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn make_into(expr: syn::Expr) -> syn::Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut from_path_segments = syn::punctuated::Punctuated::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | / syn::ExprCall { [INFO] [stdout] 202 | | attrs: Vec::new(), [INFO] [stdout] 203 | | func: Box::new( [INFO] [stdout] 204 | | syn::ExprPath { [INFO] [stdout] ... | [INFO] [stdout] 219 | | }, [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 230 | fn make_multi_select_tuple(choice: syn::Expr, default: syn::Expr) -> syn::Expr { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let mut elems = syn::punctuated::Punctuated::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / syn::ExprTuple { [INFO] [stdout] 243 | | attrs: Vec::new(), [INFO] [stdout] 244 | | paren_token, [INFO] [stdout] 245 | | elems, [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 110 | fn from(path: syn::ExprPath) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | Self::Expr(path.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 181 | fn make_into(expr: syn::Expr) -> syn::Expr { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut from_path_segments = syn::punctuated::Punctuated::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | / syn::ExprCall { [INFO] [stdout] 202 | | attrs: Vec::new(), [INFO] [stdout] 203 | | func: Box::new( [INFO] [stdout] 204 | | syn::ExprPath { [INFO] [stdout] ... | [INFO] [stdout] 219 | | }, [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 230 | fn make_multi_select_tuple(choice: syn::Expr, default: syn::Expr) -> syn::Expr { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | let mut elems = syn::punctuated::Punctuated::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | / syn::ExprTuple { [INFO] [stdout] 243 | | attrs: Vec::new(), [INFO] [stdout] 244 | | paren_token, [INFO] [stdout] 245 | | elems, [INFO] [stdout] 246 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/question.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 245 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | let brace = syn::braced!(content in input); [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | [INFO] [stdout] 248 | let mut opts = QuestionOpts::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | kind, [INFO] [stdout] 318 | | name: name [INFO] [stdout] 319 | | .ok_or_else(|| syn::Error::new(brace.span, "missing required option `name`"))?, [INFO] [stdout] 320 | | opts, [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/question.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 245 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 246 | let brace = syn::braced!(content in input); [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | [INFO] [stdout] 248 | let mut opts = QuestionOpts::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | kind, [INFO] [stdout] 318 | | name: name [INFO] [stdout] 319 | | .ok_or_else(|| syn::Error::new(brace.span, "missing required option `name`"))?, [INFO] [stdout] 320 | | opts, [INFO] [stdout] 321 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `requestty-macro` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `requestty-macro` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1f334e5cb78bc647dc368beabc2c4c9b72c4e3ad5d7629441bd111f2c9f68e17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f334e5cb78bc647dc368beabc2c4c9b72c4e3ad5d7629441bd111f2c9f68e17", kill_on_drop: false }` [INFO] [stdout] 1f334e5cb78bc647dc368beabc2c4c9b72c4e3ad5d7629441bd111f2c9f68e17