[INFO] fetching crate request-channel 0.1.1... [INFO] checking request-channel-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate request-channel 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate request-channel 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate request-channel 0.1.1 [INFO] finished tweaking crates.io crate request-channel 0.1.1 [INFO] tweaked toml for crates.io crate request-channel 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70ff9534e1af526fdaab820b4e9cf67ec4419658c283b51152d2f7f2c456c66b [INFO] running `Command { std: "docker" "start" "-a" "70ff9534e1af526fdaab820b4e9cf67ec4419658c283b51152d2f7f2c456c66b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70ff9534e1af526fdaab820b4e9cf67ec4419658c283b51152d2f7f2c456c66b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70ff9534e1af526fdaab820b4e9cf67ec4419658c283b51152d2f7f2c456c66b", kill_on_drop: false }` [INFO] [stdout] 70ff9534e1af526fdaab820b4e9cf67ec4419658c283b51152d2f7f2c456c66b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c75c50c0b2f294701bf912240ffde9a4b07c0052f0cfb28446fdd40a033c6f0d [INFO] running `Command { std: "docker" "start" "-a" "c75c50c0b2f294701bf912240ffde9a4b07c0052f0cfb28446fdd40a033c6f0d", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking request-channel v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 44 | let (tx_sender, tx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (rx_sender, rx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ( [INFO] [stdout] 47 | / Requester { [INFO] [stdout] 48 | | sender: tx_sender, [INFO] [stdout] 49 | | receiver: AsyncMutex::new(rx_receiver), [INFO] [stdout] 50 | | buffer: Mutex::new(HashMap::new()), [INFO] [stdout] 51 | | counter: AtomicId::new(0), [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 44 | let (tx_sender, tx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (rx_sender, rx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | / Responder { [INFO] [stdout] 54 | | receiver: tx_receiver, [INFO] [stdout] 55 | | sender: rx_sender, [INFO] [stdout] 56 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn request(&self, message: T) -> Result, T> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let id = self.counter.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 75 | let mut buffer = self.buffer.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | id, [INFO] [stdout] 83 | | receiver: &self.receiver, [INFO] [stdout] 84 | | buffer: &self.buffer, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 204 | r.map(|Tx(id, message)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Response { [INFO] [stdout] 208 | | id, [INFO] [stdout] 209 | | sender: &mut self.sender, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `request-channel` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 44 | let (tx_sender, tx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (rx_sender, rx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | ( [INFO] [stdout] 47 | / Requester { [INFO] [stdout] 48 | | sender: tx_sender, [INFO] [stdout] 49 | | receiver: AsyncMutex::new(rx_receiver), [INFO] [stdout] 50 | | buffer: Mutex::new(HashMap::new()), [INFO] [stdout] 51 | | counter: AtomicId::new(0), [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 44 | let (tx_sender, tx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let (rx_sender, rx_receiver) = unbounded::>(); [INFO] [stdout] | --------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | / Responder { [INFO] [stdout] 54 | | receiver: tx_receiver, [INFO] [stdout] 55 | | sender: rx_sender, [INFO] [stdout] 56 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn request(&self, message: T) -> Result, T> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let id = self.counter.fetch_add(1, Ordering::SeqCst); [INFO] [stdout] 75 | let mut buffer = self.buffer.lock().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | id, [INFO] [stdout] 83 | | receiver: &self.receiver, [INFO] [stdout] 84 | | buffer: &self.buffer, [INFO] [stdout] 85 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 204 | r.map(|Tx(id, message)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Response { [INFO] [stdout] 208 | | id, [INFO] [stdout] 209 | | sender: &mut self.sender, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:28:57 [INFO] [stdout] | [INFO] [stdout] 28 | let rs = xs.clone().into_iter().map(|i| req.request(i).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `request-channel` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "c75c50c0b2f294701bf912240ffde9a4b07c0052f0cfb28446fdd40a033c6f0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c75c50c0b2f294701bf912240ffde9a4b07c0052f0cfb28446fdd40a033c6f0d", kill_on_drop: false }` [INFO] [stdout] c75c50c0b2f294701bf912240ffde9a4b07c0052f0cfb28446fdd40a033c6f0d