[INFO] fetching crate renvar 0.1.0... [INFO] checking renvar-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate renvar 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate renvar 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate renvar 0.1.0 [INFO] finished tweaking crates.io crate renvar 0.1.0 [INFO] tweaked toml for crates.io crate renvar 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3372530e0b950123bd056d0311caa71db839cb585cad10c649413fd8be5495f2 [INFO] running `Command { std: "docker" "start" "-a" "3372530e0b950123bd056d0311caa71db839cb585cad10c649413fd8be5495f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3372530e0b950123bd056d0311caa71db839cb585cad10c649413fd8be5495f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3372530e0b950123bd056d0311caa71db839cb585cad10c649413fd8be5495f2", kill_on_drop: false }` [INFO] [stdout] 3372530e0b950123bd056d0311caa71db839cb585cad10c649413fd8be5495f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b994de78da915fe5675369ad9ba963ff1bfc1a50c1ac2868cbc40ead05e2c87d [INFO] running `Command { std: "docker" "start" "-a" "b994de78da915fe5675369ad9ba963ff1bfc1a50c1ac2868cbc40ead05e2c87d", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking renvar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn from_iter(iter: Iter) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | T::deserialize(EnvVarDeserializer::new(iter.into_iter().map( [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | |(key, value)| { [INFO] [stdout] 156 | | ( [INFO] [stdout] 157 | | String::from(key.trim_matches(is_quote_or_whitespace)), [INFO] [stdout] ... | [INFO] [stdout] 160 | | }, [INFO] [stdout] 161 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:161:66 [INFO] [stdout] | [INFO] [stdout] 156 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | String::deserialize(self.0.into_deserializer()).and_then(|unit_name| { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 162 | | if unit_name == name { [INFO] [stdout] 163 | | visitor.visit_unit() [INFO] [stdout] 164 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn new(iter: Iter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | Self { [INFO] [stdout] 248 | inner: MapDeserializer::new(EnvVars(iter)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `renvar` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/convert.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn from_iter(iter: Iter) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | T::deserialize(EnvVarDeserializer::new(iter.into_iter().map( [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | |(key, value)| { [INFO] [stdout] 156 | | ( [INFO] [stdout] 157 | | String::from(key.trim_matches(is_quote_or_whitespace)), [INFO] [stdout] ... | [INFO] [stdout] 160 | | }, [INFO] [stdout] 161 | | ))) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:161:66 [INFO] [stdout] | [INFO] [stdout] 156 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | String::deserialize(self.0.into_deserializer()).and_then(|unit_name| { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 162 | | if unit_name == name { [INFO] [stdout] 163 | | visitor.visit_unit() [INFO] [stdout] 164 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn new(iter: Iter) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | Self { [INFO] [stdout] 248 | inner: MapDeserializer::new(EnvVars(iter)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `renvar` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "b994de78da915fe5675369ad9ba963ff1bfc1a50c1ac2868cbc40ead05e2c87d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b994de78da915fe5675369ad9ba963ff1bfc1a50c1ac2868cbc40ead05e2c87d", kill_on_drop: false }` [INFO] [stdout] b994de78da915fe5675369ad9ba963ff1bfc1a50c1ac2868cbc40ead05e2c87d