[INFO] fetching crate rental_rod 0.2.1... [INFO] checking rental_rod-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rental_rod 0.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rental_rod 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rental_rod 0.2.1 [INFO] finished tweaking crates.io crate rental_rod 0.2.1 [INFO] tweaked toml for crates.io crate rental_rod 0.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 90 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2edcbb57aaf59b2ca4cb8f9204be6167d0a17f1f9a318773b941e9d372a62855 [INFO] running `Command { std: "docker" "start" "-a" "2edcbb57aaf59b2ca4cb8f9204be6167d0a17f1f9a318773b941e9d372a62855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2edcbb57aaf59b2ca4cb8f9204be6167d0a17f1f9a318773b941e9d372a62855", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2edcbb57aaf59b2ca4cb8f9204be6167d0a17f1f9a318773b941e9d372a62855", kill_on_drop: false }` [INFO] [stdout] 2edcbb57aaf59b2ca4cb8f9204be6167d0a17f1f9a318773b941e9d372a62855 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31222bca8ab4e3cdf6385bf2a1e3e1988a0b87f40842bcacbc66eb7a929d80bc [INFO] running `Command { std: "docker" "start" "-a" "31222bca8ab4e3cdf6385bf2a1e3e1988a0b87f40842bcacbc66eb7a929d80bc", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling rust_decimal_macros v1.36.0 [INFO] [stderr] Checking rental_rod v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:109:31 [INFO] [stdout] | [INFO] [stdout] 109 | let date = NaiveDate::from_ymd(2021, 12, 15); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveTime::from_hms`: use `from_hms_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:110:31 [INFO] [stdout] | [INFO] [stdout] 110 | let time = NaiveTime::from_hms(17, 18, 19); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/db/field_type.rs:111:34 [INFO] [stdout] | [INFO] [stdout] 111 | let datetime = DateTime::from_utc(NaiveDateTime::new(date, time), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:120:31 [INFO] [stdout] | [INFO] [stdout] 120 | let date = NaiveDate::from_ymd(2020, 11, 14); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveTime::from_hms`: use `from_hms_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:121:31 [INFO] [stdout] | [INFO] [stdout] 121 | let time = NaiveTime::from_hms(10, 20, 30).with_nanosecond(149294584).unwrap(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/db/field_type.rs:122:34 [INFO] [stdout] | [INFO] [stdout] 122 | let datetime = DateTime::from_utc(NaiveDateTime::new(date, time), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:136:31 [INFO] [stdout] | [INFO] [stdout] 136 | let date = NaiveDate::from_ymd(2021, 12, 15); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveTime::from_hms`: use `from_hms_opt()` instead [INFO] [stdout] --> src/db/field_type.rs:137:31 [INFO] [stdout] | [INFO] [stdout] 137 | let time = NaiveTime::from_hms(17, 18, 19); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/db/field_type.rs:138:38 [INFO] [stdout] | [INFO] [stdout] 138 | let datetime_utc = DateTime::from_utc(NaiveDateTime::new(date, time), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDate::from_ymd`: use `from_ymd_opt()` instead [INFO] [stdout] --> src/table_manager/v1/reader/parser.rs:225:31 [INFO] [stdout] | [INFO] [stdout] 225 | let date = NaiveDate::from_ymd(2021, 12, 28); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveTime::from_hms_nano`: use `from_hms_nano_opt()` instead [INFO] [stdout] --> src/table_manager/v1/reader/parser.rs:226:31 [INFO] [stdout] | [INFO] [stdout] 226 | let time = NaiveTime::from_hms_nano(17, 11, 14, 492); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/table_manager/v1/reader/parser.rs:227:50 [INFO] [stdout] | [INFO] [stdout] 227 | let dt_expect: DateTime = DateTime::from_utc(NaiveDateTime::new(date, time), Utc); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `create` is never used [INFO] [stdout] --> src/table_manager.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub trait TableManager { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 31 | fn drop(&self) -> Result<(), DbError>; [INFO] [stdout] 32 | fn create(&self) -> Result<(), std::io::Error>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:239:15 [INFO] [stdout] | [INFO] [stdout] 237 | let manager = table_manager::get_table_manager(&self.path, tbl)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | match manager.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 10 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(buf.lines().map(|l| l.expect("Cannot parse line")).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rental_rod` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `create` is never used [INFO] [stdout] --> src/table_manager.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub trait TableManager { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 31 | fn drop(&self) -> Result<(), DbError>; [INFO] [stdout] 32 | fn create(&self) -> Result<(), std::io::Error>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:239:15 [INFO] [stdout] | [INFO] [stdout] 237 | let manager = table_manager::get_table_manager(&self.path, tbl)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | [INFO] [stdout] 239 | match manager.read() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/file.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 10 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Ok(buf.lines().map(|l| l.expect("Cannot parse line")).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rental_rod` (lib test) due to 3 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "31222bca8ab4e3cdf6385bf2a1e3e1988a0b87f40842bcacbc66eb7a929d80bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31222bca8ab4e3cdf6385bf2a1e3e1988a0b87f40842bcacbc66eb7a929d80bc", kill_on_drop: false }` [INFO] [stdout] 31222bca8ab4e3cdf6385bf2a1e3e1988a0b87f40842bcacbc66eb7a929d80bc