[INFO] fetching crate renet_steam 0.0.2... [INFO] checking renet_steam-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate renet_steam 0.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate renet_steam 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate renet_steam 0.0.2 [INFO] finished tweaking crates.io crate renet_steam 0.0.2 [INFO] tweaked toml for crates.io crate renet_steam 0.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate renet_steam 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] df1fd49824b63e7284a47f139810684ca357bdc4ba09774fe06e682b83ec6e8a [INFO] running `Command { std: "docker" "start" "-a" "df1fd49824b63e7284a47f139810684ca357bdc4ba09774fe06e682b83ec6e8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "df1fd49824b63e7284a47f139810684ca357bdc4ba09774fe06e682b83ec6e8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df1fd49824b63e7284a47f139810684ca357bdc4ba09774fe06e682b83ec6e8a", kill_on_drop: false }` [INFO] [stdout] df1fd49824b63e7284a47f139810684ca357bdc4ba09774fe06e682b83ec6e8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23eb81f00a149284079e1332125c9fbef8f7fb0b74b3a27550c8dbffcd12b619 [INFO] running `Command { std: "docker" "start" "-a" "23eb81f00a149284079e1332125c9fbef8f7fb0b74b3a27550c8dbffcd12b619", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling steamworks-sys v0.11.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking octets v0.3.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking renetcode v0.0.12 [INFO] [stderr] Checking renet v0.0.16 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking steamworks v0.11.0 [INFO] [stderr] Checking env_logger v0.11.2 [INFO] [stderr] Checking renet_steam v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 22 | let networking_sockets = client.networking_sockets(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let connection = client [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | networking_sockets, [INFO] [stdout] 30 | | state: ConnectionState::Connected { connection }, [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(client: &Client, config: SteamServerConfig) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let options: Vec = Vec::new(); [INFO] [stdout] 43 | let listen_socket = client.networking_sockets().create_listen_socket_p2p(0, options)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let matchmaking = client.matchmaking(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let friends = client.friends(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | listen_socket, [INFO] [stdout] 49 | | matchmaking, [INFO] [stdout] 50 | | friends, [INFO] [stdout] ... | [INFO] [stdout] 53 | | connections: HashMap::new(), [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `renet_steam` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 22 | let networking_sockets = client.networking_sockets(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let connection = client [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | networking_sockets, [INFO] [stdout] 30 | | state: ConnectionState::Connected { connection }, [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(client: &Client, config: SteamServerConfig) -> Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let options: Vec = Vec::new(); [INFO] [stdout] 43 | let listen_socket = client.networking_sockets().create_listen_socket_p2p(0, options)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let matchmaking = client.matchmaking(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let friends = client.friends(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | listen_socket, [INFO] [stdout] 49 | | matchmaking, [INFO] [stdout] 50 | | friends, [INFO] [stdout] ... | [INFO] [stdout] 53 | | connections: HashMap::new(), [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `renet_steam` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "23eb81f00a149284079e1332125c9fbef8f7fb0b74b3a27550c8dbffcd12b619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23eb81f00a149284079e1332125c9fbef8f7fb0b74b3a27550c8dbffcd12b619", kill_on_drop: false }` [INFO] [stdout] 23eb81f00a149284079e1332125c9fbef8f7fb0b74b3a27550c8dbffcd12b619