[INFO] fetching crate renege 0.1.2... [INFO] checking renege-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate renege 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate renege 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate renege 0.1.2 [INFO] finished tweaking crates.io crate renege 0.1.2 [INFO] tweaked toml for crates.io crate renege 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f18a4572892aedc1261e83198e22810747f1af64a9dede5c01783571fde4ee1b [INFO] running `Command { std: "docker" "start" "-a" "f18a4572892aedc1261e83198e22810747f1af64a9dede5c01783571fde4ee1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f18a4572892aedc1261e83198e22810747f1af64a9dede5c01783571fde4ee1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f18a4572892aedc1261e83198e22810747f1af64a9dede5c01783571fde4ee1b", kill_on_drop: false }` [INFO] [stdout] f18a4572892aedc1261e83198e22810747f1af64a9dede5c01783571fde4ee1b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2193bcc1b2452b37769c3fac45af222f7721a47753fcacd43c7deda5b99b1d6c [INFO] running `Command { std: "docker" "start" "-a" "2193bcc1b2452b37769c3fac45af222f7721a47753fcacd43c7deda5b99b1d6c", kill_on_drop: false }` [INFO] [stderr] Checking renege v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/internal.rs:858:9 [INFO] [stdout] | [INFO] [stdout] 857 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 858 | return never(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/internal.rs:858:9 [INFO] [stdout] | [INFO] [stdout] 857 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 858 | return never(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/internal.rs:877:9 [INFO] [stdout] | [INFO] [stdout] 876 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 877 | return never(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/internal.rs:877:9 [INFO] [stdout] | [INFO] [stdout] 876 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 877 | return never(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ unreachable statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/internal.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 794 | Ok(res) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `alloc` [INFO] [stdout] --> src/internal.rs:951:11 [INFO] [stdout] | [INFO] [stdout] 951 | fn unlock(alloc: &mut ThreadAllocator, block: TokenBlockRef<'static>, ext_id: ExtTokenId) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_alloc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/internal.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 794 | Ok(res) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `alloc` [INFO] [stdout] --> src/internal.rs:951:11 [INFO] [stdout] | [INFO] [stdout] 951 | fn unlock(alloc: &mut ThreadAllocator, block: TokenBlockRef<'static>, ext_id: ExtTokenId) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_alloc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 16 | pub const fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self(UnsafeCell::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:1279:20 [INFO] [stdout] | [INFO] [stdout] 1278 | pub fn with(f: impl FnOnce(&mut ThreadAllocator) -> R) -> R { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1279 | ALLOC.with(|cell| f(&mut cell.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:1279:34 [INFO] [stdout] | [INFO] [stdout] 1278 | pub fn with(f: impl FnOnce(&mut ThreadAllocator) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1279 | ALLOC.with(|cell| f(&mut cell.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:17:14 [INFO] [stdout] | [INFO] [stdout] 16 | pub const fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self(UnsafeCell::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:1279:20 [INFO] [stdout] | [INFO] [stdout] 1278 | pub fn with(f: impl FnOnce(&mut ThreadAllocator) -> R) -> R { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1279 | ALLOC.with(|cell| f(&mut cell.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:1279:34 [INFO] [stdout] | [INFO] [stdout] 1278 | pub fn with(f: impl FnOnce(&mut ThreadAllocator) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1279 | ALLOC.with(|cell| f(&mut cell.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `renege` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `renege` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2193bcc1b2452b37769c3fac45af222f7721a47753fcacd43c7deda5b99b1d6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2193bcc1b2452b37769c3fac45af222f7721a47753fcacd43c7deda5b99b1d6c", kill_on_drop: false }` [INFO] [stdout] 2193bcc1b2452b37769c3fac45af222f7721a47753fcacd43c7deda5b99b1d6c