[INFO] fetching crate rendy-mesh 0.5.1... [INFO] checking rendy-mesh-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rendy-mesh 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rendy-mesh 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rendy-mesh 0.5.1 [INFO] finished tweaking crates.io crate rendy-mesh 0.5.1 [INFO] tweaked toml for crates.io crate rendy-mesh 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.4.12 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding colorful v0.2.2 (latest: v0.3.2) [INFO] [stderr] Adding crossbeam-channel v0.3.9 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding gfx-hal v0.4.1 (latest: v0.9.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding lexical v2.2.4 (latest: v6.1.1) [INFO] [stderr] Adding lexical-core v0.4.8 (latest: v0.8.5) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding raw-window-handle v0.3.4 (latest: v0.6.2) [INFO] [stderr] Adding raw-window-handle v0.4.3 (latest: v0.6.2) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding static_assertions v0.3.4 (latest: v1.1.0) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wavefront_obj v6.0.0 (latest: v10.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2cb5550764027f600ba3cdbfbfc4a11bd5a261d94462091191f0ab3a60e319d [INFO] running `Command { std: "docker" "start" "-a" "d2cb5550764027f600ba3cdbfbfc4a11bd5a261d94462091191f0ab3a60e319d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2cb5550764027f600ba3cdbfbfc4a11bd5a261d94462091191f0ab3a60e319d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2cb5550764027f600ba3cdbfbfc4a11bd5a261d94462091191f0ab3a60e319d", kill_on_drop: false }` [INFO] [stdout] d2cb5550764027f600ba3cdbfbfc4a11bd5a261d94462091191f0ab3a60e319d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed8aedc6f0b15624f168818229c7da8f4c8c4ca6c5589188efe3a3d0cc2f9221 [INFO] running `Command { std: "docker" "start" "-a" "ed8aedc6f0b15624f168818229c7da8f4c8c4ca6c5589188efe3a3d0cc2f9221", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking colorful v0.2.2 [INFO] [stderr] Checking hibitset v0.6.4 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking gfx-hal v0.4.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking thread_profiler v0.3.0 [INFO] [stderr] Checking rendy-core v0.5.1 [INFO] [stderr] Checking relevant v0.4.2 [INFO] [stderr] Checking rendy-descriptor v0.5.1 [INFO] [stderr] Checking rendy-memory v0.5.2 [INFO] [stderr] Checking rendy-resource v0.5.1 [INFO] [stderr] Checking rendy-command v0.5.1 [INFO] [stderr] Checking rendy-wsi v0.5.1 [INFO] [stderr] Checking rendy-factory v0.5.1 [INFO] [stderr] Checking rendy-mesh v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `format::*` [INFO] [stdout] --> src/lib.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub use crate::{format::*, mesh::*}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `format::*` [INFO] [stdout] --> src/lib.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub use crate::{format::*, mesh::*}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn into_owned(self) -> MeshBuilder<'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | MeshBuilder { [INFO] [stdout] 127 | vertices: self [INFO] [stdout] | _______________________^ [INFO] [stdout] 128 | | .vertices [INFO] [stdout] 129 | | .into_iter() [INFO] [stdout] 130 | | .map(|v| RawVertices { [INFO] [stdout] ... | [INFO] [stdout] 133 | | }) [INFO] [stdout] 134 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 237 | let mut staging = factory [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut buffer = factory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | let mut writer = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | let index_buffer = match self.indices { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let mut buffer = factory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | Ok(Mesh { [INFO] [stdout] | ____________^ [INFO] [stdout] 336 | | vertex_layouts, [INFO] [stdout] 337 | | index_buffer, [INFO] [stdout] 338 | | vertex_buffer: buffer, [INFO] [stdout] 339 | | prim: self.prim, [INFO] [stdout] 340 | | len, [INFO] [stdout] 341 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/mesh.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | drop(staging_slice); [INFO] [stdout] | ^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut [u8]` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 281 - drop(staging_slice); [INFO] [stdout] 281 + let _ = staging_slice; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 390 | let mut vertex = smallvec::SmallVec::<[_; 16]>::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | Ok(vertex.into_iter().map(move |offset| (buffer, offset))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn into_owned(self) -> MeshBuilder<'static> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | MeshBuilder { [INFO] [stdout] 127 | vertices: self [INFO] [stdout] | _______________________^ [INFO] [stdout] 128 | | .vertices [INFO] [stdout] 129 | | .into_iter() [INFO] [stdout] 130 | | .map(|v| RawVertices { [INFO] [stdout] ... | [INFO] [stdout] 133 | | }) [INFO] [stdout] 134 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:335:12 [INFO] [stdout] | [INFO] [stdout] 237 | let mut staging = factory [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | let mut buffer = factory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | let mut writer = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | let index_buffer = match self.indices { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | let mut buffer = factory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | Ok(Mesh { [INFO] [stdout] | ____________^ [INFO] [stdout] 336 | | vertex_layouts, [INFO] [stdout] 337 | | index_buffer, [INFO] [stdout] 338 | | vertex_buffer: buffer, [INFO] [stdout] 339 | | prim: self.prim, [INFO] [stdout] 340 | | len, [INFO] [stdout] 341 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/mesh.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | drop(staging_slice); [INFO] [stdout] | ^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut [u8]` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 281 - drop(staging_slice); [INFO] [stdout] 281 + let _ = staging_slice; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:411:12 [INFO] [stdout] | [INFO] [stdout] 390 | let mut vertex = smallvec::SmallVec::<[_; 16]>::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | Ok(vertex.into_iter().map(move |offset| (buffer, offset))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendy-mesh` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rendy-mesh` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ed8aedc6f0b15624f168818229c7da8f4c8c4ca6c5589188efe3a3d0cc2f9221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed8aedc6f0b15624f168818229c7da8f4c8c4ca6c5589188efe3a3d0cc2f9221", kill_on_drop: false }` [INFO] [stdout] ed8aedc6f0b15624f168818229c7da8f4c8c4ca6c5589188efe3a3d0cc2f9221