[INFO] fetching crate rendy-frame 0.5.1... [INFO] checking rendy-frame-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rendy-frame 0.5.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rendy-frame 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rendy-frame 0.5.1 [INFO] finished tweaking crates.io crate rendy-frame 0.5.1 [INFO] tweaked toml for crates.io crate rendy-frame 0.5.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding colorful v0.2.2 (latest: v0.3.2) [INFO] [stderr] Adding crossbeam-channel v0.3.9 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding gfx-hal v0.4.1 (latest: v0.9.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding raw-window-handle v0.3.4 (latest: v0.6.2) [INFO] [stderr] Adding raw-window-handle v0.4.3 (latest: v0.6.2) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f93d3f4038f60c06ecb3fd0599e9487e5cd0499e7f2163e5878cc39b7b11e09c [INFO] running `Command { std: "docker" "start" "-a" "f93d3f4038f60c06ecb3fd0599e9487e5cd0499e7f2163e5878cc39b7b11e09c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f93d3f4038f60c06ecb3fd0599e9487e5cd0499e7f2163e5878cc39b7b11e09c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f93d3f4038f60c06ecb3fd0599e9487e5cd0499e7f2163e5878cc39b7b11e09c", kill_on_drop: false }` [INFO] [stdout] f93d3f4038f60c06ecb3fd0599e9487e5cd0499e7f2163e5878cc39b7b11e09c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1c267a71f0ea0d9d27fcad57f046ec373218c1c6be9f2ac391c746bf7ce4ee9 [INFO] running `Command { std: "docker" "start" "-a" "f1c267a71f0ea0d9d27fcad57f046ec373218c1c6be9f2ac391c746bf7ce4ee9", kill_on_drop: false }` [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking colorful v0.2.2 [INFO] [stderr] Checking hibitset v0.6.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking relevant v0.4.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking gfx-hal v0.4.1 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking rendy-descriptor v0.5.1 [INFO] [stderr] Checking rendy-memory v0.5.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking thread_profiler v0.3.0 [INFO] [stderr] Checking rendy-core v0.5.1 [INFO] [stderr] Checking rendy-resource v0.5.1 [INFO] [stderr] Checking rendy-command v0.5.1 [INFO] [stderr] Checking rendy-wsi v0.5.1 [INFO] [stderr] Checking rendy-factory v0.5.1 [INFO] [stderr] Checking rendy-frame v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `values` is never read [INFO] [stdout] --> src/cirque/mod.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 195 | pub struct DependentCirque { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 196 | values: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DependentCirque` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn init(self, init: impl FnOnce(I) -> T) -> ReadyRef<'a, T, I, P> { [INFO] [stdout] | ---- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | value: init(self.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn reset(self, reset: impl FnOnce(T) -> I) -> InitialRef<'a, T, I, P> { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | value: reset(self.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn finish(self, finish: impl FnOnce(T) -> P) { [INFO] [stdout] | ---- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | .push_back((finish(self.value), self.index, self.frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:146:47 [INFO] [stdout] | [INFO] [stdout] 146 | .for_each(|(value, _, _)| dispose(either::Right(value))); [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:149:44 [INFO] [stdout] | [INFO] [stdout] 149 | .for_each(|(value, _)| dispose(either::Left(value))); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/command.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | || pool.allocate_buffers(1).pop().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendy-frame` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `values` is never read [INFO] [stdout] --> src/cirque/mod.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 195 | pub struct DependentCirque { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 196 | values: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DependentCirque` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn init(self, init: impl FnOnce(I) -> T) -> ReadyRef<'a, T, I, P> { [INFO] [stdout] | ---- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | value: init(self.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 90 | pub fn reset(self, reset: impl FnOnce(T) -> I) -> InitialRef<'a, T, I, P> { [INFO] [stdout] | ---- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | value: reset(self.value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn finish(self, finish: impl FnOnce(T) -> P) { [INFO] [stdout] | ---- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | .push_back((finish(self.value), self.index, self.frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:146:47 [INFO] [stdout] | [INFO] [stdout] 146 | .for_each(|(value, _, _)| dispose(either::Right(value))); [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/mod.rs:149:44 [INFO] [stdout] | [INFO] [stdout] 149 | .for_each(|(value, _)| dispose(either::Left(value))); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cirque/command.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | || pool.allocate_buffers(1).pop().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendy-frame` (lib) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f1c267a71f0ea0d9d27fcad57f046ec373218c1c6be9f2ac391c746bf7ce4ee9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1c267a71f0ea0d9d27fcad57f046ec373218c1c6be9f2ac391c746bf7ce4ee9", kill_on_drop: false }` [INFO] [stdout] f1c267a71f0ea0d9d27fcad57f046ec373218c1c6be9f2ac391c746bf7ce4ee9