[INFO] fetching crate rendezvous_swap 0.1.0... [INFO] checking rendezvous_swap-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rendezvous_swap 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rendezvous_swap 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rendezvous_swap 0.1.0 [INFO] finished tweaking crates.io crate rendezvous_swap 0.1.0 [INFO] tweaked toml for crates.io crate rendezvous_swap 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 884b962bb7bae6442634bafc6473425185c84ebaabe3f2e05fa160f4fffaf634 [INFO] running `Command { std: "docker" "start" "-a" "884b962bb7bae6442634bafc6473425185c84ebaabe3f2e05fa160f4fffaf634", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "884b962bb7bae6442634bafc6473425185c84ebaabe3f2e05fa160f4fffaf634", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "884b962bb7bae6442634bafc6473425185c84ebaabe3f2e05fa160f4fffaf634", kill_on_drop: false }` [INFO] [stdout] 884b962bb7bae6442634bafc6473425185c84ebaabe3f2e05fa160f4fffaf634 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7fc2514bc2f1e23d1a6fb2a858ae212603aa4034fbbc9264835f3674a8b558d [INFO] running `Command { std: "docker" "start" "-a" "f7fc2514bc2f1e23d1a6fb2a858ae212603aa4034fbbc9264835f3674a8b558d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking cache-padded v1.3.0 [INFO] [stderr] Checking rendezvous_swap v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v2.34.0 [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | use cache_padded::CachePadded; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | c1: CachePadded, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | c2: CachePadded, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | p1: CachePadded>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | p2: CachePadded>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | c1: CachePadded::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 34 | c2: CachePadded::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 35 | p1: CachePadded::new(UnsafeCell::new(data1)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `cache_padded::CachePadded`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 36 | p2: CachePadded::new(UnsafeCell::new(data2)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `cache_padded::CachePadded::::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 33 | c1: CachePadded::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `cache_padded::CachePadded::::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:34:30 [INFO] [stdout] | [INFO] [stdout] 34 | c2: CachePadded::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `cache_padded::CachePadded::::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | p1: CachePadded::new(UnsafeCell::new(data1)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `cache_padded::CachePadded::::new`: This crate is now deprecated in favor of [crossbeam-utils::CachePadded](https://docs.rs/crossbeam-utils/latest/crossbeam_utils/struct.CachePadded.html). [INFO] [stdout] --> src/rendezvous_data.rs:36:30 [INFO] [stdout] | [INFO] [stdout] 36 | p2: CachePadded::new(UnsafeCell::new(data2)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous_data.rs:35:17 [INFO] [stdout] | [INFO] [stdout] 31 | const fn new(data1: T, data2: T) -> Self { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | p1: CachePadded::new(UnsafeCell::new(data1)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous_data.rs:36:17 [INFO] [stdout] | [INFO] [stdout] 31 | const fn new(data1: T, data2: T) -> Self { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | p2: CachePadded::new(UnsafeCell::new(data2)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous_data.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(data1: T, data2: T) -> (Self, Self) { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let a = Arc::pin(RendezvousDataShared::new(data1, data2)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / Self { [INFO] [stdout] 117 | | generation: 0, [INFO] [stdout] 118 | | my_counter: (&*a.c1).into(), [INFO] [stdout] 119 | | their_counter: (&*a.c2).into(), [INFO] [stdout] 120 | | data: (p1, p2), [INFO] [stdout] 121 | | _handle: a.clone(), [INFO] [stdout] 122 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous_data.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(data1: T, data2: T) -> (Self, Self) { [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let a = Arc::pin(RendezvousDataShared::new(data1, data2)); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | / Self { [INFO] [stdout] 124 | | generation: 0, [INFO] [stdout] 125 | | my_counter: (&*a.c2).into(), [INFO] [stdout] 126 | | their_counter: (&*a.c1).into(), [INFO] [stdout] 127 | | data: (p2, p1), [INFO] [stdout] 128 | | _handle: a.clone(), [INFO] [stdout] 129 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 73 | let first = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let second = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ( [INFO] [stdout] 76 | / Self { [INFO] [stdout] 77 | | my_counter: Arc::clone(&first), [INFO] [stdout] 78 | | their_counter: Arc::clone(&second), [INFO] [stdout] 79 | | generation: 0, [INFO] [stdout] 80 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rendezvous.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 73 | let first = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let second = Arc::new(AtomicUsize::new(0)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | / Self { [INFO] [stdout] 82 | | my_counter: second, [INFO] [stdout] 83 | | their_counter: first, [INFO] [stdout] 84 | | generation: 0, [INFO] [stdout] 85 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendezvous_swap` (lib) due to 7 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f7fc2514bc2f1e23d1a6fb2a858ae212603aa4034fbbc9264835f3674a8b558d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7fc2514bc2f1e23d1a6fb2a858ae212603aa4034fbbc9264835f3674a8b558d", kill_on_drop: false }` [INFO] [stdout] f7fc2514bc2f1e23d1a6fb2a858ae212603aa4034fbbc9264835f3674a8b558d