[INFO] fetching crate rendersvg-meetmangukiya 0.9.1... [INFO] checking rendersvg-meetmangukiya-0.9.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rendersvg-meetmangukiya 0.9.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate rendersvg-meetmangukiya 0.9.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rendersvg-meetmangukiya 0.9.1 [INFO] finished tweaking crates.io crate rendersvg-meetmangukiya 0.9.1 [INFO] tweaked toml for crates.io crate rendersvg-meetmangukiya 0.9.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate rendersvg-meetmangukiya 0.9.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84422498aa2c597347c9ae96953073c5dc422a7fc3a6f31bcc0feb6665cb4f50 [INFO] running `Command { std: "docker" "start" "-a" "84422498aa2c597347c9ae96953073c5dc422a7fc3a6f31bcc0feb6665cb4f50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84422498aa2c597347c9ae96953073c5dc422a7fc3a6f31bcc0feb6665cb4f50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84422498aa2c597347c9ae96953073c5dc422a7fc3a6f31bcc0feb6665cb4f50", kill_on_drop: false }` [INFO] [stdout] 84422498aa2c597347c9ae96953073c5dc422a7fc3a6f31bcc0feb6665cb4f50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 985bc106cd3f7d65d75e67be5729b976f1d2ecf74b115016190d7c985ff9d1f3 [INFO] running `Command { std: "docker" "start" "-a" "985bc106cd3f7d65d75e67be5729b976f1d2ecf74b115016190d7c985ff9d1f3", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking float-cmp v0.5.3 [INFO] [stderr] Checking siphasher v0.2.3 [INFO] [stderr] Checking xmlparser v0.13.1 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking ttf-parser v0.3.0 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking rctree v0.3.3 [INFO] [stderr] Checking base64 v0.11.0 [INFO] [stderr] Checking rgb v0.8.17 [INFO] [stderr] Checking data-url v0.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking svgtypes v0.5.0 [INFO] [stderr] Checking unicode-script v0.5.0 [INFO] [stderr] Checking png v0.15.3 [INFO] [stderr] Checking pico-args v0.2.0 [INFO] [stderr] Checking kurbo v0.5.11 [INFO] [stderr] Checking svgfilters v0.1.0 [INFO] [stderr] Checking simplecss v0.2.0 [INFO] [stderr] Checking fern v0.5.8 [INFO] [stderr] Checking roxmltree v0.9.1 [INFO] [stderr] Checking jpeg-decoder v0.1.18 [INFO] [stderr] Compiling cmake v0.1.42 [INFO] [stderr] Compiling harfbuzz-sys v0.3.4 [INFO] [stderr] Compiling servo-freetype-sys v4.0.5 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking freetype v0.4.1 [INFO] [stderr] Checking harfbuzz_rs v1.0.1 [INFO] [stderr] Checking usvg v0.9.0 [INFO] [stderr] Checking resvg v0.9.0 [INFO] [stderr] Checking rendersvg-meetmangukiya v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 38 | bail!("rendersvg has been built without any backends") [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 46 | bail!(e) [INFO] [stdout] | -------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 71 | _ => bail!("unknown backend"), [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:20:44 [INFO] [stdout] | [INFO] [stdout] 20 | return Err(format!($fmt, $($arg)*)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 102 | bail!("SVG doesn't have '{}' ID", id) [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 110 | None => { bail!("failed to allocate an image") } [INFO] [stdout] | ------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ------------------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 41 | / let (args, opt) = match args::parse() { [INFO] [stdout] 42 | | Ok((args, opt)) => (args, opt), [INFO] [stdout] 43 | | Err(e) => { [INFO] [stdout] 44 | | args::print_help(); [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | }; [INFO] [stdout] | |______^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/args.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | let mut list = Vec::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opt` [INFO] [stdout] --> src/main.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | let (args, opt) = match args::parse() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_opt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `backend` [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let backend: Box = match args.backend_name.as_str() { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_backend` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 38 | bail!("rendersvg has been built without any backends") [INFO] [stdout] | ------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 46 | bail!(e) [INFO] [stdout] | -------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 71 | _ => bail!("unknown backend"), [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:20:44 [INFO] [stdout] | [INFO] [stdout] 20 | return Err(format!($fmt, $($arg)*)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 102 | bail!("SVG doesn't have '{}' ID", id) [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/main.rs:17:40 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 110 | None => { bail!("failed to allocate an image") } [INFO] [stdout] | ------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `bail` [INFO] [stdout] = note: this warning originates in the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:99:70 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(node) = tree.root().descendants().find(|n| &*n.id() == id) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/main.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 17 | return Err(format!("{}", $msg)); [INFO] [stdout] | ------------------------------- any code following this expression is unreachable [INFO] [stdout] ... [INFO] [stdout] 41 | / let (args, opt) = match args::parse() { [INFO] [stdout] 42 | | Ok((args, opt)) => (args, opt), [INFO] [stdout] 43 | | Err(e) => { [INFO] [stdout] 44 | | args::print_help(); [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | }; [INFO] [stdout] | |______^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendersvg-meetmangukiya` (bin "rendersvg-meetmangukiya") due to 2 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/args.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | let mut list = Vec::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opt` [INFO] [stdout] --> src/main.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | let (args, opt) = match args::parse() { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_opt` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `backend` [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | let backend: Box = match args.backend_name.as_str() { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_backend` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:99:70 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(node) = tree.root().descendants().find(|n| &*n.id() == id) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rendersvg-meetmangukiya` (bin "rendersvg-meetmangukiya" test) due to 2 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "985bc106cd3f7d65d75e67be5729b976f1d2ecf74b115016190d7c985ff9d1f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "985bc106cd3f7d65d75e67be5729b976f1d2ecf74b115016190d7c985ff9d1f3", kill_on_drop: false }` [INFO] [stdout] 985bc106cd3f7d65d75e67be5729b976f1d2ecf74b115016190d7c985ff9d1f3