[INFO] fetching crate remote-trait-object-macro 0.4.1... [INFO] checking remote-trait-object-macro-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate remote-trait-object-macro 0.4.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate remote-trait-object-macro 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate remote-trait-object-macro 0.4.1 [INFO] finished tweaking crates.io crate remote-trait-object-macro 0.4.1 [INFO] tweaked toml for crates.io crate remote-trait-object-macro 0.4.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 996290548e28c6545b4434937a3d0d6b57668ca9da912e5377e6760fc352b5ca [INFO] running `Command { std: "docker" "start" "-a" "996290548e28c6545b4434937a3d0d6b57668ca9da912e5377e6760fc352b5ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "996290548e28c6545b4434937a3d0d6b57668ca9da912e5377e6760fc352b5ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "996290548e28c6545b4434937a3d0d6b57668ca9da912e5377e6760fc352b5ca", kill_on_drop: false }` [INFO] [stdout] 996290548e28c6545b4434937a3d0d6b57668ca9da912e5377e6760fc352b5ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d92ccb6297e9f6a0aed73e6f28b511fa1606f4fbf834cd68435729f352d85a76 [INFO] running `Command { std: "docker" "start" "-a" "d92ccb6297e9f6a0aed73e6f28b511fa1606f4fbf834cd68435729f352d85a76", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking proc-macro-crate v0.1.5 [INFO] [stderr] Checking remote-trait-object-macro v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn service(args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match service::service(TokenStream2::from(args), TokenStream2::from(input)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helper.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn path_of_single_ident(ident: syn::Ident) -> syn::Path { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 4 | segments: { [INFO] [stdout] | ___________________^ [INFO] [stdout] 5 | | let mut punc = syn::punctuated::Punctuated::new(); [INFO] [stdout] 6 | | punc.push(syn::PathSegment { [INFO] [stdout] 7 | | ident, [INFO] [stdout] ... | [INFO] [stdout] 10 | | punc [INFO] [stdout] 11 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 18 | let arg_name = input.parse()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | input.parse::()?; [INFO] [stdout] 20 | let arg_value = input.parse()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | arg_name, [INFO] [stdout] 23 | | arg_value, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:76:27 [INFO] [stdout] | [INFO] [stdout] 74 | fn fill_default_values(self) -> MacroArgs { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | MacroArgs { [INFO] [stdout] 76 | serde_format: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 77 | | .serde_format [INFO] [stdout] 78 | | .unwrap_or_else(|| syn::parse2(quote! {remote_trait_object::macro_env::DefaultSerdeFormat}).unwrap()), [INFO] [stdout] | |_____________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | .unwrap_or_else(|| syn::parse2(quote! {remote_trait_object::macro_env::DefaultSerdeFormat}).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/from_skeleton.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 15 | let env_path = create_env_path(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | [INFO] [stdout] 17 | let trait_ident = source_trait.ident.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let struct_ident = quote::format_ident!("{}FromSkeleton", trait_ident); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let mut imported_struct = quote! { [INFO] [stdout] | _____________---------------___- [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | | #[derive(Debug)] [INFO] [stdout] 21 | | #[doc(hidden)] [INFO] [stdout] 22 | | /// This type is generated by the remote-trait-object macro. [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let mut imported_struct_impl = syn::parse2::(quote! { [INFO] [stdout] | _____________--------------------________________________________- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | impl #trait_ident for #struct_ident { [INFO] [stdout] 30 | } [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | | Ok(imported_struct.to_token_stream()) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/proxy.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 12 | let env_path = create_env_path(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | [INFO] [stdout] 14 | let trait_ident = source_trait.ident.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let struct_ident = quote::format_ident!("{}Proxy", trait_ident); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let mut imported_struct = quote! { [INFO] [stdout] | _____________---------------___- [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | |_____________|_________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | | #[derive(Debug)] [INFO] [stdout] 18 | | #[doc(hidden)] [INFO] [stdout] 19 | | /// This type is generated by the remote-trait-object macro. [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let mut imported_struct_impl = syn::parse2::(quote! { [INFO] [stdout] | _____________--------------------________________________________- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | impl #trait_ident for #struct_ident { [INFO] [stdout] 27 | } [INFO] [stdout] 28 | | }) [INFO] [stdout] | |_____- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | | Ok(imported_struct.to_token_stream()) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `remote-trait-object-macro` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d92ccb6297e9f6a0aed73e6f28b511fa1606f4fbf834cd68435729f352d85a76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d92ccb6297e9f6a0aed73e6f28b511fa1606f4fbf834cd68435729f352d85a76", kill_on_drop: false }` [INFO] [stdout] d92ccb6297e9f6a0aed73e6f28b511fa1606f4fbf834cd68435729f352d85a76