[INFO] fetching crate remediate 0.2.1... [INFO] checking remediate-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate remediate 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate remediate 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate remediate 0.2.1 [INFO] finished tweaking crates.io crate remediate 0.2.1 [INFO] tweaked toml for crates.io crate remediate 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding num_enum v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fae6ec751f2e87a4ba9106f7957093359ab70b89ec9cf10cc641191b10d2338e [INFO] running `Command { std: "docker" "start" "-a" "fae6ec751f2e87a4ba9106f7957093359ab70b89ec9cf10cc641191b10d2338e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fae6ec751f2e87a4ba9106f7957093359ab70b89ec9cf10cc641191b10d2338e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fae6ec751f2e87a4ba9106f7957093359ab70b89ec9cf10cc641191b10d2338e", kill_on_drop: false }` [INFO] [stdout] fae6ec751f2e87a4ba9106f7957093359ab70b89ec9cf10cc641191b10d2338e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a3caebfe14b32210d3f086b3ed1425ac263ac39a1fc4526cf7d1b05d6d1c24e [INFO] running `Command { std: "docker" "start" "-a" "7a3caebfe14b32210d3f086b3ed1425ac263ac39a1fc4526cf7d1b05d6d1c24e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling bytecheck v0.6.12 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling rend v0.4.2 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling rkyv v0.7.45 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling ptr_meta_derive v0.1.4 [INFO] [stderr] Compiling bytecheck_derive v0.6.12 [INFO] [stderr] Compiling rkyv_derive v0.7.45 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Compiling pest-ast v0.3.4 [INFO] [stderr] Checking ptr_meta v0.1.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num_enum v0.6.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking from-pest v0.3.2 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking remediate v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | type Score: Query; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | type Score: Query; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule/sm2.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use super::{Query, Review}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule/sm2.rs:38:6 [INFO] [stdout] | [INFO] [stdout] 38 | impl Query for Score { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule/sm2.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | use super::{Query, Review}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated trait `schedule::Query` [INFO] [stdout] --> src/schedule/sm2.rs:38:6 [INFO] [stdout] | [INFO] [stdout] 38 | impl Query for Score { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0210]: type parameter `T` must be covered by another type when it appears before the first local type (`reverse::Reverse<_>`) [INFO] [stdout] --> src/archive/impls/reverse.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | impl Deserialize, D> for Archived [INFO] [stdout] | ^ type parameter `T` must be covered by another type when it appears before the first local type (`reverse::Reverse<_>`) [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #124559 [INFO] [stdout] = note: implementing a foreign trait is only possible if at least one of the types for which it is implemented is local, and no uncovered type parameters appear before that first local type [INFO] [stdout] = note: in this case, 'before' refers to the following order: `impl<..> ForeignTrait for T0`, where `T0` is the first and `Tn` is the last [INFO] [stdout] = note: `#[warn(uncovered_param_in_projection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning[E0210]: type parameter `T` must be covered by another type when it appears before the first local type (`reverse::Reverse<_>`) [INFO] [stdout] --> src/archive/impls/reverse.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | impl Deserialize, D> for Archived [INFO] [stdout] | ^ type parameter `T` must be covered by another type when it appears before the first local type (`reverse::Reverse<_>`) [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #124559 [INFO] [stdout] = note: implementing a foreign trait is only possible if at least one of the types for which it is implemented is local, and no uncovered type parameters appear before that first local type [INFO] [stdout] = note: in this case, 'before' refers to the following order: `impl<..> ForeignTrait for T0`, where `T0` is the first and `Tn` is the last [INFO] [stdout] = note: `#[warn(uncovered_param_in_projection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive/impls/reverse.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Self(cmp::Reverse(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deck.rs:46:69 [INFO] [stdout] | [INFO] [stdout] 44 | .map(move |location| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ( [INFO] [stdout] 46 | Self::deserialize(workspace.read::(location.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/fs.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | .map(move |entry| (entry.path(), entry.metadata().unwrap().is_dir())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0210`. [INFO] [stdout] [INFO] [stderr] error: could not compile `remediate` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archive/impls/reverse.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(data: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Self(cmp::Reverse(data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deck.rs:46:69 [INFO] [stdout] | [INFO] [stdout] 44 | .map(move |location| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | ( [INFO] [stdout] 46 | Self::deserialize(workspace.read::(location.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace/fs.rs:72:46 [INFO] [stdout] | [INFO] [stdout] 72 | .map(move |entry| (entry.path(), entry.metadata().unwrap().is_dir())) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/workspace.rs:35:42 [INFO] [stdout] | [INFO] [stdout] 35 | Lazy::new(|| LocalWorkspace::new(TempDir::new("remediate").unwrap().into_path())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0210`. [INFO] [stdout] [INFO] [stderr] error: could not compile `remediate` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7a3caebfe14b32210d3f086b3ed1425ac263ac39a1fc4526cf7d1b05d6d1c24e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a3caebfe14b32210d3f086b3ed1425ac263ac39a1fc4526cf7d1b05d6d1c24e", kill_on_drop: false }` [INFO] [stdout] 7a3caebfe14b32210d3f086b3ed1425ac263ac39a1fc4526cf7d1b05d6d1c24e