[INFO] fetching crate remarkable_lines 0.1.2... [INFO] checking remarkable_lines-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate remarkable_lines 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate remarkable_lines 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate remarkable_lines 0.1.2 [INFO] finished tweaking crates.io crate remarkable_lines 0.1.2 [INFO] tweaked toml for crates.io crate remarkable_lines 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 740c43c5e4e28aff6825ef052671c852c2bafe771bbeeb145a570dd11b668d34 [INFO] running `Command { std: "docker" "start" "-a" "740c43c5e4e28aff6825ef052671c852c2bafe771bbeeb145a570dd11b668d34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "740c43c5e4e28aff6825ef052671c852c2bafe771bbeeb145a570dd11b668d34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "740c43c5e4e28aff6825ef052671c852c2bafe771bbeeb145a570dd11b668d34", kill_on_drop: false }` [INFO] [stdout] 740c43c5e4e28aff6825ef052671c852c2bafe771bbeeb145a570dd11b668d34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd5d3b088e20eea3fd55d1d6985d4b7fa1d78f3f1b54ba1cc50146b0e6cf626d [INFO] running `Command { std: "docker" "start" "-a" "cd5d3b088e20eea3fd55d1d6985d4b7fa1d78f3f1b54ba1cc50146b0e6cf626d", kill_on_drop: false }` [INFO] [stderr] Checking remarkable_lines v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `x`, `y`, `w`, and `h` are never read [INFO] [stdout] --> src/v6/scene_item/glyph_range.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Rectangle { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 5 | x: f64, [INFO] [stdout] | ^ [INFO] [stdout] 6 | y: f64, [INFO] [stdout] | ^ [INFO] [stdout] 7 | w: f64, [INFO] [stdout] | ^ [INFO] [stdout] 8 | h: f64, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Rectangle` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start`, `length`, `text`, `color`, and `rectangles` are never read [INFO] [stdout] --> src/v6/scene_item/glyph_range.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct GlyphRange { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 26 | start: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 27 | length: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 28 | text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 29 | color: PenColor, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 30 | rectangles: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GlyphRange` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `color`, `tool`, `points`, `thickness_scale`, and `starting_length` are never read [INFO] [stdout] --> src/v6/scene_item/line.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Line { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | color: PenColor, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | tool: Tool, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | points: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 15 | thickness_scale: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 16 | starting_length: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Line` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x`, `y`, `speed`, `direction`, `width`, and `pressure` are never read [INFO] [stdout] --> src/v6/scene_item/point.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Point { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 7 | x: f32, [INFO] [stdout] | ^ [INFO] [stdout] 8 | y: f32, [INFO] [stdout] | ^ [INFO] [stdout] 9 | speed: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 10 | direction: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 11 | width: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | pressure: f32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/v6/scene_tree.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_id` is never read [INFO] [stdout] --> src/v6/scene_tree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct SceneTree { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 21 | nodes: HashMap, [INFO] [stdout] 22 | root_id: CrdtId, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SceneTree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitreader.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(bits: N) -> Bitreader { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Bitreader { [INFO] [stdout] 16 | cursor: Cursor::new(bits), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x`, `y`, `w`, and `h` are never read [INFO] [stdout] --> src/v6/scene_item/glyph_range.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Rectangle { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 5 | x: f64, [INFO] [stdout] | ^ [INFO] [stdout] 6 | y: f64, [INFO] [stdout] | ^ [INFO] [stdout] 7 | w: f64, [INFO] [stdout] | ^ [INFO] [stdout] 8 | h: f64, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Rectangle` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start`, `length`, `text`, `color`, and `rectangles` are never read [INFO] [stdout] --> src/v6/scene_item/glyph_range.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct GlyphRange { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 26 | start: u32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 27 | length: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 28 | text: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 29 | color: PenColor, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 30 | rectangles: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GlyphRange` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `color`, `tool`, `points`, `thickness_scale`, and `starting_length` are never read [INFO] [stdout] --> src/v6/scene_item/line.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Line { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | color: PenColor, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | tool: Tool, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | points: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 15 | thickness_scale: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 16 | starting_length: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Line` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x`, `y`, `speed`, `direction`, `width`, and `pressure` are never read [INFO] [stdout] --> src/v6/scene_item/point.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Point { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 7 | x: f32, [INFO] [stdout] | ^ [INFO] [stdout] 8 | y: f32, [INFO] [stdout] | ^ [INFO] [stdout] 9 | speed: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 10 | direction: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 11 | width: f32, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | pressure: f32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/v6/scene_tree.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root_id` is never read [INFO] [stdout] --> src/v6/scene_tree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub struct SceneTree { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 21 | nodes: HashMap, [INFO] [stdout] 22 | root_id: CrdtId, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SceneTree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitreader.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(bits: N) -> Bitreader { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Bitreader { [INFO] [stdout] 16 | cursor: Cursor::new(bits), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v6/block/blocks.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 221 | let value = if reader.has_subblock(6)? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let value = get_value(info, reader)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Ok(SceneItemBlock { [INFO] [stdout] | ____________^ [INFO] [stdout] 232 | | parent_id, [INFO] [stdout] 233 | | item: CrdtSequenceItem { [INFO] [stdout] 234 | | left_id, [INFO] [stdout] ... | [INFO] [stdout] 239 | | }, [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v6/block/blocks.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 221 | let value = if reader.has_subblock(6)? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let value = get_value(info, reader)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | Ok(SceneItemBlock { [INFO] [stdout] | ____________^ [INFO] [stdout] 232 | | parent_id, [INFO] [stdout] 233 | | item: CrdtSequenceItem { [INFO] [stdout] 234 | | left_id, [INFO] [stdout] ... | [INFO] [stdout] 239 | | }, [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `remarkable_lines` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `remarkable_lines` (lib) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cd5d3b088e20eea3fd55d1d6985d4b7fa1d78f3f1b54ba1cc50146b0e6cf626d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd5d3b088e20eea3fd55d1d6985d4b7fa1d78f3f1b54ba1cc50146b0e6cf626d", kill_on_drop: false }` [INFO] [stdout] cd5d3b088e20eea3fd55d1d6985d4b7fa1d78f3f1b54ba1cc50146b0e6cf626d