[INFO] fetching crate release-manager 0.1.4... [INFO] checking release-manager-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate release-manager 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate release-manager 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate release-manager 0.1.4 [INFO] finished tweaking crates.io crate release-manager 0.1.4 [INFO] tweaked toml for crates.io crate release-manager 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bzip2 v0.3.3 (latest: v0.4.4) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.4.3 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding podio v0.1.7 (latest: v0.2.0) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding structopt v0.1.7 (latest: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.1.6 (latest: v0.4.18) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zip v0.2.8 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2619ca1b3d3d56ceacc9a2d87e5df0e38d5b7a37ae1039f9d356f042a0f25b3 [INFO] running `Command { std: "docker" "start" "-a" "c2619ca1b3d3d56ceacc9a2d87e5df0e38d5b7a37ae1039f9d356f042a0f25b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2619ca1b3d3d56ceacc9a2d87e5df0e38d5b7a37ae1039f9d356f042a0f25b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2619ca1b3d3d56ceacc9a2d87e5df0e38d5b7a37ae1039f9d356f042a0f25b3", kill_on_drop: false }` [INFO] [stdout] c2619ca1b3d3d56ceacc9a2d87e5df0e38d5b7a37ae1039f9d356f042a0f25b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29d4d74dc1ea7f0c062de47029755e04c3a509af4145f69f8eca0693933e3fc6 [INFO] running `Command { std: "docker" "start" "-a" "29d4d74dc1ea7f0c062de47029755e04c3a509af4145f69f8eca0693933e3fc6", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking podio v0.1.7 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling structopt-derive v0.1.6 [INFO] [stderr] Checking structopt v0.1.7 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.2.8 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking release-manager v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `entry_and_modify` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | #![feature(entry_and_modify)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `try_from` has been stable since 1.34.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | #![feature(try_from)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `entry_and_modify` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | #![feature(entry_and_modify)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `try_from` has been stable since 1.34.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | #![feature(try_from)] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut f = File::open(filename)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(toml::from_str(&contents)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn table_str<'a>(table: &'a Value, name: &str, missing_err: Error) -> Result<&'a str, Error> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | table.get(name).ok_or(missing_err).and_then( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 149 | .and_then(|mut child| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | child.wait().map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 46 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / Self::Previous::new(filename) [INFO] [stdout] 48 | | .map(|(c, _)| { [INFO] [stdout] 49 | | debug!("Upgrading from older config version"); [INFO] [stdout] 50 | | (c.into(), ConfigState::Upgraded) [INFO] [stdout] 51 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 46 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .map_err(|_| e) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|(c, _)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | debug!("Upgrading from older config version"); [INFO] [stdout] 50 | (c.into(), ConfigState::Upgraded) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `release-manager` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut f = File::open(filename)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(toml::from_str(&contents)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn table_str<'a>(table: &'a Value, name: &str, missing_err: Error) -> Result<&'a str, Error> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | table.get(name).ok_or(missing_err).and_then( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 149 | .and_then(|mut child| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | child.wait().map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 46 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | / Self::Previous::new(filename) [INFO] [stdout] 48 | | .map(|(c, _)| { [INFO] [stdout] 49 | | debug!("Upgrading from older config version"); [INFO] [stdout] 50 | | (c.into(), ConfigState::Upgraded) [INFO] [stdout] 51 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 46 | .or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .map_err(|_| e) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:50:26 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|(c, _)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | debug!("Upgrading from older config version"); [INFO] [stdout] 50 | (c.into(), ConfigState::Upgraded) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `release-manager` (lib test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "29d4d74dc1ea7f0c062de47029755e04c3a509af4145f69f8eca0693933e3fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29d4d74dc1ea7f0c062de47029755e04c3a509af4145f69f8eca0693933e3fc6", kill_on_drop: false }` [INFO] [stdout] 29d4d74dc1ea7f0c062de47029755e04c3a509af4145f69f8eca0693933e3fc6