[INFO] fetching crate reis 0.2.0... [INFO] checking reis-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reis 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate reis 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reis 0.2.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate reis 0.2.0 [INFO] tweaked toml for crates.io crate reis 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate reis 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1773fdae4b31034d6940b831ba58993f53d65c49bcd4419f01636b1b4eebda98 [INFO] running `Command { std: "docker" "start" "-a" "1773fdae4b31034d6940b831ba58993f53d65c49bcd4419f01636b1b4eebda98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1773fdae4b31034d6940b831ba58993f53d65c49bcd4419f01636b1b4eebda98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1773fdae4b31034d6940b831ba58993f53d65c49bcd4419f01636b1b4eebda98", kill_on_drop: false }` [INFO] [stdout] 1773fdae4b31034d6940b831ba58993f53d65c49bcd4419f01636b1b4eebda98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55e365884d862fff13eb6fc172a2b55447c63e41e5592082cf21ac735413f31e [INFO] running `Command { std: "docker" "start" "-a" "55e365884d862fff13eb6fc172a2b55447c63e41e5592082cf21ac735413f31e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling indexmap v2.2.5 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.78 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking async-broadcast v0.7.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking xdg-home v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking memmap2 v0.8.0 [INFO] [stderr] Checking xkbcommon v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling zvariant_utils v1.1.0 [INFO] [stderr] Checking reis v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling zvariant_derive v4.0.2 [INFO] [stderr] Compiling zbus_macros v4.1.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/event.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | ei::Event::Pingpong(_ping_pong, event) => match event {}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `eiproto_ei::pingpong::Event` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/request.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | eis::Request::Callback(_callback, request) => match request {}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ matches no values because `eiproto_eis::callback::Request` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/util.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct LockFile(UnlinkOnDrop); [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `enum_name` is never used [INFO] [stdout] --> src/wire/arg.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) trait OwnedArg: Sized { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 81 | fn enum_name(&self) -> Option<(&'static str, &'static str)> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ei.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(socket: UnixStream) -> io::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(Self(Backend::new(socket, true)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ei.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | let socket = UnixStream::connect(path)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self::new(socket).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eis.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | fn bind_inner(path: PathBuf, lock: Option) -> io::Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let listener = UnixListener::bind(&path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | listener.set_nonblocking(true)?; [INFO] [stdout] 55 | let listener = util::UnlinkOnDrop::new(listener, path); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | listener, [INFO] [stdout] 58 | | _lock: lock, [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eis.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 99 | pub(crate) fn new(socket: UnixStream) -> io::Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Ok(Self(Backend::new(socket, false)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/event.rs:1014:24 [INFO] [stdout] | [INFO] [stdout] 1011 | pub fn new(context: ei::Context, serial: u32) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | converter: EiEventConverter::new(serial), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 169 | request: eis::Request, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | ) -> Result, HandshakeError> { [INFO] [stdout] 171 | let eis::Request::Handshake(handshake, request) = request else { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 43 | backend: BackendWeak, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Self(Arc::new(ObjectInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 50 | | backend, [INFO] [stdout] 51 | | id, [INFO] [stdout] 52 | | client_side, [INFO] [stdout] 53 | | interface, [INFO] [stdout] 54 | | version, [INFO] [stdout] 55 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 107 | let inner = fs::File::options() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let inner = UnlinkOnDrop::new(inner, path); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | Ok(Some(inner).filter(|_| locked).map(Self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reis` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "55e365884d862fff13eb6fc172a2b55447c63e41e5592082cf21ac735413f31e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55e365884d862fff13eb6fc172a2b55447c63e41e5592082cf21ac735413f31e", kill_on_drop: false }` [INFO] [stdout] 55e365884d862fff13eb6fc172a2b55447c63e41e5592082cf21ac735413f31e