[INFO] fetching crate reflect_tools 0.3.0... [INFO] checking reflect_tools-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reflect_tools 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate reflect_tools 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reflect_tools 0.3.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate reflect_tools 0.3.0 [INFO] tweaked toml for crates.io crate reflect_tools 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate reflect_tools 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a60d8888f7b419b0dc559e31ad65beae681400929b4f6e04edbf8456d9d6a41 [INFO] running `Command { std: "docker" "start" "-a" "0a60d8888f7b419b0dc559e31ad65beae681400929b4f6e04edbf8456d9d6a41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a60d8888f7b419b0dc559e31ad65beae681400929b4f6e04edbf8456d9d6a41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a60d8888f7b419b0dc559e31ad65beae681400929b4f6e04edbf8456d9d6a41", kill_on_drop: false }` [INFO] [stdout] 0a60d8888f7b419b0dc559e31ad65beae681400929b4f6e04edbf8456d9d6a41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa728ad7556216ed22bf85e052abee27fe20ff0ee447d2861739676c8050e249 [INFO] running `Command { std: "docker" "start" "-a" "aa728ad7556216ed22bf85e052abee27fe20ff0ee447d2861739676c8050e249", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling interval_adapter v0.16.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling interval_adapter v0.19.0 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Compiling derive_tools v0.19.0 [INFO] [stderr] Compiling derive_tools v0.21.0 [INFO] [stderr] Compiling collection_tools v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling clone_dyn_types v0.22.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling former_types v2.7.0 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling interval_adapter v0.23.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling inspect_type v0.10.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking shared_child v1.0.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling derive_tools v0.26.0 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling const_format_proc_macros v0.2.32 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling trybuild v1.0.89 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling iter_tools v0.13.0 [INFO] [stderr] Compiling iter_tools v0.16.0 [INFO] [stderr] Compiling iter_tools v0.20.0 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking error_tools v0.11.0 [INFO] [stderr] Compiling test_tools v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking literally v0.1.3 [INFO] [stderr] Checking for_each v0.8.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling const_format v0.2.32 [INFO] [stderr] Compiling reflect_tools v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking is_slice v0.9.0 [INFO] [stderr] Checking implements v0.8.0 [INFO] [stderr] Checking dissimilar v1.0.7 [INFO] [stderr] Checking typing_tools v0.8.0 [INFO] [stderr] Checking data_type v0.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking diagnostics_tools v0.8.0 [INFO] [stderr] Checking mem_tools v0.6.0 [INFO] [stderr] Checking basic-toml v0.1.9 [INFO] [stderr] Compiling macro_tools v0.21.0 [INFO] [stderr] Compiling macro_tools v0.24.0 [INFO] [stderr] Compiling macro_tools v0.38.0 [INFO] [stderr] Compiling derive_more-impl v1.0.0-beta.6 [INFO] [stderr] Compiling derive_tools_meta v0.16.0 [INFO] [stderr] Compiling derive_tools_meta v0.18.0 [INFO] [stderr] Compiling impls_index_meta v0.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling former_meta v0.12.0 [INFO] [stderr] Compiling derive_tools_meta v0.25.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Checking impls_index v0.7.0 [INFO] [stderr] Compiling reflect_tools_meta v0.3.0 [INFO] [stderr] Compiling variadic_from v0.14.0 [INFO] [stderr] Compiling variadic_from v0.12.0 [INFO] [stderr] Checking former v0.13.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_array.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 65 | let result : Vec< KeyVal > = ( 0 .. N ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Box::new( result.into_iter() ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_array.rs:66:63 [INFO] [stdout] | [INFO] [stdout] 66 | .map( | k | KeyVal { key : Primitive::usize( k ), val : Box::new( < T as Instance >::Reflect() ) } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_slice.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 63 | let result : Vec< KeyVal > = ( 0 .. self.len() ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Box::new( result.into_iter() ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_slice.rs:64:63 [INFO] [stdout] | [INFO] [stdout] 64 | .map( | k | KeyVal { key : Primitive::usize( k ), val : Box::new( < T as Instance >::Reflect() ) } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_vec.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 62 | let result : Vec< KeyVal > = ( 0 .. self.len() ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | Box::new( result.into_iter() ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_vec.rs:63:63 [INFO] [stdout] | [INFO] [stdout] 63 | .map( | k | KeyVal { key : Primitive::usize( k ), val : Box::new( < T as Instance >::Reflect() ) } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_hashmap.rs:26:72 [INFO] [stdout] | [INFO] [stdout] 26 | self.keys().into_iter().map( | k | primitive::Primitive::from( k.clone() ) ).collect::< Vec< _ > >(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_hashmap.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 69 | let mut result : Vec< KeyVal > = ( 0 .. self.len() ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Box::new( result.into_iter() ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_hashmap.rs:70:63 [INFO] [stdout] | [INFO] [stdout] 70 | .map( | k | KeyVal { key : Primitive::usize( k ), val : Box::new( < V as Instance >::Reflect() ) } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_hashset.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 63 | let result : Vec< KeyVal > = ( 0..self.len() ) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Box::new( result.into_iter() ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/entity_hashset.rs:64:63 [INFO] [stdout] | [INFO] [stdout] 64 | .map( | k | KeyVal { key : Primitive::usize( k ), val : Box::new( < T as Instance >::Reflect() ) } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/fields.rs:80:60 [INFO] [stdout] | [INFO] [stdout] 80 | self.iter().enumerate().map( | ( key, val ) | ( key, Some( Cow::Borrowed( val ) ) ) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/wrapper/maybe_as.rs:111:11 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn new( src : < T as std::borrow::ToOwned >::Owned ) -> Self [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | { [INFO] [stdout] 111 | Self( Some( Cow::Owned( src ) ), ::core::marker::PhantomData ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reflect/wrapper/maybe_as.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 244 | fn from( src : Cow< 'a, T > ) -> Self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | { [INFO] [stdout] 246 | MaybeAs::new_with_inner( Some( src ) ) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reflect_tools` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "aa728ad7556216ed22bf85e052abee27fe20ff0ee447d2861739676c8050e249", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa728ad7556216ed22bf85e052abee27fe20ff0ee447d2861739676c8050e249", kill_on_drop: false }` [INFO] [stdout] aa728ad7556216ed22bf85e052abee27fe20ff0ee447d2861739676c8050e249