[INFO] fetching crate refine 0.18.0... [INFO] checking refine-0.18.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate refine 0.18.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate refine 0.18.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate refine 0.18.0 [INFO] finished tweaking crates.io crate refine 0.18.0 [INFO] tweaked toml for crates.io crate refine 0.18.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate refine 0.18.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f91f9f0c97185cc6a22e73eaeeca1b33b0ed0c8e25deb6ca515d8407cec0b86 [INFO] running `Command { std: "docker" "start" "-a" "2f91f9f0c97185cc6a22e73eaeeca1b33b0ed0c8e25deb6ca515d8407cec0b86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f91f9f0c97185cc6a22e73eaeeca1b33b0ed0c8e25deb6ca515d8407cec0b86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f91f9f0c97185cc6a22e73eaeeca1b33b0ed0c8e25deb6ca515d8407cec0b86", kill_on_drop: false }` [INFO] [stdout] 2f91f9f0c97185cc6a22e73eaeeca1b33b0ed0c8e25deb6ca515d8407cec0b86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a0f55803da1e88017200fa95e8132d3935e6a4ae69c7b47aa5549429e5ac65b [INFO] running `Command { std: "docker" "start" "-a" "1a0f55803da1e88017200fa95e8132d3935e6a4ae69c7b47aa5549429e5ac65b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking human-repr v1.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking refine v0.18.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/dupes.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 64 | fn detect_duplicates(medias: &mut [Media], grouping: FG, show: FS) -> usize [INFO] [stdout] | ------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / medias [INFO] [stdout] 72 | | .chunk_by_mut(|m, m2| grouping(m) == grouping(m2)) [INFO] [stdout] 73 | | .filter(|_| utils::is_running()) [INFO] [stdout] 74 | | .filter(|g| g.len() > 1) [INFO] [stdout] ... | [INFO] [stdout] 87 | | show(grouping(g[0]), g) [INFO] [stdout] 88 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/dupes.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(words.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/rebuild.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | static RE: LazyLock = LazyLock::new(|| Regex::new(r"[\s_]+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entries.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn gen_medias(paths: impl Iterator, kind: EntryKind) -> Vec [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | / paths [INFO] [stdout] 69 | | .flat_map(|p| entries(p, rm)) [INFO] [stdout] 70 | | .map(|path| T::try_from(path)) [INFO] [stdout] 71 | | .inspect(|res| { [INFO] [stdout] ... | [INFO] [stdout] 75 | | }) [INFO] [stdout] 76 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | Ok((s[..pos].parse()?, s[pos + 1..].parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:37:52 [INFO] [stdout] | [INFO] [stdout] 37 | static REM: LazyLock = LazyLock::new(|| Regex::new(r" copy( \d+)?$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:38:52 [INFO] [stdout] | [INFO] [stdout] 38 | static REL: LazyLock = LazyLock::new(|| Regex::new(r"-\d+$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 124 | .try_fold(Vec::new(), |mut acc, de| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let is_dir = de.path().is_dir(); // need to cache is_dir because it goes ... [INFO] [stdout] 126 | copy_path(&de.path(), &q.join(de.file_name()), remove_dir, n + 1).map(|()| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/dupes.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 64 | fn detect_duplicates(medias: &mut [Media], grouping: FG, show: FS) -> usize [INFO] [stdout] | ------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | / medias [INFO] [stdout] 72 | | .chunk_by_mut(|m, m2| grouping(m) == grouping(m2)) [INFO] [stdout] 73 | | .filter(|_| utils::is_running()) [INFO] [stdout] 74 | | .filter(|g| g.len() > 1) [INFO] [stdout] ... | [INFO] [stdout] 87 | | show(grouping(g[0]), g) [INFO] [stdout] 88 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/dupes.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | Ok(words.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/rebuild.rs:84:59 [INFO] [stdout] | [INFO] [stdout] 84 | static RE: LazyLock = LazyLock::new(|| Regex::new(r"[\s_]+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entries.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn gen_medias(paths: impl Iterator, kind: EntryKind) -> Vec [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | / paths [INFO] [stdout] 69 | | .flat_map(|p| entries(p, rm)) [INFO] [stdout] 70 | | .map(|path| T::try_from(path)) [INFO] [stdout] 71 | | .inspect(|res| { [INFO] [stdout] ... | [INFO] [stdout] 75 | | }) [INFO] [stdout] 76 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:85:8 [INFO] [stdout] | [INFO] [stdout] 85 | Ok((s[..pos].parse()?, s[pos + 1..].parse()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:37:52 [INFO] [stdout] | [INFO] [stdout] 37 | static REM: LazyLock = LazyLock::new(|| Regex::new(r" copy( \d+)?$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:38:52 [INFO] [stdout] | [INFO] [stdout] 38 | static REL: LazyLock = LazyLock::new(|| Regex::new(r"-\d+$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/files.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 124 | .try_fold(Vec::new(), |mut acc, de| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let is_dir = de.path().is_dir(); // need to cache is_dir because it goes ... [INFO] [stdout] 126 | copy_path(&de.path(), &q.join(de.file_name()), remove_dir, n + 1).map(|()| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `refine` (bin "refine") due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `refine` (bin "refine" test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "1a0f55803da1e88017200fa95e8132d3935e6a4ae69c7b47aa5549429e5ac65b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a0f55803da1e88017200fa95e8132d3935e6a4ae69c7b47aa5549429e5ac65b", kill_on_drop: false }` [INFO] [stdout] 1a0f55803da1e88017200fa95e8132d3935e6a4ae69c7b47aa5549429e5ac65b