[INFO] fetching crate ref_thread_local 0.1.1... [INFO] checking ref_thread_local-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ref_thread_local 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ref_thread_local 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ref_thread_local 0.1.1 [INFO] finished tweaking crates.io crate ref_thread_local 0.1.1 [INFO] tweaked toml for crates.io crate ref_thread_local 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dce282f63ec0176ff428557fcf4bc65938265fe22a229ddde81495063d3a8649 [INFO] running `Command { std: "docker" "start" "-a" "dce282f63ec0176ff428557fcf4bc65938265fe22a229ddde81495063d3a8649", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dce282f63ec0176ff428557fcf4bc65938265fe22a229ddde81495063d3a8649", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dce282f63ec0176ff428557fcf4bc65938265fe22a229ddde81495063d3a8649", kill_on_drop: false }` [INFO] [stdout] dce282f63ec0176ff428557fcf4bc65938265fe22a229ddde81495063d3a8649 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72e92982589d591688603aabd0b79072e141080e17cefe95b34e136949a7f59a [INFO] running `Command { std: "docker" "start" "-a" "72e92982589d591688603aabd0b79072e141080e17cefe95b34e136949a7f59a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking ref_thread_local v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn map_split(orig: Ref<'a, T>, f: F) -> (Ref<'a, U>, Ref<'a, V>) [INFO] [stdout] | ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Ref { [INFO] [stdout] 208 | | borrow_count: borrow_count, [INFO] [stdout] 209 | | value: a, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn map_split(orig: Ref<'a, T>, f: F) -> (Ref<'a, U>, Ref<'a, V>) [INFO] [stdout] | ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | / Ref { [INFO] [stdout] 212 | | borrow_count: borrow_count, [INFO] [stdout] 213 | | value: b, [INFO] [stdout] 214 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn map_split(orig: RefMut<'a, T>, f: F) -> (RefMut<'a, U>, RefMut<'a, V>) [INFO] [stdout] | ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | / RefMut { [INFO] [stdout] 288 | | borrow_count: borrow_count, [INFO] [stdout] 289 | | value: a, [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn map_split(orig: RefMut<'a, T>, f: F) -> (RefMut<'a, U>, RefMut<'a, V>) [INFO] [stdout] | ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | / RefMut { [INFO] [stdout] 292 | | borrow_count: borrow_count, [INFO] [stdout] 293 | | value: b, [INFO] [stdout] 294 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn map_split(orig: Ref<'a, T>, f: F) -> (Ref<'a, U>, Ref<'a, V>) [INFO] [stdout] | ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | / Ref { [INFO] [stdout] 208 | | borrow_count: borrow_count, [INFO] [stdout] 209 | | value: a, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:211:13 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn map_split(orig: Ref<'a, T>, f: F) -> (Ref<'a, U>, Ref<'a, V>) [INFO] [stdout] | ---------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | / Ref { [INFO] [stdout] 212 | | borrow_count: borrow_count, [INFO] [stdout] 213 | | value: b, [INFO] [stdout] 214 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn map_split(orig: RefMut<'a, T>, f: F) -> (RefMut<'a, U>, RefMut<'a, V>) [INFO] [stdout] | ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | / RefMut { [INFO] [stdout] 288 | | borrow_count: borrow_count, [INFO] [stdout] 289 | | value: a, [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/refmanager.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 277 | pub fn map_split(orig: RefMut<'a, T>, f: F) -> (RefMut<'a, U>, RefMut<'a, V>) [INFO] [stdout] | ------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | / RefMut { [INFO] [stdout] 292 | | borrow_count: borrow_count, [INFO] [stdout] 293 | | value: b, [INFO] [stdout] 294 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/refmanager.rs:320:22 [INFO] [stdout] | [INFO] [stdout] 320 | unsafe { Box::from_raw(ptr_inner_data) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 320 | unsafe { let _ = Box::from_raw(ptr_inner_data); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/refmanager.rs:320:22 [INFO] [stdout] | [INFO] [stdout] 320 | unsafe { Box::from_raw(ptr_inner_data) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 320 | unsafe { let _ = Box::from_raw(ptr_inner_data); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ref_thread_local` (lib test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ref_thread_local` (lib) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "72e92982589d591688603aabd0b79072e141080e17cefe95b34e136949a7f59a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72e92982589d591688603aabd0b79072e141080e17cefe95b34e136949a7f59a", kill_on_drop: false }` [INFO] [stdout] 72e92982589d591688603aabd0b79072e141080e17cefe95b34e136949a7f59a