[INFO] fetching crate reefdb 0.1.0... [INFO] checking reefdb-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reefdb 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate reefdb 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reefdb 0.1.0 [INFO] finished tweaking crates.io crate reefdb 0.1.0 [INFO] tweaked toml for crates.io crate reefdb 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3e33b2a63ae4768b55c87ecdacd098cae1c94a72d3dba0ebeac23cc8d14be60 [INFO] running `Command { std: "docker" "start" "-a" "d3e33b2a63ae4768b55c87ecdacd098cae1c94a72d3dba0ebeac23cc8d14be60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3e33b2a63ae4768b55c87ecdacd098cae1c94a72d3dba0ebeac23cc8d14be60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3e33b2a63ae4768b55c87ecdacd098cae1c94a72d3dba0ebeac23cc8d14be60", kill_on_drop: false }` [INFO] [stdout] d3e33b2a63ae4768b55c87ecdacd098cae1c94a72d3dba0ebeac23cc8d14be60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4d537cabe3a7fd413990957babc4bb3cb723f88af7fb3a53be01dd837ac8fbd [INFO] running `Command { std: "docker" "start" "-a" "a4d537cabe3a7fd413990957babc4bb3cb723f88af7fb3a53be01dd837ac8fbd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking reefdb v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `IResult`, `character::complete::space1`, `sequence::delimited`, `tag_no_case`, `tag`, and `take_till` [INFO] [stdout] --> src/sql/clauses/wheres/fts.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | bytes::complete::{tag, tag_no_case, take_till}, [INFO] [stdout] | ^^^ ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] 3 | character::complete::space1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 4 | sequence::delimited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | IResult, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `data_value::DataValue` and `operators::op::Op` [INFO] [stdout] --> src/sql/clauses/wheres/fts.rs:8:34 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::sql::{column::Column, data_value::DataValue, operators::op::Op}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IResult`, `alphanumeric1`, `multispace1`, `sequence::delimited`, `space1`, `tag_no_case`, `tag`, and `take_till` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | bytes::complete::{tag, tag_no_case, take_till}, [INFO] [stdout] | ^^^ ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] 3 | character::complete::{alphanumeric1, multispace1, space1}, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] 4 | sequence::delimited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | IResult, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `column::Column`, `column_def::column_name`, and `operators::op::Op` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | column::Column, column_def::column_name, data_value::DataValue, operators::op::Op, [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::fts::FTSWhereClause` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use super::fts::FTSWhereClause; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fts::FTSWhereClause` [INFO] [stdout] --> src/sql/statements/select.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | wheres::{fts::FTSWhereClause, where_type::WhereType}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `space1` [INFO] [stdout] --> src/sql/statements/select.rs:11:68 [INFO] [stdout] | [INFO] [stdout] 11 | character::complete::{alphanumeric1, multispace0, multispace1, space1}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `InMemoryReefDB` and `data_value::DataValue` [INFO] [stdout] --> src/transaction.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | sql::{data_value::DataValue, statements::Statement}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | storage::Storage, [INFO] [stdout] 7 | InMemoryReefDB, ReefDB, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IResult`, `character::complete::space1`, `sequence::delimited`, `tag_no_case`, `tag`, and `take_till` [INFO] [stdout] --> src/sql/clauses/wheres/fts.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | bytes::complete::{tag, tag_no_case, take_till}, [INFO] [stdout] | ^^^ ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] 3 | character::complete::space1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 4 | sequence::delimited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | IResult, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `data_value::DataValue` and `operators::op::Op` [INFO] [stdout] --> src/sql/clauses/wheres/fts.rs:8:34 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::sql::{column::Column, data_value::DataValue, operators::op::Op}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `IResult`, `alphanumeric1`, `multispace1`, `sequence::delimited`, `space1`, `tag_no_case`, `tag`, and `take_till` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:2:23 [INFO] [stdout] | [INFO] [stdout] 2 | bytes::complete::{tag, tag_no_case, take_till}, [INFO] [stdout] | ^^^ ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] 3 | character::complete::{alphanumeric1, multispace1, space1}, [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ ^^^^^^ [INFO] [stdout] 4 | sequence::delimited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | IResult, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `column::Column`, `column_def::column_name`, and `operators::op::Op` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | column::Column, column_def::column_name, data_value::DataValue, operators::op::Op, [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::fts::FTSWhereClause` [INFO] [stdout] --> src/sql/clauses/wheres/where_clause.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use super::fts::FTSWhereClause; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fts::FTSWhereClause` [INFO] [stdout] --> src/sql/statements/select.rs:4:18 [INFO] [stdout] | [INFO] [stdout] 4 | wheres::{fts::FTSWhereClause, where_type::WhereType}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `space1` [INFO] [stdout] --> src/sql/statements/select.rs:11:68 [INFO] [stdout] | [INFO] [stdout] 11 | character::complete::{alphanumeric1, multispace0, multispace1, space1}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 52 | fn init(args: S::NewArgs, args2: FTS::NewArgs) -> Self { [INFO] [stdout] | ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ReefDB { [INFO] [stdout] 54 | tables: S::new(args), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 52 | fn init(args: S::NewArgs, args2: FTS::NewArgs) -> Self { [INFO] [stdout] | ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | inverted_index: FTS::new(args2), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/sql/statements/select.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | let (input, statement) = result.unwrap(); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexes/fts/disk.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 42 | let index = InvertedIndex::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let file_path = args; [INFO] [stdout] 44 | let on_disk_index = OnDiskInvertedIndex { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / on_disk_index [INFO] [stdout] 49 | | .load_from_file(&file_path) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reefdb` (lib) due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 52 | fn init(args: S::NewArgs, args2: FTS::NewArgs) -> Self { [INFO] [stdout] | ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | ReefDB { [INFO] [stdout] 54 | tables: S::new(args), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 52 | fn init(args: S::NewArgs, args2: FTS::NewArgs) -> Self { [INFO] [stdout] | ---------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | inverted_index: FTS::new(args2), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexes/fts/disk.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 42 | let index = InvertedIndex::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let file_path = args; [INFO] [stdout] 44 | let on_disk_index = OnDiskInvertedIndex { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | / on_disk_index [INFO] [stdout] 49 | | .load_from_file(&file_path) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transaction.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | db.execute_statement(create_stmt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 46 | let _ = db.execute_statement(create_stmt); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/transaction.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | db.execute_statement(insert_stmt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = db.execute_statement(insert_stmt); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reefdb` (lib test) due to 4 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a4d537cabe3a7fd413990957babc4bb3cb723f88af7fb3a53be01dd837ac8fbd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4d537cabe3a7fd413990957babc4bb3cb723f88af7fb3a53be01dd837ac8fbd", kill_on_drop: false }` [INFO] [stdout] a4d537cabe3a7fd413990957babc4bb3cb723f88af7fb3a53be01dd837ac8fbd