[INFO] fetching crate reductionml-core 0.1.0... [INFO] checking reductionml-core-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate reductionml-core 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate reductionml-core 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reductionml-core 0.1.0 [INFO] finished tweaking crates.io crate reductionml-core 0.1.0 [INFO] tweaked toml for crates.io crate reductionml-core 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding serde_default v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding serde_json_borrow v0.1.4 (latest: v0.6.0) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe6bebf071581ef987cb4c035165b0505d3a50e92bdddfb1aa112434d5372322 [INFO] running `Command { std: "docker" "start" "-a" "fe6bebf071581ef987cb4c035165b0505d3a50e92bdddfb1aa112434d5372322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe6bebf071581ef987cb4c035165b0505d3a50e92bdddfb1aa112434d5372322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe6bebf071581ef987cb4c035165b0505d3a50e92bdddfb1aa112434d5372322", kill_on_drop: false }` [INFO] [stdout] fe6bebf071581ef987cb4c035165b0505d3a50e92bdddfb1aa112434d5372322 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6094bcd35dcf914cdab8045b199b5300abb384d5666bbd50cdbc97a201fcaaaa [INFO] running `Command { std: "docker" "start" "-a" "6094bcd35dcf914cdab8045b199b5300abb384d5666bbd50cdbc97a201fcaaaa", kill_on_drop: false }` [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_default v0.1.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking flexbuffers v2.0.0 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking serde_json_borrow v0.1.4 [INFO] [stderr] Checking reductionml-core v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/reduction_registry.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{BTreeMap, HashMap}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/reduction_registry.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{BTreeMap, HashMap}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chunk` [INFO] [stdout] --> src/parsers/text_parser.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | chunk: &'a str, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_chunk` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `chunk` [INFO] [stdout] --> src/parsers/text_parser.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | chunk: &'a str, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_chunk` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:35:36 [INFO] [stdout] | [INFO] [stdout] 35 | .map_or(0, |x| x.all_features().count()) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | .map(|x| x.all_features().count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | .map_or(0, |x| x.all_features().count()) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|x| x.all_features().count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_pool.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn return_object(&self, t: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.objects.lock().push(t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/binary.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | impl_default_factory_functions!("Binary", BinaryReductionConfig); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/binary.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 66 | let regressor_config = crate::reduction_factory::parse_config(&config.regressor)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let regressor: ReductionWrapper = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 88 | | self.typename(), [INFO] [stdout] 89 | | Box::new(BinaryReduction { regressor }), [INFO] [stdout] 90 | | types, [INFO] [stdout] 91 | | num_models_above, [INFO] [stdout] 92 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_adf.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | impl_default_factory_functions!("CbAdf", CBAdfConfig); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_adf.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 92 | let regressor_config = crate::reduction_factory::parse_config(&config.regressor)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let regressor: ReductionWrapper = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | self.typename(), [INFO] [stdout] 115 | | Box::new(CBAdfReduction { [INFO] [stdout] 116 | | cb_type: config.cb_type, [INFO] [stdout] ... | [INFO] [stdout] 121 | | num_models_above, [INFO] [stdout] 122 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_explore_adf_greedy.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | impl_default_factory_functions!("CbExploreAdfGreedy", CBExploreAdfGreedyConfig); [INFO] [stdout] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_explore_adf_greedy.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 72 | let cb_adf_config = crate::reduction_factory::parse_config(&config.cb_adf)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let cb_adf: ReductionWrapper = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | self.typename(), [INFO] [stdout] 95 | | Box::new(CBExploreAdfGreedyReduction { [INFO] [stdout] 96 | | epsilon: config.epsilon, [INFO] [stdout] ... | [INFO] [stdout] 100 | | num_models_above, [INFO] [stdout] 101 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_explore_adf_squarecb.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | impl_default_factory_functions!("CbExploreAdfSquareCb", CBExploreAdfSquareCBConfig); [INFO] [stdout] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_explore_adf_squarecb.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 88 | let cb_adf_config = crate::reduction_factory::parse_config(&config.cb_adf)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let cb_adf: ReductionWrapper = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | self.typename(), [INFO] [stdout] 121 | | Box::new(CBExploreAdfSquareCBReduction { [INFO] [stdout] 122 | | config: config.clone(), [INFO] [stdout] ... | [INFO] [stdout] 127 | | num_models_above, [INFO] [stdout] 128 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/coin.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 86 | fn deserialize(deserializer: D) -> std::result::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | LossFunctionType::deserialize(deserializer).map(|x| LossFunctionHolder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/coin.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | loss_function: x.create(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/coin.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | impl_default_factory_functions!("Coin", CoinRegressorConfig); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/debug.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | impl_default_factory_functions!("Debug", DebugConfig); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/debug.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 86 | let next_config = crate::reduction_factory::parse_config(&config.next)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let next: ReductionWrapper = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | self.typename(), [INFO] [stdout] 110 | | Box::new(DebugReduction { [INFO] [stdout] 111 | | id: config.id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 119 | | num_models_above, [INFO] [stdout] 120 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 126 | let reduction_config = crate::reduction_factory::parse_config(&config.entry_reduction)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let entry_reduction = crate::reduction_factory::create_reduction( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Workspace { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | global_config: config.global_config, [INFO] [stdout] 135 | | entry_reduction, [INFO] [stdout] 136 | | features_pool: Arc::new(Pool::new()), [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | serde_json::from_value(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:35:36 [INFO] [stdout] | [INFO] [stdout] 35 | .map_or(0, |x| x.all_features().count()) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | .map(|x| x.all_features().count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:46:36 [INFO] [stdout] | [INFO] [stdout] 46 | .map_or(0, |x| x.all_features().count()) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics/parsed_features.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|x| x.all_features().count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/object_pool.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn return_object(&self, t: T) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.objects.lock().push(t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/binary.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | impl_default_factory_functions!("Binary", BinaryReductionConfig); [INFO] [stdout] | ---------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/binary.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 66 | let regressor_config = crate::reduction_factory::parse_config(&config.regressor)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let regressor: ReductionWrapper = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 88 | | self.typename(), [INFO] [stdout] 89 | | Box::new(BinaryReduction { regressor }), [INFO] [stdout] 90 | | types, [INFO] [stdout] 91 | | num_models_above, [INFO] [stdout] 92 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_adf.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | impl_default_factory_functions!("CbAdf", CBAdfConfig); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_adf.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 92 | let regressor_config = crate::reduction_factory::parse_config(&config.regressor)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let regressor: ReductionWrapper = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | self.typename(), [INFO] [stdout] 115 | | Box::new(CBAdfReduction { [INFO] [stdout] 116 | | cb_type: config.cb_type, [INFO] [stdout] ... | [INFO] [stdout] 121 | | num_models_above, [INFO] [stdout] 122 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_explore_adf_greedy.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | impl_default_factory_functions!("CbExploreAdfGreedy", CBExploreAdfGreedyConfig); [INFO] [stdout] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_explore_adf_greedy.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 72 | let cb_adf_config = crate::reduction_factory::parse_config(&config.cb_adf)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let cb_adf: ReductionWrapper = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | self.typename(), [INFO] [stdout] 95 | | Box::new(CBExploreAdfGreedyReduction { [INFO] [stdout] 96 | | epsilon: config.epsilon, [INFO] [stdout] ... | [INFO] [stdout] 100 | | num_models_above, [INFO] [stdout] 101 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/cb_explore_adf_squarecb.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | impl_default_factory_functions!("CbExploreAdfSquareCb", CBExploreAdfSquareCBConfig); [INFO] [stdout] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/cb_explore_adf_squarecb.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 88 | let cb_adf_config = crate::reduction_factory::parse_config(&config.cb_adf)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let cb_adf: ReductionWrapper = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | self.typename(), [INFO] [stdout] 121 | | Box::new(CBExploreAdfSquareCBReduction { [INFO] [stdout] 122 | | config: config.clone(), [INFO] [stdout] ... | [INFO] [stdout] 127 | | num_models_above, [INFO] [stdout] 128 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/coin.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 86 | fn deserialize(deserializer: D) -> std::result::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | LossFunctionType::deserialize(deserializer).map(|x| LossFunctionHolder { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/coin.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | loss_function: x.create(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/coin.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | impl_default_factory_functions!("Coin", CoinRegressorConfig); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reduction_factory.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(Box::new(res)) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reductions/debug.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | impl_default_factory_functions!("Debug", DebugConfig); [INFO] [stdout] | ----------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_default_factory_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reductions/debug.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 86 | let next_config = crate::reduction_factory::parse_config(&config.next)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let next: ReductionWrapper = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(ReductionWrapper::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | self.typename(), [INFO] [stdout] 110 | | Box::new(DebugReduction { [INFO] [stdout] 111 | | id: config.id.clone(), [INFO] [stdout] ... | [INFO] [stdout] 119 | | num_models_above, [INFO] [stdout] 120 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 126 | let reduction_config = crate::reduction_factory::parse_config(&config.entry_reduction)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let entry_reduction = crate::reduction_factory::create_reduction( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(Workspace { [INFO] [stdout] | ____________^ [INFO] [stdout] 134 | | global_config: config.global_config, [INFO] [stdout] 135 | | entry_reduction, [INFO] [stdout] 136 | | features_pool: Arc::new(Pool::new()), [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | serde_json::from_value(value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reductionml-core` (lib test) due to 21 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 20 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reductionml-core` (lib) due to 21 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6094bcd35dcf914cdab8045b199b5300abb384d5666bbd50cdbc97a201fcaaaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6094bcd35dcf914cdab8045b199b5300abb384d5666bbd50cdbc97a201fcaaaa", kill_on_drop: false }` [INFO] [stdout] 6094bcd35dcf914cdab8045b199b5300abb384d5666bbd50cdbc97a201fcaaaa