[INFO] fetching crate redseat-crypto 0.1.0... [INFO] checking redseat-crypto-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redseat-crypto 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate redseat-crypto 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redseat-crypto 0.1.0 [INFO] finished tweaking crates.io crate redseat-crypto 0.1.0 [INFO] tweaked toml for crates.io crate redseat-crypto 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4933339f19f49ab93ee56f07e9f58a148628a30370aa0d9ffb0cc90f37ac51ce [INFO] running `Command { std: "docker" "start" "-a" "4933339f19f49ab93ee56f07e9f58a148628a30370aa0d9ffb0cc90f37ac51ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4933339f19f49ab93ee56f07e9f58a148628a30370aa0d9ffb0cc90f37ac51ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4933339f19f49ab93ee56f07e9f58a148628a30370aa0d9ffb0cc90f37ac51ce", kill_on_drop: false }` [INFO] [stdout] 4933339f19f49ab93ee56f07e9f58a148628a30370aa0d9ffb0cc90f37ac51ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d6c0830b82cfefedea3fe6fac0e8d1e20e85a49ae29a0b5946cfb213b320f736 [INFO] running `Command { std: "docker" "start" "-a" "d6c0830b82cfefedea3fe6fac0e8d1e20e85a49ae29a0b5946cfb213b320f736", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking redseat-crypto v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `io::copy` [INFO] [stdout] --> src/lib.rs:580:40 [INFO] [stdout] | [INFO] [stdout] 580 | use std::{fs::{remove_file, File}, io::copy, path::PathBuf, str::FromStr}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 265 | pub fn new(iv: Vec, mut writer: W, enc: E) -> Result> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | writer.write_all(&iv)?; [INFO] [stdout] 267 | Ok(AesWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 268 | | writer: Some(writer), [INFO] [stdout] 269 | | enc: CbcEncryptor::new(enc, PkcsPadding, iv), [INFO] [stdout] 270 | | closed: false, [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 415 | pub fn new(mut reader: R, dec: D) -> Result> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | Ok(AesReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | reader: reader, [INFO] [stdout] 420 | | block_size: dec.block_size(), [INFO] [stdout] 421 | | dec: CbcDecryptor::new(dec, PkcsPadding, iv), [INFO] [stdout] 422 | | buffer: Vec::new(), [INFO] [stdout] 423 | | eof: false, [INFO] [stdout] 424 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:442:12 [INFO] [stdout] | [INFO] [stdout] 428 | pub fn new_with_infos(mut reader: R, dec: D) -> Result<(CryptoInfo, AesReader)> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 432 | let mut aes_reader = AesReader { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | Ok((infos, aes_reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redseat-crypto` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:267:12 [INFO] [stdout] | [INFO] [stdout] 265 | pub fn new(iv: Vec, mut writer: W, enc: E) -> Result> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | writer.write_all(&iv)?; [INFO] [stdout] 267 | Ok(AesWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 268 | | writer: Some(writer), [INFO] [stdout] 269 | | enc: CbcEncryptor::new(enc, PkcsPadding, iv), [INFO] [stdout] 270 | | closed: false, [INFO] [stdout] 271 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 415 | pub fn new(mut reader: R, dec: D) -> Result> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | Ok(AesReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | reader: reader, [INFO] [stdout] 420 | | block_size: dec.block_size(), [INFO] [stdout] 421 | | dec: CbcDecryptor::new(dec, PkcsPadding, iv), [INFO] [stdout] 422 | | buffer: Vec::new(), [INFO] [stdout] 423 | | eof: false, [INFO] [stdout] 424 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:442:12 [INFO] [stdout] | [INFO] [stdout] 428 | pub fn new_with_infos(mut reader: R, dec: D) -> Result<(CryptoInfo, AesReader)> { [INFO] [stdout] | ------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 432 | let mut aes_reader = AesReader { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | Ok((infos, aes_reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redseat-crypto` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d6c0830b82cfefedea3fe6fac0e8d1e20e85a49ae29a0b5946cfb213b320f736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6c0830b82cfefedea3fe6fac0e8d1e20e85a49ae29a0b5946cfb213b320f736", kill_on_drop: false }` [INFO] [stdout] d6c0830b82cfefedea3fe6fac0e8d1e20e85a49ae29a0b5946cfb213b320f736