[INFO] fetching crate redisearch_api 0.5.0... [INFO] checking redisearch_api-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redisearch_api 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate redisearch_api 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redisearch_api 0.5.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate redisearch_api 0.5.0 [INFO] tweaked toml for crates.io crate redisearch_api 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate redisearch_api 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 317912eda560bfcab591274cebb9c8f8b2b3e660b5b6b5a773675e85d99f14a4 [INFO] running `Command { std: "docker" "start" "-a" "317912eda560bfcab591274cebb9c8f8b2b3e660b5b6b5a773675e85d99f14a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "317912eda560bfcab591274cebb9c8f8b2b3e660b5b6b5a773675e85d99f14a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "317912eda560bfcab591274cebb9c8f8b2b3e660b5b6b5a773675e85d99f14a4", kill_on_drop: false }` [INFO] [stdout] 317912eda560bfcab591274cebb9c8f8b2b3e660b5b6b5a773675e85d99f14a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 720278c51b31c6951fa3dcd58e11ea5b6ed53cdfe8eaab3282dba74a129d1aa4 [INFO] running `Command { std: "docker" "start" "-a" "720278c51b31c6951fa3dcd58e11ea5b6ed53cdfe8eaab3282dba74a129d1aa4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling cc v1.0.61 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling regex-syntax v0.6.19 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling termcolor v1.1.0 [INFO] [stderr] Compiling bindgen v0.54.0 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling syn v1.0.44 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling aho-corasick v0.7.14 [INFO] [stderr] Compiling clang-sys v0.29.3 [INFO] [stderr] Compiling cmake v0.1.44 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling regex v1.4.0 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling enum-primitive-derive v0.1.2 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling env_logger v0.7.1 [INFO] [stderr] Compiling strum_macros v0.19.4 [INFO] [stderr] Compiling redis-module v0.11.0 [INFO] [stderr] Compiling redisearch_api v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `index` and `field_id` are never read [INFO] [stdout] --> src/index.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Field<'a> { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | index: &'a Index, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | field_id: RSFieldID, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/index.rs:106:44 [INFO] [stdout] | [INFO] [stdout] 106 | CString::new(key).unwrap().as_ptr() as *const c_void, [INFO] [stdout] | -------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 119 | let c_query = CString::new(query_string).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(ResultsIterator::from_raw(results_iter, self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `index` and `field_id` are never read [INFO] [stdout] --> src/index.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Field<'a> { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | index: &'a Index, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | field_id: RSFieldID, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redisearch_api` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/index.rs:106:44 [INFO] [stdout] | [INFO] [stdout] 106 | CString::new(key).unwrap().as_ptr() as *const c_void, [INFO] [stdout] | -------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/index.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 119 | let c_query = CString::new(query_string).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(ResultsIterator::from_raw(results_iter, self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/redisearch_api-ce83de9edac714b4/out/bindings.rs:5:3011 [INFO] [stdout] | [INFO] [stdout] 5 | ...eq ! (unsafe { & (* (:: std :: ptr :: null :: < RSIdxOptions > ())) . gvcb as * const _ as usize } , 0usize , concat ! ("Offset of fie... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deref_nullptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/redisearch_api-ce83de9edac714b4/out/bindings.rs:5:3219 [INFO] [stdout] | [INFO] [stdout] 5 | ...eq ! (unsafe { & (* (:: std :: ptr :: null :: < RSIdxOptions > ())) . gvcbData as * const _ as usize } , 8usize , concat ! ("Offset of... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/redisearch_api-ce83de9edac714b4/out/bindings.rs:5:3435 [INFO] [stdout] | [INFO] [stdout] 5 | ...eq ! (unsafe { & (* (:: std :: ptr :: null :: < RSIdxOptions > ())) . flags as * const _ as usize } , 16usize , concat ! ("Offset of f... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a null pointer [INFO] [stdout] --> /opt/rustwide/target/debug/build/redisearch_api-ce83de9edac714b4/out/bindings.rs:5:3646 [INFO] [stdout] | [INFO] [stdout] 5 | ...eq ! (unsafe { & (* (:: std :: ptr :: null :: < RSIdxOptions > ())) . gcPolicy as * const _ as usize } , 20usize , concat ! ("Offset o... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this code causes undefined behavior when executed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redisearch_api` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "720278c51b31c6951fa3dcd58e11ea5b6ed53cdfe8eaab3282dba74a129d1aa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "720278c51b31c6951fa3dcd58e11ea5b6ed53cdfe8eaab3282dba74a129d1aa4", kill_on_drop: false }` [INFO] [stdout] 720278c51b31c6951fa3dcd58e11ea5b6ed53cdfe8eaab3282dba74a129d1aa4