[INFO] fetching crate redis_utils 0.1.3... [INFO] checking redis_utils-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redis_utils 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate redis_utils 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redis_utils 0.1.3 [INFO] finished tweaking crates.io crate redis_utils 0.1.3 [INFO] tweaked toml for crates.io crate redis_utils 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding redis v0.21.7 (latest: v0.26.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4298aead8c6d00ef0242613b37f68dbb3d6591e11a5b08a7f5bf22235069d562 [INFO] running `Command { std: "docker" "start" "-a" "4298aead8c6d00ef0242613b37f68dbb3d6591e11a5b08a7f5bf22235069d562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4298aead8c6d00ef0242613b37f68dbb3d6591e11a5b08a7f5bf22235069d562", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4298aead8c6d00ef0242613b37f68dbb3d6591e11a5b08a7f5bf22235069d562", kill_on_drop: false }` [INFO] [stdout] 4298aead8c6d00ef0242613b37f68dbb3d6591e11a5b08a7f5bf22235069d562 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76828c9349783def6b5e098c3f485c04fcde24c7d8c828bdc0614a47d2768c65 [INFO] running `Command { std: "docker" "start" "-a" "76828c9349783def6b5e098c3f485c04fcde24c7d8c828bdc0614a47d2768c65", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking redis v0.21.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking redis_utils v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/converters.rs:129:1 [INFO] [stdout] | [INFO] [stdout] 129 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/converters.rs:178:39 [INFO] [stdout] | [INFO] [stdout] 178 | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/converters.rs:129:1 [INFO] [stdout] | [INFO] [stdout] 129 | #[async_trait] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/converters.rs:178:39 [INFO] [stdout] | [INFO] [stdout] 178 | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:65:35 [INFO] [stdout] | [INFO] [stdout] 63 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | val: Val, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result<(), JsonSetError> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 66 | | Ok(self.set(key, serde_json::to_string(&val)?).await?) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 138 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 140 | | let val: String = self.get(key).await?; [INFO] [stdout] 141 | | Ok(serde_json::from_str(&val)?) [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 147 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ) -> Result, JsonGetError> { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 149 | | let val: Option = self.get(key).await?; [INFO] [stdout] 150 | | match val { [INFO] [stdout] 151 | | Some(string) => Ok(Some(serde_json::from_str(&string)?)), [INFO] [stdout] 152 | | None => Ok(None), [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:160:41 [INFO] [stdout] | [INFO] [stdout] 159 | keys: Key, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 161 | | if keys.is_single_arg() { [INFO] [stdout] 162 | | Ok(self.maybe_json_get(keys).await?.into_iter().collect()) [INFO] [stdout] 163 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:177:41 [INFO] [stdout] | [INFO] [stdout] 176 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 178 | | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] 179 | | Ok(self.json_mget(key).await?) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:65:35 [INFO] [stdout] | [INFO] [stdout] 63 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | val: Val, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result<(), JsonSetError> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 66 | | Ok(self.set(key, serde_json::to_string(&val)?).await?) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 138 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 140 | | let val: String = self.get(key).await?; [INFO] [stdout] 141 | | Ok(serde_json::from_str(&val)?) [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis_utils` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 147 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ) -> Result, JsonGetError> { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 149 | | let val: Option = self.get(key).await?; [INFO] [stdout] 150 | | match val { [INFO] [stdout] 151 | | Some(string) => Ok(Some(serde_json::from_str(&string)?)), [INFO] [stdout] 152 | | None => Ok(None), [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:160:41 [INFO] [stdout] | [INFO] [stdout] 159 | keys: Key, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 161 | | if keys.is_single_arg() { [INFO] [stdout] 162 | | Ok(self.maybe_json_get(keys).await?.into_iter().collect()) [INFO] [stdout] 163 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:177:41 [INFO] [stdout] | [INFO] [stdout] 176 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 178 | | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] 179 | | Ok(self.json_mget(key).await?) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis_utils` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "76828c9349783def6b5e098c3f485c04fcde24c7d8c828bdc0614a47d2768c65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76828c9349783def6b5e098c3f485c04fcde24c7d8c828bdc0614a47d2768c65", kill_on_drop: false }` [INFO] [stdout] 76828c9349783def6b5e098c3f485c04fcde24c7d8c828bdc0614a47d2768c65