[INFO] fetching crate redis-zset-ts 0.2.0... [INFO] checking redis-zset-ts-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redis-zset-ts 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate redis-zset-ts 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redis-zset-ts 0.2.0 [INFO] finished tweaking crates.io crate redis-zset-ts 0.2.0 [INFO] tweaked toml for crates.io crate redis-zset-ts 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding redis v0.24.0 (latest: v0.26.1) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aedfd3706d4e5479a3556096ce74859175d32bb93cc93a409143f436862b03d [INFO] running `Command { std: "docker" "start" "-a" "6aedfd3706d4e5479a3556096ce74859175d32bb93cc93a409143f436862b03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aedfd3706d4e5479a3556096ce74859175d32bb93cc93a409143f436862b03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aedfd3706d4e5479a3556096ce74859175d32bb93cc93a409143f436862b03d", kill_on_drop: false }` [INFO] [stdout] 6aedfd3706d4e5479a3556096ce74859175d32bb93cc93a409143f436862b03d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2111be879688161ae1108e1d37b561414e56a34e276878dd4ee7b6945e772282 [INFO] running `Command { std: "docker" "start" "-a" "2111be879688161ae1108e1d37b561414e56a34e276878dd4ee7b6945e772282", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking redis v0.24.0 [INFO] [stderr] Checking redis-zset-ts v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | / pub fn purge_before(&mut self, ts: S) -> Result<()> [INFO] [stdout] 273 | | where [INFO] [stdout] 274 | | S: Into, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:277:19 [INFO] [stdout] | [INFO] [stdout] 277 | self.conn.zrembyscore(&self.key, "-inf", ts)?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | / pub fn purge_before(&mut self, ts: S) -> Result<()> [INFO] [stdout] 273 | | where [INFO] [stdout] 274 | | S: Into, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:277:19 [INFO] [stdout] | [INFO] [stdout] 277 | self.conn.zrembyscore(&self.key, "-inf", ts)?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn delete(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | self.conn.del(&self.key)?; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 299 | / pub fn add(&mut self, ts: S, val: T) -> Result<()> [INFO] [stdout] 300 | | where [INFO] [stdout] 301 | | S: Into, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:305:19 [INFO] [stdout] | [INFO] [stdout] 305 | self.conn.zadd(&self.key, rval, ts.0)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | pub fn add_multiple(&mut self, vals: &[TimeValue]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:335:19 [INFO] [stdout] | [INFO] [stdout] 335 | self.conn.zadd_multiple(&self.key, &rvals)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn delete(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | self.conn.del(&self.key)?; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 299 | / pub fn add(&mut self, ts: S, val: T) -> Result<()> [INFO] [stdout] 300 | | where [INFO] [stdout] 301 | | S: Into, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:305:19 [INFO] [stdout] | [INFO] [stdout] 305 | self.conn.zadd(&self.key, rval, ts.0)?; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | pub fn add_multiple_values(&mut self, vals: &[(Timestamp, T)]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 346 | self.conn.zadd_multiple(&self.key, &rvals)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | pub fn add_multiple(&mut self, vals: &[TimeValue]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:335:19 [INFO] [stdout] | [INFO] [stdout] 335 | self.conn.zadd_multiple(&self.key, &rvals)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/time_series.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | pub fn add_multiple_values(&mut self, vals: &[(Timestamp, T)]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/time_series.rs:346:19 [INFO] [stdout] | [INFO] [stdout] 346 | self.conn.zadd_multiple(&self.key, &rvals)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 261 | let conn = cli.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 263 | | key, [INFO] [stdout] 264 | | cli, [INFO] [stdout] 265 | | conn, [INFO] [stdout] 266 | | phantom: PhantomData, [INFO] [stdout] 267 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:343:35 [INFO] [stdout] | [INFO] [stdout] 343 | .map(|(ts, v)| (ts.0, rmps::encode::to_vec_named(&(ts.0, v)).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:364:24 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|buf| rmps::decode::from_slice(buf).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-zset-ts` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 261 | let conn = cli.get_connection()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 263 | | key, [INFO] [stdout] 264 | | cli, [INFO] [stdout] 265 | | conn, [INFO] [stdout] 266 | | phantom: PhantomData, [INFO] [stdout] 267 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:343:35 [INFO] [stdout] | [INFO] [stdout] 343 | .map(|(ts, v)| (ts.0, rmps::encode::to_vec_named(&(ts.0, v)).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time_series.rs:364:24 [INFO] [stdout] | [INFO] [stdout] 364 | .map(|buf| rmps::decode::from_slice(buf).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-zset-ts` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2111be879688161ae1108e1d37b561414e56a34e276878dd4ee7b6945e772282", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2111be879688161ae1108e1d37b561414e56a34e276878dd4ee7b6945e772282", kill_on_drop: false }` [INFO] [stdout] 2111be879688161ae1108e1d37b561414e56a34e276878dd4ee7b6945e772282