[INFO] fetching crate redis-args-impl 0.16.0... [INFO] checking redis-args-impl-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redis-args-impl 0.16.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate redis-args-impl 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redis-args-impl 0.16.0 [INFO] finished tweaking crates.io crate redis-args-impl 0.16.0 [INFO] tweaked toml for crates.io crate redis-args-impl 0.16.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94ef0378ac3964d81e2d48e452e55fce87d54578e4eb50beba7ca91a1c86dba3 [INFO] running `Command { std: "docker" "start" "-a" "94ef0378ac3964d81e2d48e452e55fce87d54578e4eb50beba7ca91a1c86dba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94ef0378ac3964d81e2d48e452e55fce87d54578e4eb50beba7ca91a1c86dba3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94ef0378ac3964d81e2d48e452e55fce87d54578e4eb50beba7ca91a1c86dba3", kill_on_drop: false }` [INFO] [stdout] 94ef0378ac3964d81e2d48e452e55fce87d54578e4eb50beba7ca91a1c86dba3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0df38b8111aa3545609b9b56d25eb9dded89c7fa016a5cf83c83cca5cf752ac [INFO] running `Command { std: "docker" "start" "-a" "c0df38b8111aa3545609b9b56d25eb9dded89c7fa016a5cf83c83cca5cf752ac", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking darling_core v0.20.10 [INFO] [stderr] Checking redis v0.26.1 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling redis-args-impl v0.16.0 [INFO] [stderr] Checking redis-args-impl v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_redis_value.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) fn from_redis_value(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let ast = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | --- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | match try_from_redis_value(ast) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_redis_value.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 45 | let expanded = quote! { [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | | impl #generics ::redis_args::__exports::redis::FromRedisValue for #ident #generics { [INFO] [stdout] 47 | | fn from_redis_value(v: &::redis_args::__exports::redis::Value) -> ::redis_args::__exports::redis::RedisResult { [INFO] [stdout] 48 | | match *v { [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | | Ok(TokenStream::from(expanded)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_redis_value.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 70 | let expanded = quote! { [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | | impl #generics ::redis_args::__exports::redis::FromRedisValue for #ident #generics { [INFO] [stdout] 72 | | fn from_redis_value(v: &::redis_args::__exports::redis::Value) -> ::redis_args::__exports::redis::RedisResult { [INFO] [stdout] 73 | | match *v { [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | | Ok(TokenStream::from(expanded)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_redis_args.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn to_redis_args(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let ast = syn::parse_macro_input!(input as syn::DeriveInput); [INFO] [stdout] | --- -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | match try_to_redis_args(ast) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_redis_args.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 105 | let expanded = quote! { [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | | impl #generics ::redis_args::__exports::redis::ToRedisArgs for #ident #generics { [INFO] [stdout] 107 | | fn write_redis_args(&self, out: &mut W) [INFO] [stdout] 108 | | where [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | | Ok(TokenStream::from(expanded)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/to_redis_args.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 123 | let expanded = quote! { [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | | impl #generics ::redis_args::__exports::redis::ToRedisArgs for #ident #generics { [INFO] [stdout] 125 | | fn write_redis_args(&self, out: &mut W) [INFO] [stdout] 126 | | where [INFO] [stdout] ... | [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | | Ok(TokenStream::from(expanded)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-args-impl` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c0df38b8111aa3545609b9b56d25eb9dded89c7fa016a5cf83c83cca5cf752ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0df38b8111aa3545609b9b56d25eb9dded89c7fa016a5cf83c83cca5cf752ac", kill_on_drop: false }` [INFO] [stdout] c0df38b8111aa3545609b9b56d25eb9dded89c7fa016a5cf83c83cca5cf752ac