[INFO] fetching crate redcon 0.1.2... [INFO] checking redcon-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate redcon 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate redcon 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redcon 0.1.2 [INFO] finished tweaking crates.io crate redcon 0.1.2 [INFO] tweaked toml for crates.io crate redcon 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc409109c5155121194589df6323606ac3992090549577fbeb0a0dcbab4c2186 [INFO] running `Command { std: "docker" "start" "-a" "dc409109c5155121194589df6323606ac3992090549577fbeb0a0dcbab4c2186", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc409109c5155121194589df6323606ac3992090549577fbeb0a0dcbab4c2186", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc409109c5155121194589df6323606ac3992090549577fbeb0a0dcbab4c2186", kill_on_drop: false }` [INFO] [stdout] dc409109c5155121194589df6323606ac3992090549577fbeb0a0dcbab4c2186 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b8513d71e85071b74aaf64eb00f2533a5862d288b3439903ae6fdbca451ad27 [INFO] running `Command { std: "docker" "start" "-a" "3b8513d71e85071b74aaf64eb00f2533a5862d288b3439903ae6fdbca451ad27", kill_on_drop: false }` [INFO] [stderr] Checking redcon v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | drop(s); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Server` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 437 - drop(s); [INFO] [stdout] 437 + let _ = s; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/lib.rs:437:5 [INFO] [stdout] | [INFO] [stdout] 437 | drop(s); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Server` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 437 - drop(s); [INFO] [stdout] 437 + let _ = s; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test.rs:21:31 [INFO] [stdout] | [INFO] [stdout] 21 | thread::spawn(move || test_conn(i, ADDR).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redcon` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3b8513d71e85071b74aaf64eb00f2533a5862d288b3439903ae6fdbca451ad27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b8513d71e85071b74aaf64eb00f2533a5862d288b3439903ae6fdbca451ad27", kill_on_drop: false }` [INFO] [stdout] 3b8513d71e85071b74aaf64eb00f2533a5862d288b3439903ae6fdbca451ad27