[INFO] fetching crate recv-dir 0.3.1... [INFO] checking recv-dir-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate recv-dir 0.3.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate recv-dir 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate recv-dir 0.3.1 [INFO] finished tweaking crates.io crate recv-dir 0.3.1 [INFO] tweaked toml for crates.io crate recv-dir 0.3.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99ee7df1bca784494f2a9be2d81ad0928a18e3df0dbbd8cf6488d3375b91118f [INFO] running `Command { std: "docker" "start" "-a" "99ee7df1bca784494f2a9be2d81ad0928a18e3df0dbbd8cf6488d3375b91118f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99ee7df1bca784494f2a9be2d81ad0928a18e3df0dbbd8cf6488d3375b91118f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99ee7df1bca784494f2a9be2d81ad0928a18e3df0dbbd8cf6488d3375b91118f", kill_on_drop: false }` [INFO] [stdout] 99ee7df1bca784494f2a9be2d81ad0928a18e3df0dbbd8cf6488d3375b91118f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c338149eeb07c159b613a427e5104390bd6327b6a59827762a7d72f70a66f7d5 [INFO] running `Command { std: "docker" "start" "-a" "c338149eeb07c159b613a427e5104390bd6327b6a59827762a7d72f70a66f7d5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking recv-dir v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn from_root(path: impl AsRef) -> std::io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let base_dir = path.as_ref().to_path_buf(); [INFO] [stdout] 170 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | [INFO] [stdout] 172 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | base_dir, [INFO] [stdout] 174 | | current_iter: Some(r), [INFO] [stdout] 175 | | dirs: vec![], [INFO] [stdout] 176 | | visit_filter: Accept, [INFO] [stdout] 177 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn from_root_no_symlinks(path: impl AsRef) -> std::io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let base_dir = path.as_ref().to_path_buf(); [INFO] [stdout] 204 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | [INFO] [stdout] 206 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 207 | | base_dir, [INFO] [stdout] 208 | | current_iter: Some(r), [INFO] [stdout] 209 | | dirs: vec![], [INFO] [stdout] 210 | | visit_filter: NoSymlink, [INFO] [stdout] 211 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 235 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | [INFO] [stdout] 241 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | base_dir, [INFO] [stdout] 243 | | current_iter: Some(r), [INFO] [stdout] 244 | | dirs: vec![], [INFO] [stdout] 245 | | visit_filter: MaxDepth(max_depth), [INFO] [stdout] 246 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn from_root_single_depth(path: impl AsRef) -> std::io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let base_dir = path.as_ref().to_path_buf(); [INFO] [stdout] 253 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | [INFO] [stdout] 255 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 256 | | base_dir, [INFO] [stdout] 257 | | current_iter: Some(r), [INFO] [stdout] 258 | | dirs: vec![], [INFO] [stdout] 259 | | visit_filter: MaxDepth::single_depth(), [INFO] [stdout] 260 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn with_closure_filter(path: impl AsRef, filter: F) -> std::io::Result [INFO] [stdout] | ---------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | [INFO] [stdout] 306 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | base_dir, [INFO] [stdout] 308 | | current_iter: Some(r), [INFO] [stdout] 309 | | dirs: vec![], [INFO] [stdout] 310 | | visit_filter: filter.into(), [INFO] [stdout] 311 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 335 | pub fn with_filter(path: impl AsRef, filter: F) -> std::io::Result [INFO] [stdout] | ---------------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | [INFO] [stdout] 342 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 343 | | base_dir, [INFO] [stdout] 344 | | current_iter: Some(r), [INFO] [stdout] 345 | | dirs: vec![], [INFO] [stdout] 346 | | visit_filter: This::new(filter), [INFO] [stdout] 347 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:378:12 [INFO] [stdout] | [INFO] [stdout] 374 | pub fn with_extension(path: impl AsRef, extension: S) -> std::io::Result { [INFO] [stdout] | ---------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | let base_dir = path.as_ref().to_path_buf(); [INFO] [stdout] 376 | let r = read_dir(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | [INFO] [stdout] 378 | Ok(RecursiveDirIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 379 | | base_dir, [INFO] [stdout] 380 | | current_iter: Some(r), [INFO] [stdout] 381 | | dirs: vec![], [INFO] [stdout] 382 | | visit_filter: Extension::new(extension), [INFO] [stdout] 383 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recv-dir` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c338149eeb07c159b613a427e5104390bd6327b6a59827762a7d72f70a66f7d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c338149eeb07c159b613a427e5104390bd6327b6a59827762a7d72f70a66f7d5", kill_on_drop: false }` [INFO] [stdout] c338149eeb07c159b613a427e5104390bd6327b6a59827762a7d72f70a66f7d5