[INFO] fetching crate recurse 0.3.0... [INFO] checking recurse-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate recurse 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate recurse 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate recurse 0.3.0 [INFO] finished tweaking crates.io crate recurse 0.3.0 [INFO] tweaked toml for crates.io crate recurse 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate recurse 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3eab966a43a9eaf5da6d45855a426ec738e0464eceb21a8aa12cbe9deb3aba86 [INFO] running `Command { std: "docker" "start" "-a" "3eab966a43a9eaf5da6d45855a426ec738e0464eceb21a8aa12cbe9deb3aba86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3eab966a43a9eaf5da6d45855a426ec738e0464eceb21a8aa12cbe9deb3aba86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3eab966a43a9eaf5da6d45855a426ec738e0464eceb21a8aa12cbe9deb3aba86", kill_on_drop: false }` [INFO] [stdout] 3eab966a43a9eaf5da6d45855a426ec738e0464eceb21a8aa12cbe9deb3aba86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c25cffaff40a198156396b2a2fc5f92c25644998ec2c787c9505c0f4822d57fa [INFO] running `Command { std: "docker" "start" "-a" "c25cffaff40a198156396b2a2fc5f92c25644998ec2c787c9505c0f4822d57fa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.13 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling syn v1.0.22 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling anyhow v1.0.31 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking float-cmp v0.6.0 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking predicates v1.0.4 [INFO] [stderr] Checking assert_cmd v1.0.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking recurse v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `OpenOptions` and `read_to_string` [INFO] [stdout] --> src/command/replace.rs:1:15 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::{read_to_string, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufWriter` and `ErrorKind` [INFO] [stdout] --> src/command/replace.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufWriter, ErrorKind, Write}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/command/replace.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex::Regex` [INFO] [stdout] --> src/command/replace.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use regex::Regex; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::ops::io::walk` [INFO] [stdout] --> src/command/replace.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ops::io::walk; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `path_has_extension` and `path_is_hidden` [INFO] [stdout] --> src/command/replace.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ops::path::{path_has_extension, path_is_hidden}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `OpenOptions` and `read_to_string` [INFO] [stdout] --> src/command/replace.rs:1:15 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::{read_to_string, OpenOptions}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufWriter` and `ErrorKind` [INFO] [stdout] --> src/command/replace.rs:2:15 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::{BufWriter, ErrorKind, Write}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/command/replace.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{anyhow, Result}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `regex::Regex` [INFO] [stdout] --> src/command/replace.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use regex::Regex; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::ops::io::walk` [INFO] [stdout] --> src/command/replace.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::ops::io::walk; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `path_has_extension` and `path_is_hidden` [INFO] [stdout] --> src/command/replace.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | use crate::ops::path::{path_has_extension, path_is_hidden}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `subcmd` [INFO] [stdout] --> src/command/replace.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_subcmd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `writer` [INFO] [stdout] --> src/command/replace.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_writer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/replace.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/lib.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 126 | Replace { [INFO] [stdout] | ------- fields in this variant [INFO] [stdout] ... [INFO] [stdout] 129 | extension: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | hidden: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 138 | nobu: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | mindepth: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | maxdepth: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 151 | symlinks: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 155 | find: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | replace: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 163 | inpath: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recurse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `BACKUP_FILEPATH_EXTENSION` is never used [INFO] [stdout] --> src/command/replace.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const BACKUP_FILEPATH_EXTENSION: &str = "bu"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_backup_filepath` is never used [INFO] [stdout] --> src/command/replace.rs:139:4 [INFO] [stdout] | [INFO] [stdout] 139 | fn get_backup_filepath(inpath: &Path) -> PathBuf { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `has_backup_extension` is never used [INFO] [stdout] --> src/command/replace.rs:151:4 [INFO] [stdout] | [INFO] [stdout] 151 | fn has_backup_extension(inpath: &Path) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_root_filepath` is never used [INFO] [stdout] --> src/command/replace.rs:158:4 [INFO] [stdout] | [INFO] [stdout] 158 | fn is_root_filepath(inpath: &Path) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/path.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) fn get_absolute_filepath

(filepath: P) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | match filepath.as_ref().canonicalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/path.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn path_is_hidden

(filepath: P) -> bool [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match get_absolute_filepath(filepath) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `subcmd` [INFO] [stdout] --> src/command/replace.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_subcmd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `writer` [INFO] [stdout] --> src/command/replace.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_writer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/replace.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | fn execute(subcmd: Recurse, mut writer: impl Write) -> Result<()> { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recurse` (lib) due to 3 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/lib.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 126 | Replace { [INFO] [stdout] | ------- fields in this variant [INFO] [stdout] ... [INFO] [stdout] 129 | extension: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | hidden: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 138 | nobu: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | mindepth: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 146 | maxdepth: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 151 | symlinks: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 155 | find: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 159 | replace: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 163 | inpath: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Recurse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/path.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) fn get_absolute_filepath

(filepath: P) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | match filepath.as_ref().canonicalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/path.rs:51:11 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn path_is_hidden

(filepath: P) -> bool [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match get_absolute_filepath(filepath) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recurse` (lib test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c25cffaff40a198156396b2a2fc5f92c25644998ec2c787c9505c0f4822d57fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c25cffaff40a198156396b2a2fc5f92c25644998ec2c787c9505c0f4822d57fa", kill_on_drop: false }` [INFO] [stdout] c25cffaff40a198156396b2a2fc5f92c25644998ec2c787c9505c0f4822d57fa