[INFO] fetching crate rectangle-pack 0.4.2... [INFO] checking rectangle-pack-0.4.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rectangle-pack 0.4.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rectangle-pack 0.4.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rectangle-pack 0.4.2 [INFO] finished tweaking crates.io crate rectangle-pack 0.4.2 [INFO] tweaked toml for crates.io crate rectangle-pack 0.4.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2414ae03e20439dddf603cf4381827f63fdd056c027c6bc8b3fb9180909e0bd0 [INFO] running `Command { std: "docker" "start" "-a" "2414ae03e20439dddf603cf4381827f63fdd056c027c6bc8b3fb9180909e0bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2414ae03e20439dddf603cf4381827f63fdd056c027c6bc8b3fb9180909e0bd0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2414ae03e20439dddf603cf4381827f63fdd056c027c6bc8b3fb9180909e0bd0", kill_on_drop: false }` [INFO] [stdout] 2414ae03e20439dddf603cf4381827f63fdd056c027c6bc8b3fb9180909e0bd0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0baaa8cb69d7be20a485c6a56d0428cc548ae4ed3b7bf5f60b3c7c577b5b03ca [INFO] running `Command { std: "docker" "start" "-a" "0baaa8cb69d7be20a485c6a56d0428cc548ae4ed3b7bf5f60b3c7c577b5b03ca", kill_on_drop: false }` [INFO] [stderr] Checking rectangle-pack v0.4.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(not(std), no_std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(not(std))] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:289:7 [INFO] [stdout] | [INFO] [stdout] 289 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/grouped_rects_to_place.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(not(std))] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/grouped_rects_to_place.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #![cfg_attr(not(std), no_std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg(not(std))] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/lib.rs:289:7 [INFO] [stdout] | [INFO] [stdout] 289 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/grouped_rects_to_place.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(not(std))] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `std` [INFO] [stdout] --> src/grouped_rects_to_place.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg(std)] [INFO] [stdout] | ^^^ help: found config with similar value: `feature = "std"` [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(std)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(std)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 142 | let mut packed_locations = KeyValMap::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(RectanglePackOk { packed_locations }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rectangle-pack` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 142 | let mut packed_locations = KeyValMap::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | Ok(RectanglePackOk { packed_locations }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rectangle-pack` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0baaa8cb69d7be20a485c6a56d0428cc548ae4ed3b7bf5f60b3c7c577b5b03ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0baaa8cb69d7be20a485c6a56d0428cc548ae4ed3b7bf5f60b3c7c577b5b03ca", kill_on_drop: false }` [INFO] [stdout] 0baaa8cb69d7be20a485c6a56d0428cc548ae4ed3b7bf5f60b3c7c577b5b03ca