[INFO] fetching crate recordkeeper 0.2.0-alpha... [INFO] checking recordkeeper-0.2.0-alpha against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate recordkeeper 0.2.0-alpha into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate recordkeeper 0.2.0-alpha on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate recordkeeper 0.2.0-alpha [INFO] finished tweaking crates.io crate recordkeeper 0.2.0-alpha [INFO] tweaked toml for crates.io crate recordkeeper 0.2.0-alpha written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6792a9525b89c583fc5cf1dcbd94b57bff9df9c63a210aede0649c87209f824d [INFO] running `Command { std: "docker" "start" "-a" "6792a9525b89c583fc5cf1dcbd94b57bff9df9c63a210aede0649c87209f824d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6792a9525b89c583fc5cf1dcbd94b57bff9df9c63a210aede0649c87209f824d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6792a9525b89c583fc5cf1dcbd94b57bff9df9c63a210aede0649c87209f824d", kill_on_drop: false }` [INFO] [stdout] 6792a9525b89c583fc5cf1dcbd94b57bff9df9c63a210aede0649c87209f824d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7dd0431e285501d6db82ba6c70d65b9d8a09683213ad4a575ce10b017b2b39cf [INFO] running `Command { std: "docker" "start" "-a" "7dd0431e285501d6db82ba6c70d65b9d8a09683213ad4a575ce10b017b2b39cf", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling recordkeeper-macros v0.1.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking recordkeeper v0.2.0-alpha (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/io.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CRAFTED_ITEM_ID` [INFO] [stdout] --> src/save/item/edit.rs:2:45 [INFO] [stdout] | [INFO] [stdout] 2 | dlc::{AccessoryCrafting, CraftItemData, CRAFTED_ITEM_ID}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/io.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `CRAFTED_ITEM_ID` [INFO] [stdout] --> src/save/item/edit.rs:2:45 [INFO] [stdout] | [INFO] [stdout] 2 | dlc::{AccessoryCrafting, CraftItemData, CRAFTED_ITEM_ID}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Cursor` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::Cursor; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Favorite` and `New` are never constructed [INFO] [stdout] --> src/save/item/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 49 | enum SlotFlags { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 53 | Favorite = 1 << 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 54 | /// The small circle icon for "unchecked" items [INFO] [stdout] 55 | New = 1 << 2, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 29 | let mut save: Box> = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let save = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | save, [INFO] [stdout] 62 | | bytes: Box::from(bytes), [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recordkeeper` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variants `Favorite` and `New` are never constructed [INFO] [stdout] --> src/save/item/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 49 | enum SlotFlags { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 53 | Favorite = 1 << 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 54 | /// The small circle icon for "unchecked" items [INFO] [stdout] 55 | New = 1 << 2, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 29 | let mut save: Box> = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let save = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | save, [INFO] [stdout] 62 | | bytes: Box::from(bytes), [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `recordkeeper` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7dd0431e285501d6db82ba6c70d65b9d8a09683213ad4a575ce10b017b2b39cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dd0431e285501d6db82ba6c70d65b9d8a09683213ad4a575ce10b017b2b39cf", kill_on_drop: false }` [INFO] [stdout] 7dd0431e285501d6db82ba6c70d65b9d8a09683213ad4a575ce10b017b2b39cf