[INFO] fetching crate readfish-tools 0.1.0... [INFO] checking readfish-tools-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate readfish-tools 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate readfish-tools 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate readfish-tools 0.1.0 [INFO] finished tweaking crates.io crate readfish-tools 0.1.0 [INFO] tweaked toml for crates.io crate readfish-tools 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 125 packages to latest compatible versions [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding itertools v0.11.0 (latest: v0.13.0) [INFO] [stderr] Adding libdeflate-sys v0.12.0 (latest: v1.21.0) [INFO] [stderr] Adding libdeflater v0.12.0 (latest: v1.21.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding pyo3 v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 27395299de72bc8fba4409475fa4ada4374b8a7778ab0c41f78a57459648057a [INFO] running `Command { std: "docker" "start" "-a" "27395299de72bc8fba4409475fa4ada4374b8a7778ab0c41f78a57459648057a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "27395299de72bc8fba4409475fa4ada4374b8a7778ab0c41f78a57459648057a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27395299de72bc8fba4409475fa4ada4374b8a7778ab0c41f78a57459648057a", kill_on_drop: false }` [INFO] [stdout] 27395299de72bc8fba4409475fa4ada4374b8a7778ab0c41f78a57459648057a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6713744a22060c94dfcb859844d6a2f787c186080976bed5a772f6ff92c06729 [INFO] running `Command { std: "docker" "start" "-a" "6713744a22060c94dfcb859844d6a2f787c186080976bed5a772f6ff92c06729", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling pyo3-build-config v0.19.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling libdeflate-sys v0.12.0 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling pyo3-macros-backend v0.19.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling pyo3-ffi v0.19.2 [INFO] [stderr] Compiling pyo3 v0.19.2 [INFO] [stderr] Checking libdeflater v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pyo3-macros v0.19.2 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking gzp v0.11.3 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking readfish-tools v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:858:44 [INFO] [stdout] | [INFO] [stdout] 858 | sequencing_summary_path.map(|path| sequencing_summary::SeqSum::from_file(path).unwrap()); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf.rs:242:21 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn new(paf_file: impl AsRef) -> Paf { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | reader: open_paf_for_reading(paf_file).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readfish_io.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 152 | fn new(inner: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | GzSeekable { [INFO] [stdout] 154 | inner: BufReader::new(GzDecoder::new(inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequencing_summary.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn from_file(sequencing_summary_path: impl AsRef) -> DynResult { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let reader = reader(&sequencing_summary_path, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut reader = ByteCounter::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let mut lines: Lines<&mut ByteCounter>> = reader.by_ref().lines(); [INFO] [stdout] 160 | let headers = lines.next(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let processed_lines = LinkedHashMap::from_iter(lines_iter.map(|line| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(SeqSum { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | sequencing_summary_path, [INFO] [stdout] 230 | | // writers, [INFO] [stdout] 231 | | record_buffer: processed_lines, [INFO] [stdout] ... | [INFO] [stdout] 239 | | previous_read_id: String::new(), [INFO] [stdout] 240 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `readfish-tools` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:858:44 [INFO] [stdout] | [INFO] [stdout] 858 | sequencing_summary_path.map(|path| sequencing_summary::SeqSum::from_file(path).unwrap()); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paf.rs:242:21 [INFO] [stdout] | [INFO] [stdout] 239 | pub fn new(paf_file: impl AsRef) -> Paf { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | reader: open_paf_for_reading(paf_file).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readfish_io.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 152 | fn new(inner: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | GzSeekable { [INFO] [stdout] 154 | inner: BufReader::new(GzDecoder::new(inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequencing_summary.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn from_file(sequencing_summary_path: impl AsRef) -> DynResult { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | let reader = reader(&sequencing_summary_path, None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut reader = ByteCounter::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let mut lines: Lines<&mut ByteCounter>> = reader.by_ref().lines(); [INFO] [stdout] 160 | let headers = lines.next(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let processed_lines = LinkedHashMap::from_iter(lines_iter.map(|line| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(SeqSum { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | sequencing_summary_path, [INFO] [stdout] 230 | | // writers, [INFO] [stdout] 231 | | record_buffer: processed_lines, [INFO] [stdout] ... | [INFO] [stdout] 239 | | previous_read_id: String::new(), [INFO] [stdout] 240 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `readfish-tools` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "6713744a22060c94dfcb859844d6a2f787c186080976bed5a772f6ff92c06729", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6713744a22060c94dfcb859844d6a2f787c186080976bed5a772f6ff92c06729", kill_on_drop: false }` [INFO] [stdout] 6713744a22060c94dfcb859844d6a2f787c186080976bed5a772f6ff92c06729