[INFO] fetching crate re_smart_channel 0.18.2... [INFO] checking re_smart_channel-0.18.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate re_smart_channel 0.18.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate re_smart_channel 0.18.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate re_smart_channel 0.18.2 [INFO] finished tweaking crates.io crate re_smart_channel 0.18.2 [INFO] tweaked toml for crates.io crate re_smart_channel 0.18.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding web-time v0.2.4 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4819ae37dcde95aaa7fdb8ba53cbbcb6f790b83321649f7f26d5675e2855c2a8 [INFO] running `Command { std: "docker" "start" "-a" "4819ae37dcde95aaa7fdb8ba53cbbcb6f790b83321649f7f26d5675e2855c2a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4819ae37dcde95aaa7fdb8ba53cbbcb6f790b83321649f7f26d5675e2855c2a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4819ae37dcde95aaa7fdb8ba53cbbcb6f790b83321649f7f26d5675e2855c2a8", kill_on_drop: false }` [INFO] [stdout] 4819ae37dcde95aaa7fdb8ba53cbbcb6f790b83321649f7f26d5675e2855c2a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a61a892259831c763d563d80032de17c2b0871efa1aa7a0b8d66b1dd7b28d3b3 [INFO] running `Command { std: "docker" "start" "-a" "a61a892259831c763d563d80032de17c2b0871efa1aa7a0b8d66b1dd7b28d3b3", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking puffin v0.19.1 [INFO] [stderr] Checking re_tracing v0.18.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking re_smart_channel v0.18.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:180:45 [INFO] [stdout] | [INFO] [stdout] 179 | let stats = Arc::new(SharedStats::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | smart_channel_with_stats(sender_source, Arc::new(source), stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive_set.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(receivers: Vec>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | receivers: Mutex::new(receivers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive_set.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | re_tracing::profile_function!(); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.sources() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn send(&self, msg: T) -> Result<(), SendError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | / self.send_at( [INFO] [stdout] 34 | | Instant::now(), [INFO] [stdout] 35 | | Arc::clone(&self.source), [INFO] [stdout] 36 | | SmartMessagePayload::Msg(msg), [INFO] [stdout] 37 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 48 | source: Arc, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | payload: SmartMessagePayload, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / self.tx [INFO] [stdout] 55 | | .send(SmartMessage { [INFO] [stdout] 56 | | time, [INFO] [stdout] 57 | | source, [INFO] [stdout] 58 | | payload, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 95 | err: Option>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | self.tx.send(SmartMessage { [INFO] [stdout] | ______________________^ [INFO] [stdout] 101 | | time: Instant::now(), [INFO] [stdout] 102 | | source: Arc::clone(&self.source), [INFO] [stdout] 103 | | payload: SmartMessagePayload::Quit(err), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_smart_channel` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:180:45 [INFO] [stdout] | [INFO] [stdout] 179 | let stats = Arc::new(SharedStats::default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | smart_channel_with_stats(sender_source, Arc::new(source), stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive_set.rs:24:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(receivers: Vec>) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self { [INFO] [stdout] 24 | receivers: Mutex::new(receivers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/receive_set.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 80 | re_tracing::profile_function!(); [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.sources() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn send(&self, msg: T) -> Result<(), SendError> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | / self.send_at( [INFO] [stdout] 34 | | Instant::now(), [INFO] [stdout] 35 | | Arc::clone(&self.source), [INFO] [stdout] 36 | | SmartMessagePayload::Msg(msg), [INFO] [stdout] 37 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 48 | source: Arc, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | payload: SmartMessagePayload, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / self.tx [INFO] [stdout] 55 | | .send(SmartMessage { [INFO] [stdout] 56 | | time, [INFO] [stdout] 57 | | source, [INFO] [stdout] 58 | | payload, [INFO] [stdout] 59 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sender.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 95 | err: Option>, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | self.tx.send(SmartMessage { [INFO] [stdout] | ______________________^ [INFO] [stdout] 101 | | time: Instant::now(), [INFO] [stdout] 102 | | source: Arc::clone(&self.source), [INFO] [stdout] 103 | | payload: SmartMessagePayload::Quit(err), [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_smart_channel` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a61a892259831c763d563d80032de17c2b0871efa1aa7a0b8d66b1dd7b28d3b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a61a892259831c763d563d80032de17c2b0871efa1aa7a0b8d66b1dd7b28d3b3", kill_on_drop: false }` [INFO] [stdout] a61a892259831c763d563d80032de17c2b0871efa1aa7a0b8d66b1dd7b28d3b3