[INFO] fetching crate re_sdk 0.18.2... [INFO] checking re_sdk-0.18.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate re_sdk 0.18.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate re_sdk 0.18.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate re_sdk 0.18.2 [INFO] finished tweaking crates.io crate re_sdk 0.18.2 [INFO] tweaked toml for crates.io crate re_sdk 0.18.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 374 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ashpd v0.6.8 (latest: v0.9.1) [INFO] [stderr] Adding async-broadcast v0.5.1 (latest: v0.7.1) [INFO] [stderr] Adding async-fs v1.6.0 (latest: v2.1.2) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.14.2 (latest: v0.18.1) [INFO] [stderr] Adding cfb v0.7.3 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding crossterm v0.27.0 (latest: v0.28.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding fixed v1.27.0 (latest: v1.28.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (latest: v24.3.25) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding infer v0.15.0 (latest: v0.16.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding js-sys v0.3.69 (latest: v0.3.70) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding ndarray-rand v0.14.0 (latest: v0.15.0) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding peg v0.6.3 (latest: v0.8.4) [INFO] [stderr] Adding peg-macros v0.6.3 (latest: v0.8.4) [INFO] [stderr] Adding peg-runtime v0.6.3 (latest: v0.8.3) [INFO] [stderr] Adding planus v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding raw-window-handle v0.5.2 (latest: v0.6.2) [INFO] [stderr] Adding rfd v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sysinfo v0.30.13 (latest: v0.31.4) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding tungstenite v0.20.1 (latest: v0.24.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasm-bindgen v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-backend v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-futures v0.4.42 (latest: v0.4.43) [INFO] [stderr] Adding wasm-bindgen-macro v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro-support v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-shared v0.2.92 (latest: v0.2.93) [INFO] [stderr] Adding web-sys v0.3.69 (latest: v0.3.70) [INFO] [stderr] Adding web-time v0.2.4 (latest: v1.1.0) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.45.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] [stderr] Adding zbus v3.15.2 (latest: v4.4.0) [INFO] [stderr] Adding zbus_macros v3.15.2 (latest: v4.4.0) [INFO] [stderr] Adding zbus_names v2.6.1 (latest: v3.0.0) [INFO] [stderr] Adding zvariant v3.15.2 (latest: v4.2.0) [INFO] [stderr] Adding zvariant_derive v3.15.2 (latest: v4.2.0) [INFO] [stderr] Adding zvariant_utils v1.0.1 (latest: v2.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f36d04d186d6932797f04ca43827f777f2022b0914e0e6a7e634c9fdeba59b1 [INFO] running `Command { std: "docker" "start" "-a" "7f36d04d186d6932797f04ca43827f777f2022b0914e0e6a7e634c9fdeba59b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f36d04d186d6932797f04ca43827f777f2022b0914e0e6a7e634c9fdeba59b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f36d04d186d6932797f04ca43827f777f2022b0914e0e6a7e634c9fdeba59b1", kill_on_drop: false }` [INFO] [stdout] 7f36d04d186d6932797f04ca43827f777f2022b0914e0e6a7e634c9fdeba59b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 966ec2783017e593869febb3253167e86e32c40a2fc2351be738cb789a212931 [INFO] running `Command { std: "docker" "start" "-a" "966ec2783017e593869febb3253167e86e32c40a2fc2351be738cb789a212931", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Checking array-init-cursor v0.2.0 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking hash_hasher v2.0.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking re_case v0.18.2 [INFO] [stderr] Checking log-once v0.4.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking re_error v0.18.2 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling fixed v1.27.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking re_log v0.18.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking puffin v0.19.1 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Checking clean-path v0.2.1 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking re_tracing v0.18.2 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling unindent v0.2.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking re_format v0.18.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking memory-stats v1.2.0 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking indent v0.1.1 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking re_memory v0.18.2 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stderr] Checking arrow-format v0.8.1 [INFO] [stderr] Checking re_string_interner v0.18.2 [INFO] [stderr] Checking re_tuid v0.18.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking re_build_info v0.18.2 [INFO] [stderr] Checking re_smart_channel v0.18.2 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Compiling cargo-platform v0.1.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling re_arrow2 v0.17.5 [INFO] [stderr] Compiling cargo_metadata v0.18.1 [INFO] [stderr] Compiling re_build_tools v0.18.2 [INFO] [stderr] Compiling re_sdk v0.18.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking re_types_core v0.18.2 [INFO] [stderr] Checking re_format_arrow v0.18.2 [INFO] [stderr] Checking re_log_types v0.18.2 [INFO] [stderr] Checking re_chunk v0.18.2 [INFO] [stderr] Checking re_log_encoding v0.18.2 [INFO] [stderr] Checking re_chunk_store v0.18.2 [INFO] [stderr] Checking re_sdk_comms v0.18.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 180 | application_id: impl Into, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | store_id: StoreId::random(StoreKind::Recording), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:22 [INFO] [stdout] | [INFO] [stdout] 180 | application_id: impl Into, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | cloned_from: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 30 | let (tx, rx) = std::sync::mpsc::sync_channel(0); // oneshot [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | (Self::Flush(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:64:20 [INFO] [stdout] | [INFO] [stdout] 62 | fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self { [INFO] [stdout] 64 | inner: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn new(rec: RecordingStream) -> Result<(Self, BinaryStreamStorage), BinaryStreamSinkError> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let storage = BinaryStreamStorage::new(rec); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let encoder = re_log_encoding::encoder::Encoder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let join_handle = spawn_and_stream(encoder, rx)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | Self { [INFO] [stdout] 146 | | tx: tx.into(), [INFO] [stdout] 147 | | join_handle: Some(join_handle), [INFO] [stdout] 148 | | }, [INFO] [stdout] 149 | | storage, [INFO] [stdout] 150 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 170 | mut encoder: re_log_encoding::encoder::Encoder, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | rx: Receiver>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | ) -> Result, BinaryStreamSinkError> { [INFO] [stdout] 173 | / std::thread::Builder::new() [INFO] [stdout] 174 | | .name("binary_stream_encoder".into()) [INFO] [stdout] 175 | | .spawn({ [INFO] [stdout] 176 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:218:80 [INFO] [stdout] | [INFO] [stdout] 218 | RecordingScope::ThreadLocal => LOCAL_DATA_RECORDING.with(|rec| rec.borrow().get()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:226:58 [INFO] [stdout] | [INFO] [stdout] 226 | LOCAL_BLUEPRINT_RECORDING.with(|rec| rec.borrow().get()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:240:54 [INFO] [stdout] | [INFO] [stdout] 232 | fn set_any(scope: RecordingScope, kind: StoreKind, rec: Option) -> Option { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | LOCAL_DATA_RECORDING.with(|cell| cell.borrow_mut().replace(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:251:59 [INFO] [stdout] | [INFO] [stdout] 232 | fn set_any(scope: RecordingScope, kind: StoreKind, rec: Option) -> Option { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | LOCAL_BLUEPRINT_RECORDING.with(|cell| cell.borrow_mut().replace(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:139:14 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Self(MemorySinkStorage::new(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 211 | fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Self { [INFO] [stdout] 213 | inner: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:282:31 [INFO] [stdout] | [INFO] [stdout] 279 | let mut inner = self.inner.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | encode_as_bytes_local(std::mem::take(&mut inner.msgs).into_iter().map(Ok)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:309:23 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn new(callback: F) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:141:23 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(application_id: impl Into) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | store_id: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(application_id: impl Into) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | batcher_config: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 278 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | ) -> RecordingStreamResult<(RecordingStream, crate::log_sink::MemorySinkStorage)> { [INFO] [stdout] 280 | let (enabled, store_info, batcher_config) = self.into_args(); [INFO] [stdout] | ---------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let rec = if enabled { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let sink = crate::log_sink::MemorySink::new(rec.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let storage = sink.buffer(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | Ok((rec, storage)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:563:52 [INFO] [stdout] | [INFO] [stdout] 563 | batcher_config.unwrap_or_else(|| match ChunkBatcherConfig::from_env() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:767:12 [INFO] [stdout] | [INFO] [stdout] 728 | info: StoreInfo, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 729 | batcher_config: ChunkBatcherConfig, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | sink: Box, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | ) -> RecordingStreamResult { [INFO] [stdout] 732 | let on_release = batcher_config.hooks.on_release.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 733 | let batcher = ChunkBatcher::new(batcher_config)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | let (cmds_tx, cmds_rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 751 | [INFO] [stdout] 752 | let batcher_to_sink_handle = { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let info = info.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | let batcher = batcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 767 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 768 | | info, [INFO] [stdout] 769 | | tick: AtomicI64::new(0), [INFO] [stdout] 770 | | cmds_tx, [INFO] [stdout] ... | [INFO] [stdout] 774 | | pid_at_creation: std::process::id(), [INFO] [stdout] 775 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:759:68 [INFO] [stdout] | [INFO] [stdout] 730 | sink: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | ) -> RecordingStreamResult { [INFO] [stdout] 732 | let on_release = batcher_config.hooks.on_release.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | let (cmds_tx, cmds_rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let info = info.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | let batcher = batcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | move || forwarding_thread(info, sink, cmds_rx, batcher.chunks(), on_release) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:807:10 [INFO] [stdout] | [INFO] [stdout] 806 | let (tx, rx) = crossbeam::channel::bounded(0); // oneshot [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 807 | (Self::Flush(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:836:9 [INFO] [stdout] | [INFO] [stdout] 824 | info: StoreInfo, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 825 | batcher_config: ChunkBatcherConfig, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 826 | sink: Box, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 827 | ) -> RecordingStreamResult { [INFO] [stdout] 828 | let sink = (info.store_id.kind == StoreKind::Recording) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | RecordingStreamInner::new(info, batcher_config, sink).map(|inner| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:837:20 [INFO] [stdout] | [INFO] [stdout] 836 | RecordingStreamInner::new(info, batcher_config, sink).map(|inner| Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 837 | inner: Either::Left(Arc::new(Some(inner))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:943:20 [INFO] [stdout] | [INFO] [stdout] 925 | let array = batch.to_arrow()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 931 | let data_type = ArrowListArray::::default_datatype(array.data_type().clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 932 | [INFO] [stdout] 933 | let array = ArrowListArray::::try_new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | Ok((batch.name(), array)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:1043:13 [INFO] [stdout] | [INFO] [stdout] 1034 | ent_path: impl Into, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1043 | arch.as_component_batches() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:1945:26 [INFO] [stdout] | [INFO] [stdout] 1939 | fn with(f: impl FnOnce(&mut Self) -> R) -> R { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1945 | THREAD_INFO.with(|thread_info| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1946 | | let mut thread_info = thread_info.borrow_mut(); [INFO] [stdout] 1947 | | let thread_info = thread_info.get_or_insert_with(Self::default); [INFO] [stdout] 1948 | | f(thread_info) [INFO] [stdout] 1949 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_sdk` (lib) due to 27 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 180 | application_id: impl Into, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | store_id: StoreId::random(StoreKind::Recording), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:22 [INFO] [stdout] | [INFO] [stdout] 180 | application_id: impl Into, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | cloned_from: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 30 | let (tx, rx) = std::sync::mpsc::sync_channel(0); // oneshot [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | (Self::Flush(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:64:20 [INFO] [stdout] | [INFO] [stdout] 62 | fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self { [INFO] [stdout] 64 | inner: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn new(rec: RecordingStream) -> Result<(Self, BinaryStreamStorage), BinaryStreamSinkError> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let storage = BinaryStreamStorage::new(rec); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | [INFO] [stdout] 136 | let encoder = re_log_encoding::encoder::Encoder::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let join_handle = spawn_and_stream(encoder, rx)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | Self { [INFO] [stdout] 146 | | tx: tx.into(), [INFO] [stdout] 147 | | join_handle: Some(join_handle), [INFO] [stdout] 148 | | }, [INFO] [stdout] 149 | | storage, [INFO] [stdout] 150 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_stream_sink.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 170 | mut encoder: re_log_encoding::encoder::Encoder, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | rx: Receiver>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | ) -> Result, BinaryStreamSinkError> { [INFO] [stdout] 173 | / std::thread::Builder::new() [INFO] [stdout] 174 | | .name("binary_stream_encoder".into()) [INFO] [stdout] 175 | | .spawn({ [INFO] [stdout] 176 | | move || { [INFO] [stdout] ... | [INFO] [stdout] 200 | | } [INFO] [stdout] 201 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:218:80 [INFO] [stdout] | [INFO] [stdout] 218 | RecordingScope::ThreadLocal => LOCAL_DATA_RECORDING.with(|rec| rec.borrow().get()), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:226:58 [INFO] [stdout] | [INFO] [stdout] 226 | LOCAL_BLUEPRINT_RECORDING.with(|rec| rec.borrow().get()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:240:54 [INFO] [stdout] | [INFO] [stdout] 232 | fn set_any(scope: RecordingScope, kind: StoreKind, rec: Option) -> Option { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | LOCAL_DATA_RECORDING.with(|cell| cell.borrow_mut().replace(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:251:59 [INFO] [stdout] | [INFO] [stdout] 232 | fn set_any(scope: RecordingScope, kind: StoreKind, rec: Option) -> Option { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | LOCAL_BLUEPRINT_RECORDING.with(|cell| cell.borrow_mut().replace(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:139:14 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | Self(MemorySinkStorage::new(rec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:213:20 [INFO] [stdout] | [INFO] [stdout] 211 | fn new(rec: RecordingStream) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | Self { [INFO] [stdout] 213 | inner: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:282:31 [INFO] [stdout] | [INFO] [stdout] 279 | let mut inner = self.inner.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | encode_as_bytes_local(std::mem::take(&mut inner.msgs).into_iter().map(Ok)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log_sink.rs:309:23 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn new(callback: F) -> Self [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:141:23 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(application_id: impl Into) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | store_id: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:147:29 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn new(application_id: impl Into) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | batcher_config: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 278 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | ) -> RecordingStreamResult<(RecordingStream, crate::log_sink::MemorySinkStorage)> { [INFO] [stdout] 280 | let (enabled, store_info, batcher_config) = self.into_args(); [INFO] [stdout] | ---------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let rec = if enabled { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let sink = crate::log_sink::MemorySink::new(rec.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 293 | let storage = sink.buffer(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | Ok((rec, storage)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:563:52 [INFO] [stdout] | [INFO] [stdout] 563 | batcher_config.unwrap_or_else(|| match ChunkBatcherConfig::from_env() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:767:12 [INFO] [stdout] | [INFO] [stdout] 728 | info: StoreInfo, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 729 | batcher_config: ChunkBatcherConfig, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | sink: Box, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | ) -> RecordingStreamResult { [INFO] [stdout] 732 | let on_release = batcher_config.hooks.on_release.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 733 | let batcher = ChunkBatcher::new(batcher_config)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | let (cmds_tx, cmds_rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 751 | [INFO] [stdout] 752 | let batcher_to_sink_handle = { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let info = info.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | let batcher = batcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 767 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 768 | | info, [INFO] [stdout] 769 | | tick: AtomicI64::new(0), [INFO] [stdout] 770 | | cmds_tx, [INFO] [stdout] ... | [INFO] [stdout] 774 | | pid_at_creation: std::process::id(), [INFO] [stdout] 775 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:759:68 [INFO] [stdout] | [INFO] [stdout] 730 | sink: Box, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 731 | ) -> RecordingStreamResult { [INFO] [stdout] 732 | let on_release = batcher_config.hooks.on_release.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | let (cmds_tx, cmds_rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | let info = info.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 758 | let batcher = batcher.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | move || forwarding_thread(info, sink, cmds_rx, batcher.chunks(), on_release) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:807:10 [INFO] [stdout] | [INFO] [stdout] 806 | let (tx, rx) = crossbeam::channel::bounded(0); // oneshot [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 807 | (Self::Flush(tx), rx) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:836:9 [INFO] [stdout] | [INFO] [stdout] 824 | info: StoreInfo, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 825 | batcher_config: ChunkBatcherConfig, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 826 | sink: Box, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 827 | ) -> RecordingStreamResult { [INFO] [stdout] 828 | let sink = (info.store_id.kind == StoreKind::Recording) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | RecordingStreamInner::new(info, batcher_config, sink).map(|inner| Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:837:20 [INFO] [stdout] | [INFO] [stdout] 836 | RecordingStreamInner::new(info, batcher_config, sink).map(|inner| Self { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 837 | inner: Either::Left(Arc::new(Some(inner))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:943:20 [INFO] [stdout] | [INFO] [stdout] 925 | let array = batch.to_arrow()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 931 | let data_type = ArrowListArray::::default_datatype(array.data_type().clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 932 | [INFO] [stdout] 933 | let array = ArrowListArray::::try_new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | Ok((batch.name(), array)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:1043:13 [INFO] [stdout] | [INFO] [stdout] 1034 | ent_path: impl Into, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1043 | arch.as_component_batches() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:1945:26 [INFO] [stdout] | [INFO] [stdout] 1939 | fn with(f: impl FnOnce(&mut Self) -> R) -> R { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1945 | THREAD_INFO.with(|thread_info| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 1946 | | let mut thread_info = thread_info.borrow_mut(); [INFO] [stdout] 1947 | | let thread_info = thread_info.get_or_insert_with(Self::default); [INFO] [stdout] 1948 | | f(thread_info) [INFO] [stdout] 1949 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recording_stream.rs:2315:44 [INFO] [stdout] | [INFO] [stdout] 2315 | let mut assert_next_row = || match msgs.pop().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_sdk` (lib test) due to 28 previous errors [INFO] running `Command { std: "docker" "inspect" "966ec2783017e593869febb3253167e86e32c40a2fc2351be738cb789a212931", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "966ec2783017e593869febb3253167e86e32c40a2fc2351be738cb789a212931", kill_on_drop: false }` [INFO] [stdout] 966ec2783017e593869febb3253167e86e32c40a2fc2351be738cb789a212931