[INFO] fetching crate rdbc-rs 0.1.0... [INFO] checking rdbc-rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rdbc-rs 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rdbc-rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rdbc-rs 0.1.0 [INFO] finished tweaking crates.io crate rdbc-rs 0.1.0 [INFO] tweaked toml for crates.io crate rdbc-rs 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 127 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4453c0dc5729a4070f834df51e7126761c46074a9c09a32b3ca3ba24d86f754 [INFO] running `Command { std: "docker" "start" "-a" "c4453c0dc5729a4070f834df51e7126761c46074a9c09a32b3ca3ba24d86f754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4453c0dc5729a4070f834df51e7126761c46074a9c09a32b3ca3ba24d86f754", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4453c0dc5729a4070f834df51e7126761c46074a9c09a32b3ca3ba24d86f754", kill_on_drop: false }` [INFO] [stdout] c4453c0dc5729a4070f834df51e7126761c46074a9c09a32b3ca3ba24d86f754 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e543b792c5932c20ea898768e4f9ee222cd82cb01bdc795991f6b87cd1904e1 [INFO] running `Command { std: "docker" "start" "-a" "5e543b792c5932c20ea898768e4f9ee222cd82cb01bdc795991f6b87cd1904e1", kill_on_drop: false }` [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rdbc-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/database.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 28 | fn new(driver_name: S, driver: Arc>, url: S) -> anyhow::Result [INFO] [stdout] | -------------- ------------------------------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | driver, [INFO] [stdout] 37 | | url, [INFO] [stdout] 38 | | conns: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 41 | | _driver_name: driver_name, [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/database.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 94 | async fn prepare(&mut self, query: S) -> Result> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | / { [INFO] [stdout] 98 | | let mut conn = self.get_conn()?; [INFO] [stdout] 99 | | [INFO] [stdout] 100 | | let async_driver = AsyncDriver::new(); [INFO] [stdout] ... | [INFO] [stdout] 106 | | Ok(Statement::new(Some(self.clone()), Some(conn), stmt)) [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/stmt.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 66 | db: Option, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | conn: Option>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | stmt: Box, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | inner: Arc::new(Mutex::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 72 | | db, [INFO] [stdout] 73 | | conn, [INFO] [stdout] 74 | | stmt: Some(stmt), [INFO] [stdout] 75 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/tx.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 46 | tx: Box, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | conn: Option>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | db: DB, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | inner: Arc::new(Mutex::new(Inner { tx, conn, db })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/tx.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 86 | async fn prepare(&mut self, query: S) -> anyhow::Result> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / { [INFO] [stdout] 90 | | let async_driver = AsyncDriver::new(); [INFO] [stdout] 91 | | [INFO] [stdout] 92 | | self.inner [INFO] [stdout] ... | [INFO] [stdout] 100 | | Ok(Statement::new(None, None, stmt)) [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/rows.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn new(rows: Box, stmt: Statement) -> Self { [INFO] [stdout] | --------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self { [INFO] [stdout] 38 | inner: Arc::new(Mutex::new(Inner { rows, stmt })), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future/driver.rs:34:28 [INFO] [stdout] | [INFO] [stdout] 32 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | [INFO] [stdout] 34 | BoxedCallback::new(move |result| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 35 | | let mut inner = inner.lock().unwrap(); [INFO] [stdout] 36 | | inner.output = Some(result); [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rdbc-rs` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5e543b792c5932c20ea898768e4f9ee222cd82cb01bdc795991f6b87cd1904e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e543b792c5932c20ea898768e4f9ee222cd82cb01bdc795991f6b87cd1904e1", kill_on_drop: false }` [INFO] [stdout] 5e543b792c5932c20ea898768e4f9ee222cd82cb01bdc795991f6b87cd1904e1