[INFO] crate rcu-clean 0.1.8 is already in cache [INFO] checking rcu-clean-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rcu-clean 0.1.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rcu-clean 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rcu-clean 0.1.8 [INFO] finished tweaking crates.io crate rcu-clean 0.1.8 [INFO] tweaked toml for crates.io crate rcu-clean 0.1.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d603849b66bcf4682c8b93dd7e1c45f80d8ddf88eef05cdc80f5fa1cb7890d42 [INFO] running `Command { std: "docker" "start" "-a" "d603849b66bcf4682c8b93dd7e1c45f80d8ddf88eef05cdc80f5fa1cb7890d42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d603849b66bcf4682c8b93dd7e1c45f80d8ddf88eef05cdc80f5fa1cb7890d42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d603849b66bcf4682c8b93dd7e1c45f80d8ddf88eef05cdc80f5fa1cb7890d42", kill_on_drop: false }` [INFO] [stdout] d603849b66bcf4682c8b93dd7e1c45f80d8ddf88eef05cdc80f5fa1cb7890d42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57d2d5629ad0969550b9babf9ea187ddf5fc196abc013d0f645f1c461316eada [INFO] running `Command { std: "docker" "start" "-a" "57d2d5629ad0969550b9babf9ea187ddf5fc196abc013d0f645f1c461316eada", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking rcu-clean v0.1.8 (/opt/rustwide/workdir) [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 114 | impl_stuff!(BoxRcu); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 105 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 114 | impl_stuff!(BoxRcu); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 115 | impl_stuff!(RcRcu); [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 105 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 115 | impl_stuff!(RcRcu); [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 116 | impl_stuff!(ArcRcu); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `serde` [INFO] [stdout] --> src/lib.rs:105:15 [INFO] [stdout] | [INFO] [stdout] 105 | #[cfg(serde)] [INFO] [stdout] | ^^^^^ help: found config with similar value: `feature = "serde"` [INFO] [stdout] ... [INFO] [stdout] 116 | impl_stuff!(ArcRcu); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(serde)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(serde)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `impl_stuff` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boxrcu.rs:53:49 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | BoxRcu { [INFO] [stdout] 53 | inner: AtomicPtr::new(Box::into_raw(Box::new(List { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 54 | | value: x, [INFO] [stdout] 55 | | next: AtomicPtr::new(null_mut()), [INFO] [stdout] 56 | | }))), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rcrcu.rs:77:20 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | inner: Rc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 78 | | borrow_count: Cell::new(0), [INFO] [stdout] 79 | | am_writing: Cell::new(false), [INFO] [stdout] 80 | | list: List { [INFO] [stdout] ... | [INFO] [stdout] 83 | | }, [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arcrcu.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | inner: Arc::new(Inner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 83 | | borrow_count: AtomicUsize::new(0), [INFO] [stdout] 84 | | am_writing: AtomicBool::new(false), [INFO] [stdout] 85 | | list: List { [INFO] [stdout] ... | [INFO] [stdout] 88 | | }, [INFO] [stdout] 89 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graceful.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Self::from(Arc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graceful.rs:156:47 [INFO] [stdout] | [INFO] [stdout] 156 | .get_or_init(|| SourceOfGrace(Mutex::new(Arc::new(Mutex::new(Vec::new()))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rcu-clean` (lib) due to 6 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "57d2d5629ad0969550b9babf9ea187ddf5fc196abc013d0f645f1c461316eada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57d2d5629ad0969550b9babf9ea187ddf5fc196abc013d0f645f1c461316eada", kill_on_drop: false }` [INFO] [stdout] 57d2d5629ad0969550b9babf9ea187ddf5fc196abc013d0f645f1c461316eada