[INFO] fetching crate rbx_binary 0.7.7... [INFO] checking rbx_binary-0.7.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rbx_binary 0.7.7 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rbx_binary 0.7.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rbx_binary 0.7.7 [INFO] finished tweaking crates.io crate rbx_binary 0.7.7 [INFO] tweaked toml for crates.io crate rbx_binary 0.7.7 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 110 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45c42377309f55d2ebfa27c23ba0ab03b247e7011ce7911828b23ff988d103bb [INFO] running `Command { std: "docker" "start" "-a" "45c42377309f55d2ebfa27c23ba0ab03b247e7011ce7911828b23ff988d103bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45c42377309f55d2ebfa27c23ba0ab03b247e7011ce7911828b23ff988d103bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45c42377309f55d2ebfa27c23ba0ab03b247e7011ce7911828b23ff988d103bb", kill_on_drop: false }` [INFO] [stdout] 45c42377309f55d2ebfa27c23ba0ab03b247e7011ce7911828b23ff988d103bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89de15bf9c6fbf9b018e62920e01c5538d7b2b8c621a005783ee1b20da61f80c [INFO] running `Command { std: "docker" "start" "-a" "89de15bf9c6fbf9b018e62920e01c5538d7b2b8c621a005783ee1b20da61f80c", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking rbx_types v1.10.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking rbx_reflection v4.7.0 [INFO] [stderr] Checking rbx_dom_weak v2.9.0 [INFO] [stderr] Checking rbx_reflection_database v0.2.12+roblox-638 [INFO] [stderr] Checking rbx_binary v0.7.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::header::FileHeader` [INFO] [stdout] --> src/deserializer/mod.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) use self::header::FileHeader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserializer/mod.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn deserialize(&self, reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let mut deserializer = DeserializerState::new(self, reader)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(deserializer.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserializer/error.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(inner: InnerError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { [INFO] [stdout] 17 | source: Box::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserializer/state.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 216 | mut input: R, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | ) -> Result { [INFO] [stdout] 218 | let tree = WeakDom::new(InstanceBuilder::new("DataModel")); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let instances_by_ref = HashMap::with_capacity(1 + header.num_instances as usize); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | Ok(DeserializerState { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | deserializer, [INFO] [stdout] 227 | | input, [INFO] [stdout] 228 | | tree, [INFO] [stdout] ... | [INFO] [stdout] 234 | | unknown_type_ids: HashSet::new(), [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer/error.rs:16:21 [INFO] [stdout] | [INFO] [stdout] 14 | fn from(inner: InnerError) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self { [INFO] [stdout] 16 | source: Box::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer/state.rs:240:25 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn new(serializer: &'db Serializer<'db>, dom: &'dom WeakDom, output: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | type_infos: TypeInfos::new(serializer.database), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer/state.rs:241:29 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn new(serializer: &'db Serializer<'db>, dom: &'dom WeakDom, output: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | shared_strings: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer/state.rs:242:32 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn new(serializer: &'db Serializer<'db>, dom: &'dom WeakDom, output: W) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | shared_string_ids: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serializer/state.rs:437:33 [INFO] [stdout] | [INFO] [stdout] 437 | .or_else(|| Self::fallback_default_value(serialized_ty).map(Cow::Owned)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rbx_binary` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "89de15bf9c6fbf9b018e62920e01c5538d7b2b8c621a005783ee1b20da61f80c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89de15bf9c6fbf9b018e62920e01c5538d7b2b8c621a005783ee1b20da61f80c", kill_on_drop: false }` [INFO] [stdout] 89de15bf9c6fbf9b018e62920e01c5538d7b2b8c621a005783ee1b20da61f80c