[INFO] fetching crate rayon_logs 0.1.3... [INFO] checking rayon_logs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rayon_logs 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rayon_logs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rayon_logs 0.1.3 [INFO] finished tweaking crates.io crate rayon_logs 0.1.3 [INFO] tweaked toml for crates.io crate rayon_logs 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rayon_logs 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be9b6dfc8bdef9d375258a322adf122cccc7ff06e944578817492038c130ba1e [INFO] running `Command { std: "docker" "start" "-a" "be9b6dfc8bdef9d375258a322adf122cccc7ff06e944578817492038c130ba1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be9b6dfc8bdef9d375258a322adf122cccc7ff06e944578817492038c130ba1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be9b6dfc8bdef9d375258a322adf122cccc7ff06e944578817492038c130ba1e", kill_on_drop: false }` [INFO] [stdout] be9b6dfc8bdef9d375258a322adf122cccc7ff06e944578817492038c130ba1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8967577de0b9f1121c92fd31f5de3138f70e04ddf87fb892c4527532b7b79c05 [INFO] running `Command { std: "docker" "start" "-a" "8967577de0b9f1121c92fd31f5de3138f70e04ddf87fb892c4527532b7b79c05", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.105 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking bstr v0.2.12 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Checking rayon_logs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `read_sequence` and `task` are never used [INFO] [stdout] --> src/fork_join_graph.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 14 | trait BlockVector { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 17 | fn read_sequence(&self, id: BlockId) -> &Vec; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 18 | fn task(&self, id: BlockId) -> (TaskId, &TaskLog); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | LOGS.with(|l| l.borrow().push(event)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool.rs:552:22 [INFO] [stdout] | [INFO] [stdout] 547 | pub fn scope<'scope, OP, R>(&self, op: OP) -> R [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 552 | self.install(|| scope(op)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 141 | fn split_at(self, index: usize) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let (left, right) = self.base.split_at(index); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ( [INFO] [stdout] 144 | LoggedProducer { base: left }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 141 | fn split_at(self, index: usize) -> (Self, Self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let (left, right) = self.base.split_at(index); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | LoggedProducer { base: right }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:224:19 [INFO] [stdout] | [INFO] [stdout] 214 | fn into_folder(self) -> LoggedFolder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | base: self.base.into_folder(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 279 | fn consume(self, item: T) -> Self { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | LoggedFolder { [INFO] [stdout] 281 | base: self.base.consume(item), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 64 | let first_block = Block::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let mut list = LinkedList::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | data: UnsafeCell::new(list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn num_threads(self, threads_number: usize) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | ThreadPoolBuilder { [INFO] [stdout] 26 | builder: self.builder.num_threads(threads_number), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let logs = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let shared_logs = logs.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let pool = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | pool.map(|p| ThreadPool { pool: p, logs }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prelude.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 76 | fn into_par_iter(self) -> Logged { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Logged::new(rayon::prelude::IntoParallelIterator::into_par_iter(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compare.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 120 | let input = setup_function(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | self.pool.logging_install(|| algorithm(input)).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compare.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 145 | let input = setup_function(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | self.pool.logging_install(|| algorithm(input)).1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:99:44 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|(thread_id, thread_log)| thread_log.iter().map(move |log| (thread_id, log))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 300 | pub fn load>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let file = File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | serde_json::from_reader(file).map_err(|_| ErrorKind::InvalidData.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon_algorithms/slice/mod.rs:138:60 [INFO] [stdout] | [INFO] [stdout] 138 | par_mergesort(self.as_parallel_slice_mut(), |a, b| f(a).lt(&f(b))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rayon_algorithms/slice/mod.rs:138:69 [INFO] [stdout] | [INFO] [stdout] 138 | par_mergesort(self.as_parallel_slice_mut(), |a, b| f(a).lt(&f(b))); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raw_events.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rayon_logs` (lib) due to 18 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8967577de0b9f1121c92fd31f5de3138f70e04ddf87fb892c4527532b7b79c05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8967577de0b9f1121c92fd31f5de3138f70e04ddf87fb892c4527532b7b79c05", kill_on_drop: false }` [INFO] [stdout] 8967577de0b9f1121c92fd31f5de3138f70e04ddf87fb892c4527532b7b79c05