[INFO] fetching crate rattler_shell 0.21.6... [INFO] checking rattler_shell-0.21.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rattler_shell 0.21.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rattler_shell 0.21.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rattler_shell 0.21.6 [INFO] finished tweaking crates.io crate rattler_shell 0.21.6 [INFO] tweaked toml for crates.io crate rattler_shell 0.21.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 195 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding sysinfo v0.30.13 (latest: v0.31.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49863f04a419e1ca6bbf5c340a4fa70fbc9148a8817812066e2a091fd863dfe1 [INFO] running `Command { std: "docker" "start" "-a" "49863f04a419e1ca6bbf5c340a4fa70fbc9148a8817812066e2a091fd863dfe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49863f04a419e1ca6bbf5c340a4fa70fbc9148a8817812066e2a091fd863dfe1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49863f04a419e1ca6bbf5c340a4fa70fbc9148a8817812066e2a091fd863dfe1", kill_on_drop: false }` [INFO] [stdout] 49863f04a419e1ca6bbf5c340a4fa70fbc9148a8817812066e2a091fd863dfe1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1b0ab778c5089da694b43594cc0172f5545933ea16bc3da4cf1d80afdaca56c [INFO] running `Command { std: "docker" "start" "-a" "d1b0ab778c5089da694b43594cc0172f5545933ea16bc3da4cf1d80afdaca56c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.3.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking typed-path v0.9.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling rattler_macros v1.0.1 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking lazy-regex v3.3.0 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking purl v0.1.3 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking serde-untagged v0.1.6 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking rattler_redaction v0.1.1 [INFO] [stderr] Checking file_url v0.1.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking simd-json v0.13.10 [INFO] [stderr] Checking rattler_digest v1.0.1 [INFO] [stderr] Checking rattler_conda_types v0.27.2 [INFO] [stderr] Checking rattler_shell v0.21.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 332 | shell_type: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let env_vars = collect_env_vars(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Ok(Activator { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | target_prefix: path.to_path_buf(), [INFO] [stdout] 346 | | shell_type, [INFO] [stdout] 347 | | paths, [INFO] [stdout] ... | [INFO] [stdout] 351 | | platform, [INFO] [stdout] 352 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:400:12 [INFO] [stdout] | [INFO] [stdout] 362 | let mut script = ShellScript::new(self.shell_type.clone(), self.platform); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | Ok(ActivationResult { script, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:472:12 [INFO] [stdout] | [INFO] [stdout] 413 | let activation_script = self.activation(variables)?.script; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | let mut activation_detection_script = [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | let activation_script_dir = tempfile::TempDir::new()?; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let mut activation_command = self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | Ok(after_env [INFO] [stdout] | ____________^ [INFO] [stdout] 473 | | .into_iter() [INFO] [stdout] 474 | | .filter(|(key, value)| before_env.get(key) != Some(value)) [INFO] [stdout] 475 | | // this happens on Windows for some reason [INFO] [stdout] ... | [INFO] [stdout] 478 | | .filter(|(key, _)| !key.is_empty()) [INFO] [stdout] 479 | | .map(|(key, value)| (key.to_owned(), value.to_owned())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rattler_shell` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 332 | shell_type: T, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | let env_vars = collect_env_vars(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Ok(Activator { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | target_prefix: path.to_path_buf(), [INFO] [stdout] 346 | | shell_type, [INFO] [stdout] 347 | | paths, [INFO] [stdout] ... | [INFO] [stdout] 351 | | platform, [INFO] [stdout] 352 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:400:12 [INFO] [stdout] | [INFO] [stdout] 362 | let mut script = ShellScript::new(self.shell_type.clone(), self.platform); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | Ok(ActivationResult { script, path }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activation.rs:472:12 [INFO] [stdout] | [INFO] [stdout] 413 | let activation_script = self.activation(variables)?.script; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 418 | let mut activation_detection_script = [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | let activation_script_dir = tempfile::TempDir::new()?; [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 441 | let mut activation_command = self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | Ok(after_env [INFO] [stdout] | ____________^ [INFO] [stdout] 473 | | .into_iter() [INFO] [stdout] 474 | | .filter(|(key, value)| before_env.get(key) != Some(value)) [INFO] [stdout] 475 | | // this happens on Windows for some reason [INFO] [stdout] ... | [INFO] [stdout] 478 | | .filter(|(key, _)| !key.is_empty()) [INFO] [stdout] 479 | | .map(|(key, value)| (key.to_owned(), value.to_owned())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rattler_shell` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "d1b0ab778c5089da694b43594cc0172f5545933ea16bc3da4cf1d80afdaca56c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1b0ab778c5089da694b43594cc0172f5545933ea16bc3da4cf1d80afdaca56c", kill_on_drop: false }` [INFO] [stdout] d1b0ab778c5089da694b43594cc0172f5545933ea16bc3da4cf1d80afdaca56c