[INFO] fetching crate ratify 2.2.0... [INFO] checking ratify-2.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ratify 2.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ratify 2.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ratify 2.2.0 [INFO] finished tweaking crates.io crate ratify 2.2.0 [INFO] tweaked toml for crates.io crate ratify 2.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ratify 2.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7aa44a7d4afaf9ffcdd8a9dc965f8b08dede33dfbf27f332e411be746dd23e59 [INFO] running `Command { std: "docker" "start" "-a" "7aa44a7d4afaf9ffcdd8a9dc965f8b08dede33dfbf27f332e411be746dd23e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7aa44a7d4afaf9ffcdd8a9dc965f8b08dede33dfbf27f332e411be746dd23e59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7aa44a7d4afaf9ffcdd8a9dc965f8b08dede33dfbf27f332e411be746dd23e59", kill_on_drop: false }` [INFO] [stdout] 7aa44a7d4afaf9ffcdd8a9dc965f8b08dede33dfbf27f332e411be746dd23e59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4fc3b235fc4324d61c1979cbae882fa20137642247a1a559919a048ee90fc142 [INFO] running `Command { std: "docker" "start" "-a" "4fc3b235fc4324d61c1979cbae882fa20137642247a1a559919a048ee90fc142", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling rustix v0.38.26 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.8.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking human_bytes v0.4.3 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking predicates v3.0.4 [INFO] [stderr] Checking tempfile v3.8.1 [INFO] [stderr] Checking serde_json v1.0.114 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking ignore v0.4.21 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking assert_fs v1.0.13 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Checking ratify v2.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 124 | let iterator = walkdir::WalkDir::new(directory.path()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let all_paths_thread = std::thread::spawn(move || { [INFO] [stdout] 126 | / iterator [INFO] [stdout] 127 | | .into_iter() [INFO] [stdout] 128 | | .filter_ok(|entry| !entry.path().is_dir()) [INFO] [stdout] 129 | | .map(|entry| { [INFO] [stdout] ... | [INFO] [stdout] 132 | | .and_then(|e| e.path().try_canonicalize()) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 129 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | / entry [INFO] [stdout] 131 | | .context("Failed reading directory") [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 142 | .map(|maybe_entry| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / maybe_entry [INFO] [stdout] 144 | | .context("Failed reading entry") [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 217 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(crate::reporting::ReportEntry::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | self.path.clone(), [INFO] [stdout] 234 | | size, [INFO] [stdout] 235 | | if hash == self.hash { [INFO] [stdout] ... | [INFO] [stdout] 239 | | }, [INFO] [stdout] 240 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | path: Arc::new(root_path.as_path().join(subpath).assume_canonical()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parallel.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) fn for_each(iterator: I, handler: F) -> impl Iterator [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 8 | let (entries_sender, entries_receiver) = crossbeam_channel::bounded(num_cpus::get() * 4); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | let (results_sender, results_receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 13 | | let _producer = s.spawn(move || { [INFO] [stdout] 14 | | for entry in iterator { [INFO] [stdout] 15 | | if entries_sender.send(entry).is_err() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | results_receiver.into_iter() [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 124 | let iterator = walkdir::WalkDir::new(directory.path()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let all_paths_thread = std::thread::spawn(move || { [INFO] [stdout] 126 | / iterator [INFO] [stdout] 127 | | .into_iter() [INFO] [stdout] 128 | | .filter_ok(|entry| !entry.path().is_dir()) [INFO] [stdout] 129 | | .map(|entry| { [INFO] [stdout] ... | [INFO] [stdout] 132 | | .and_then(|e| e.path().try_canonicalize()) [INFO] [stdout] 133 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:130:17 [INFO] [stdout] | [INFO] [stdout] 129 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | / entry [INFO] [stdout] 131 | | .context("Failed reading directory") [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 142 | .map(|maybe_entry| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / maybe_entry [INFO] [stdout] 144 | | .context("Failed reading entry") [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 217 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | Ok(crate::reporting::ReportEntry::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | self.path.clone(), [INFO] [stdout] 234 | | size, [INFO] [stdout] 235 | | if hash == self.hash { [INFO] [stdout] ... | [INFO] [stdout] 239 | | }, [INFO] [stdout] 240 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | path: Arc::new(root_path.as_path().join(subpath).assume_canonical()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parallel.rs:12:24 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) fn for_each(iterator: I, handler: F) -> impl Iterator [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 8 | let (entries_sender, entries_receiver) = crossbeam_channel::bounded(num_cpus::get() * 4); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | let (results_sender, results_receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | [INFO] [stdout] 12 | std::thread::scope(|s| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 13 | | let _producer = s.spawn(move || { [INFO] [stdout] 14 | | for entry in iterator { [INFO] [stdout] 15 | | if entries_sender.send(entry).is_err() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | results_receiver.into_iter() [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratify` (bin "ratify" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ratify` (bin "ratify") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "4fc3b235fc4324d61c1979cbae882fa20137642247a1a559919a048ee90fc142", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fc3b235fc4324d61c1979cbae882fa20137642247a1a559919a048ee90fc142", kill_on_drop: false }` [INFO] [stdout] 4fc3b235fc4324d61c1979cbae882fa20137642247a1a559919a048ee90fc142