[INFO] fetching crate ratelimit_meter 5.0.0... [INFO] checking ratelimit_meter-5.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ratelimit_meter 5.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ratelimit_meter 5.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ratelimit_meter 5.0.0 [INFO] finished tweaking crates.io crate ratelimit_meter 5.0.0 [INFO] tweaked toml for crates.io crate ratelimit_meter 5.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding evmap v6.0.1 (latest: v10.0.2) [INFO] [stderr] Adding hashbrown v0.5.0 (latest: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding nonzero_ext v0.1.5 (latest: v0.3.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05a9eee65c36876d97bdd203b5bcb6fa7b35cc5fe2728278dfe0a1a93ebe5944 [INFO] running `Command { std: "docker" "start" "-a" "05a9eee65c36876d97bdd203b5bcb6fa7b35cc5fe2728278dfe0a1a93ebe5944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05a9eee65c36876d97bdd203b5bcb6fa7b35cc5fe2728278dfe0a1a93ebe5944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05a9eee65c36876d97bdd203b5bcb6fa7b35cc5fe2728278dfe0a1a93ebe5944", kill_on_drop: false }` [INFO] [stdout] 05a9eee65c36876d97bdd203b5bcb6fa7b35cc5fe2728278dfe0a1a93ebe5944 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 13f3c814d60a033f9606389838e8cf607152e69ed76f0a1e5e65b5315f0f56e7 [INFO] running `Command { std: "docker" "start" "-a" "13f3c814d60a033f9606389838e8cf607152e69ed76f0a1e5e65b5315f0f56e7", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking evmap v6.0.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking nonzero_ext v0.1.5 [INFO] [stderr] Checking ratelimit_meter v5.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | #![cfg_attr(feature = "cargo-clippy", deny(warnings))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `evmap`, `no_std`, `parking_lot`, `spin`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/algorithms.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use self::gcra::*; [INFO] [stdout] | ^^^^^^^^^^^^^ the name `State` in the type namespace is first re-exported here [INFO] [stdout] 7 | pub use self::leaky_bucket::*; [INFO] [stdout] | --------------------- but the name `State` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 119 | let (r, mut w): ( [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | algorithm: >::construct( [INFO] [stdout] | ________________________^ [INFO] [stdout] 126 | | capacity, [INFO] [stdout] 127 | | nonzero!(1u32), [INFO] [stdout] 128 | | per_time_unit, [INFO] [stdout] 129 | | ) [INFO] [stdout] 130 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:132:25 [INFO] [stdout] | [INFO] [stdout] 119 | let (r, mut w): ( [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | map_writer: Arc::new(Mutex::new(w)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:133:20 [INFO] [stdout] | [INFO] [stdout] 119 | let (r, mut w): ( [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | clock: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 166 | fn check_and_update_key(&self, key: K, update: F) -> Result<(), E> [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / self.map_reader [INFO] [stdout] 171 | | .get_and(&key, |v| { [INFO] [stdout] 172 | | // we have at least one element (owing to the nature of [INFO] [stdout] 173 | | // the evmap, it says there could be >1 [INFO] [stdout] ... | [INFO] [stdout] 176 | | update(state) [INFO] [stdout] 177 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:178:29 [INFO] [stdout] | [INFO] [stdout] 166 | fn check_and_update_key(&self, key: K, update: F) -> Result<(), E> [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 179 | | // entry does not exist, let's add one. [INFO] [stdout] 180 | | let mut w = self.map_writer.lock(); [INFO] [stdout] 181 | | let state: A::BucketState = Default::default(); [INFO] [stdout] ... | [INFO] [stdout] 185 | | result [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:358:20 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn with_hasher(self, hash_builder: H2) -> Builder { [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 358 | clock: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 369 | pub fn with_cell_weight(self, cell_weight: NonZeroU32) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Builder { [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | cell_weight, [INFO] [stdout] 375 | | ..self [INFO] [stdout] 376 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state/keyed.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 394 | pub fn build(self) -> Result, InconsistentCapacity> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | let map_opts = evmap::Options::default().with_hasher(self.hasher); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | let (r, mut w) = if self.map_capacity.is_some() { [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | Ok(KeyedRateLimiter { [INFO] [stdout] | ____________^ [INFO] [stdout] 409 | | algorithm: >::construct( [INFO] [stdout] 410 | | self.capacity, [INFO] [stdout] 411 | | self.cell_weight, [INFO] [stdout] ... | [INFO] [stdout] 416 | | map_writer: Arc::new(Mutex::new(w)), [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utilities/algorithms.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 16 | weight: U, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | duration: D, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | / A::construct( [INFO] [stdout] 21 | | cap, [INFO] [stdout] 22 | | weight.into().unwrap_or(nonzero!(1u32)), [INFO] [stdout] 23 | | duration [INFO] [stdout] ... | [INFO] [stdout] 26 | | ) [INFO] [stdout] 27 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utilities/algorithms.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 16 | weight: U, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | duration: D, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratelimit_meter` (lib) due to 11 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "13f3c814d60a033f9606389838e8cf607152e69ed76f0a1e5e65b5315f0f56e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13f3c814d60a033f9606389838e8cf607152e69ed76f0a1e5e65b5315f0f56e7", kill_on_drop: false }` [INFO] [stdout] 13f3c814d60a033f9606389838e8cf607152e69ed76f0a1e5e65b5315f0f56e7