[INFO] fetching crate ratcurl 0.1.0... [INFO] checking ratcurl-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ratcurl 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ratcurl 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ratcurl 0.1.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate ratcurl 0.1.0 [INFO] tweaked toml for crates.io crate ratcurl 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ratcurl 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f597746856c917ed6159a72deb2690163fe007e65a94f71c45fb015ed86bebbf [INFO] running `Command { std: "docker" "start" "-a" "f597746856c917ed6159a72deb2690163fe007e65a94f71c45fb015ed86bebbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f597746856c917ed6159a72deb2690163fe007e65a94f71c45fb015ed86bebbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f597746856c917ed6159a72deb2690163fe007e65a94f71c45fb015ed86bebbf", kill_on_drop: false }` [INFO] [stdout] f597746856c917ed6159a72deb2690163fe007e65a94f71c45fb015ed86bebbf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 452867a371bed1e8c6471906bdf91f10552ae4321bd09938d0090ae47477e4bd [INFO] running `Command { std: "docker" "start" "-a" "452867a371bed1e8c6471906bdf91f10552ae4321bd09938d0090ae47477e4bd", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling anyhow v1.0.66 [INFO] [stderr] Compiling ratcurl v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling openssl-sys v0.9.79 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling ratcurl-sys v0.1.0+curl-7.86.0 [INFO] [stderr] Checking net2 v0.2.38 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_probe` [INFO] [stdout] --> src/easy/handler.rs:674:11 [INFO] [stdout] | [INFO] [stdout] 674 | #[cfg(need_openssl_probe)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_probe)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_probe)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_probe` [INFO] [stdout] --> src/easy/handler.rs:696:15 [INFO] [stdout] | [INFO] [stdout] 696 | #[cfg(not(need_openssl_probe))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_probe)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_probe)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_init` [INFO] [stdout] --> src/lib.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | #[cfg(need_openssl_init)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_init)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_init)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_init` [INFO] [stdout] --> src/lib.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(need_openssl_init)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_init)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_init)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_probe` [INFO] [stdout] --> src/easy/handler.rs:674:11 [INFO] [stdout] | [INFO] [stdout] 674 | #[cfg(need_openssl_probe)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_probe)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_probe)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_probe` [INFO] [stdout] --> src/easy/handler.rs:696:15 [INFO] [stdout] | [INFO] [stdout] 696 | #[cfg(not(need_openssl_probe))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_probe)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_probe)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_init` [INFO] [stdout] --> src/lib.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | #[cfg(need_openssl_init)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_init)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_init)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `need_openssl_init` [INFO] [stdout] --> src/lib.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg(need_openssl_init)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(need_openssl_init)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(need_openssl_init)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/easy/handler.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | drop(data); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut [u8]` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 114 - drop(data); [INFO] [stdout] 114 + let _ = data; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/easy/handler.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | drop(whence); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `SeekFrom` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 138 - drop(whence); [INFO] [stdout] 138 + let _ = whence; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/easy/handler.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | drop(data); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&[u8]` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 188 - drop(data); [INFO] [stdout] 188 + let _ = data; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/easy/handler.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | drop((dltotal, dlnow, ultotal, ulnow)); [INFO] [stdout] | ^^^^^--------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `(f64, f64, f64, f64)` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 224 - drop((dltotal, dlnow, ultotal, ulnow)); [INFO] [stdout] 224 + let _ = (dltotal, dlnow, ultotal, ulnow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn socket_function(&mut self, f: F) -> Result<(), MultiError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | self._socket_function(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:261:30 [INFO] [stdout] | [INFO] [stdout] 257 | pub fn timer_function(&mut self, f: F) -> Result<(), MultiError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | self._timer_function(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:413:12 [INFO] [stdout] | [INFO] [stdout] 405 | pub fn add(&self, mut easy: Easy) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Ok(EasyHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 414 | | guard: DetachGuard { [INFO] [stdout] 415 | | multi: self.raw.clone(), [INFO] [stdout] 416 | | easy: easy.raw(), [INFO] [stdout] ... | [INFO] [stdout] 419 | | _marker: marker::PhantomData, [INFO] [stdout] 420 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 424 | pub fn add2(&self, easy: Easy2) -> Result, MultiError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | Ok(Easy2Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 429 | | guard: DetachGuard { [INFO] [stdout] 430 | | multi: self.raw.clone(), [INFO] [stdout] 431 | | easy: easy.raw(), [INFO] [stdout] ... | [INFO] [stdout] 434 | | _marker: marker::PhantomData, [INFO] [stdout] 435 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn catch T>(f: F) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match panic::catch_unwind(AssertUnwindSafe(f)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | match LAST_ERROR.try_with(|slot| slot.borrow().is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | if let Ok(Some(t)) = LAST_ERROR.try_with(|slot| slot.borrow_mut().take()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratcurl` (lib test) due to 8 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/easy/handler.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | drop(data); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut [u8]` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 114 - drop(data); [INFO] [stdout] 114 + let _ = data; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/easy/handler.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | drop(whence); [INFO] [stdout] | ^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `SeekFrom` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 138 - drop(whence); [INFO] [stdout] 138 + let _ = whence; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/easy/handler.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | drop(data); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&[u8]` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 188 - drop(data); [INFO] [stdout] 188 + let _ = data; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/easy/handler.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | drop((dltotal, dlnow, ultotal, ulnow)); [INFO] [stdout] | ^^^^^--------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `(f64, f64, f64, f64)` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 224 - drop((dltotal, dlnow, ultotal, ulnow)); [INFO] [stdout] 224 + let _ = (dltotal, dlnow, ultotal, ulnow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:162:31 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn socket_function(&mut self, f: F) -> Result<(), MultiError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | self._socket_function(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:261:30 [INFO] [stdout] | [INFO] [stdout] 257 | pub fn timer_function(&mut self, f: F) -> Result<(), MultiError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | self._timer_function(Box::new(f)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:413:12 [INFO] [stdout] | [INFO] [stdout] 405 | pub fn add(&self, mut easy: Easy) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 413 | Ok(EasyHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 414 | | guard: DetachGuard { [INFO] [stdout] 415 | | multi: self.raw.clone(), [INFO] [stdout] 416 | | easy: easy.raw(), [INFO] [stdout] ... | [INFO] [stdout] 419 | | _marker: marker::PhantomData, [INFO] [stdout] 420 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/multi.rs:428:12 [INFO] [stdout] | [INFO] [stdout] 424 | pub fn add2(&self, easy: Easy2) -> Result, MultiError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | Ok(Easy2Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 429 | | guard: DetachGuard { [INFO] [stdout] 430 | | multi: self.raw.clone(), [INFO] [stdout] 431 | | easy: easy.raw(), [INFO] [stdout] ... | [INFO] [stdout] 434 | | _marker: marker::PhantomData, [INFO] [stdout] 435 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn catch T>(f: F) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | match panic::catch_unwind(AssertUnwindSafe(f)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | match LAST_ERROR.try_with(|slot| slot.borrow().is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/panic.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 31 | if let Ok(Some(t)) = LAST_ERROR.try_with(|slot| slot.borrow_mut().take()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratcurl` (lib) due to 8 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "452867a371bed1e8c6471906bdf91f10552ae4321bd09938d0090ae47477e4bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "452867a371bed1e8c6471906bdf91f10552ae4321bd09938d0090ae47477e4bd", kill_on_drop: false }` [INFO] [stdout] 452867a371bed1e8c6471906bdf91f10552ae4321bd09938d0090ae47477e4bd