[INFO] fetching crate rash-shell 0.2.0... [INFO] checking rash-shell-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rash-shell 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate rash-shell 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rash-shell 0.2.0 [INFO] finished tweaking crates.io crate rash-shell 0.2.0 [INFO] tweaked toml for crates.io crate rash-shell 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate rash-shell 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8c7c4d8e4abdd1bd71e79e727988feddfca17930755a6d45bfbd28fa1f1d760 [INFO] running `Command { std: "docker" "start" "-a" "f8c7c4d8e4abdd1bd71e79e727988feddfca17930755a6d45bfbd28fa1f1d760", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8c7c4d8e4abdd1bd71e79e727988feddfca17930755a6d45bfbd28fa1f1d760", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8c7c4d8e4abdd1bd71e79e727988feddfca17930755a6d45bfbd28fa1f1d760", kill_on_drop: false }` [INFO] [stdout] f8c7c4d8e4abdd1bd71e79e727988feddfca17930755a6d45bfbd28fa1f1d760 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b617dad0d1276f8a92073ba3e1dcfe520fcd68a4993918f41f854738d1d7067 [INFO] running `Command { std: "docker" "start" "-a" "3b617dad0d1276f8a92073ba3e1dcfe520fcd68a4993918f41f854738d1d7067", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling regex-syntax v0.6.23 [INFO] [stderr] Compiling hashbrown v0.9.1 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling siphasher v0.3.5 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling bit-set v0.5.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling itertools v0.10.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling pico-args v0.4.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Compiling ena v0.14.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling string_cache v0.8.1 [INFO] [stderr] Compiling petgraph v0.5.1 [INFO] [stderr] Compiling dirs v1.0.5 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling term v0.5.2 [INFO] [stderr] Compiling regex v1.4.5 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Compiling ascii-canvas v2.0.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking lalrpop-util v0.19.5 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling lalrpop v0.19.5 [INFO] [stderr] Checking rustyline v8.0.0 [INFO] [stderr] Compiling rash-shell v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let Err(e) = exec(context, cmd, args, env) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if let Err(e) = try_exec(&filepath(path, filename), args, &exported) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | if let Err(e) = try_exec(&filepath(path_buf, filename), args, &exported) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:56:16 [INFO] [stdout] | [INFO] [stdout] 56 | if let Err(e) = exec(context, cmd, args, env) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | if let Err(e) = try_exec(&filepath(path, filename), args, &exported) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/exec.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | if let Err(e) = try_exec(&filepath(path_buf, filename), args, &exported) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 70 | let old = env::current_dir(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | [INFO] [stdout] 72 | match env::set_current_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/context.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | stdout.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = stdout.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/context.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | stderr.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | let _ = stderr.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn into_exported(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | / self.vars.into_iter() [INFO] [stdout] 96 | | .filter(|(_, v)| v.export && v.var_eq.is_some()) [INFO] [stdout] 97 | | .map(|(_, v)| v.var_eq.unwrap()) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rash-shell` (bin "rash") due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtins.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 70 | let old = env::current_dir(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | [INFO] [stdout] 72 | match env::set_current_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/context.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | stdout.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 45 | let _ = stdout.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/context.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | stderr.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | let _ = stderr.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn into_exported(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | / self.vars.into_iter() [INFO] [stdout] 96 | | .filter(|(_, v)| v.export && v.var_eq.is_some()) [INFO] [stdout] 97 | | .map(|(_, v)| v.var_eq.unwrap()) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rash-shell` (bin "rash" test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3b617dad0d1276f8a92073ba3e1dcfe520fcd68a4993918f41f854738d1d7067", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b617dad0d1276f8a92073ba3e1dcfe520fcd68a4993918f41f854738d1d7067", kill_on_drop: false }` [INFO] [stdout] 3b617dad0d1276f8a92073ba3e1dcfe520fcd68a4993918f41f854738d1d7067