[INFO] fetching crate rarity 0.3.0... [INFO] checking rarity-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rarity 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rarity 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rarity 0.3.0 [INFO] finished tweaking crates.io crate rarity 0.3.0 [INFO] tweaked toml for crates.io crate rarity 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e9495fa417eb501046ef4f4201b8d79632370a21758c0479f4559b4b4e65eab [INFO] running `Command { std: "docker" "start" "-a" "3e9495fa417eb501046ef4f4201b8d79632370a21758c0479f4559b4b4e65eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e9495fa417eb501046ef4f4201b8d79632370a21758c0479f4559b4b4e65eab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e9495fa417eb501046ef4f4201b8d79632370a21758c0479f4559b4b4e65eab", kill_on_drop: false }` [INFO] [stdout] 3e9495fa417eb501046ef4f4201b8d79632370a21758c0479f4559b4b4e65eab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9790ad045c22e7d6011fae88b805d60e2a41b5764286afc1ddb96bdfdf721068 [INFO] running `Command { std: "docker" "start" "-a" "9790ad045c22e7d6011fae88b805d60e2a41b5764286afc1ddb96bdfdf721068", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking unicode-id v0.3.4 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking terminal_color_builder v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking markdown v1.0.0-alpha.20 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking rarity v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `identifier` and `count` are never read [INFO] [stdout] --> src/word_stats.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct WordResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | identifier: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | count: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WordResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threads.rs:58:2 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn multithread(tasks: Vec, num_threads: Option, task_fn: F) -> Vec [INFO] [stdout] | ------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | let wrapped_tasks = Arc::new(Mutex::new(tasks.into_iter().enumerate())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let num_threads = num_threads.unwrap_or_else(num_cpus::get); [INFO] [stdout] 13 | let mut join_handles = Vec::with_capacity(num_threads); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut thread_results = Vec::with_capacity(num_tasks); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | thread_results.into_iter().map(|e| e.1).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/word_stats.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | count: word.regex.find_iter(&text).count(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rarity` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `identifier` and `count` are never read [INFO] [stdout] --> src/word_stats.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct WordResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | identifier: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 19 | count: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `WordResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threads.rs:58:2 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn multithread(tasks: Vec, num_threads: Option, task_fn: F) -> Vec [INFO] [stdout] | ------------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | let wrapped_tasks = Arc::new(Mutex::new(tasks.into_iter().enumerate())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let num_threads = num_threads.unwrap_or_else(num_cpus::get); [INFO] [stdout] 13 | let mut join_handles = Vec::with_capacity(num_threads); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let mut thread_results = Vec::with_capacity(num_tasks); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | thread_results.into_iter().map(|e| e.1).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/word_stats.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | count: word.regex.find_iter(&text).count(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rarity` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9790ad045c22e7d6011fae88b805d60e2a41b5764286afc1ddb96bdfdf721068", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9790ad045c22e7d6011fae88b805d60e2a41b5764286afc1ddb96bdfdf721068", kill_on_drop: false }` [INFO] [stdout] 9790ad045c22e7d6011fae88b805d60e2a41b5764286afc1ddb96bdfdf721068