[INFO] fetching crate rano 0.2.0... [INFO] checking rano-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rano 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rano 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rano 0.2.0 [INFO] finished tweaking crates.io crate rano 0.2.0 [INFO] tweaked toml for crates.io crate rano 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rano 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a7a39c88cfca62dcde9eeae37d75009c69721e23af342178c7668c2e86a0e70 [INFO] running `Command { std: "docker" "start" "-a" "7a7a39c88cfca62dcde9eeae37d75009c69721e23af342178c7668c2e86a0e70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a7a39c88cfca62dcde9eeae37d75009c69721e23af342178c7668c2e86a0e70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a7a39c88cfca62dcde9eeae37d75009c69721e23af342178c7668c2e86a0e70", kill_on_drop: false }` [INFO] [stdout] 7a7a39c88cfca62dcde9eeae37d75009c69721e23af342178c7668c2e86a0e70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9970d032b41d704f95fbe9d330a9e8ccec0f63537cce1799efaf9c5d79aa6bd6 [INFO] running `Command { std: "docker" "start" "-a" "9970d032b41d704f95fbe9d330a9e8ccec0f63537cce1799efaf9c5d79aa6bd6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling syn v1.0.63 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking regex v1.4.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking console v0.14.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking rano v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:156:39 [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in refs_section.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in refs_section.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in IntoIterator::into_iter(refs_section).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:164:27 [INFO] [stdout] | [INFO] [stdout] 164 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 164 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 164 - for hunk in hunks.into_iter() { [INFO] [stdout] 164 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:166:59 [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in hunk.instructions.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in hunk.instructions.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in IntoIterator::into_iter(hunk.instructions).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/layout.rs:400:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn layout(TokenTree { ctx, tokens }: TokenTree, reset: ResetVector) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut hunks = Vec::with_capacity(tokens.len() / HUNK_LEN_HEUR); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let hunks = hunks.into_boxed_slice(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | Ok(Layout { [INFO] [stdout] | ________^ [INFO] [stdout] 401 | | ctx, [INFO] [stdout] 402 | | references, [INFO] [stdout] 403 | | reset, [INFO] [stdout] 404 | | hunks, [INFO] [stdout] 405 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 136 | c: C, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | instr: c(reference, ind), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 144 | fn new_reg_io ReferenceToken>(ins: Span, c: C) -> ReferenceInstruction { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | instr: c(), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:600:8 [INFO] [stdout] | [INFO] [stdout] 284 | / LTokens { [INFO] [stdout] 285 | | ctx, [INFO] [stdout] 286 | | tokens: ltokens, [INFO] [stdout] 287 | | }: LTokens, [INFO] [stdout] | |______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let mut tokens = Vec::with_capacity(len / HEUR); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | Ok(TokenTree { [INFO] [stdout] | ________^ [INFO] [stdout] 601 | | ctx, [INFO] [stdout] 602 | | tokens: tokens.into_boxed_slice(), [INFO] [stdout] 603 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/release.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 40 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 40 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 40 - for hunk in hunks.into_iter() { [INFO] [stdout] 40 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/release.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in hunk.instructions.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in hunk.instructions.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in IntoIterator::into_iter(hunk.instructions).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/resolve.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 52 | / Layout { [INFO] [stdout] 53 | | ctx, [INFO] [stdout] 54 | | references, [INFO] [stdout] 55 | | reset, [INFO] [stdout] 56 | | hunks, [INFO] [stdout] 57 | | }: Layout, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ohunks = Vec::with_capacity(hunks.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Resolved { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | ctx, [INFO] [stdout] 100 | | references, [INFO] [stdout] 101 | | reset, [INFO] [stdout] 102 | | hunks: ohunks.into_boxed_slice(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/resolve.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 63 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 63 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 63 - for hunk in hunks.into_iter() { [INFO] [stdout] 63 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/resolve.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | for instr in hunk.instructions.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 66 | for instr in hunk.instructions.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 66 - for instr in hunk.instructions.into_iter() { [INFO] [stdout] 66 + for instr in hunk.instructions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rano` (lib) due to 6 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:156:39 [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in refs_section.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in refs_section.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 156 | for (idx, &b) in IntoIterator::into_iter(refs_section).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:164:27 [INFO] [stdout] | [INFO] [stdout] 164 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 164 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 164 - for hunk in hunks.into_iter() { [INFO] [stdout] 164 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/debug.rs:166:59 [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in hunk.instructions.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in hunk.instructions.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 166 | for (offset, &(_, span)) in IntoIterator::into_iter(hunk.instructions).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/layout.rs:400:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn layout(TokenTree { ctx, tokens }: TokenTree, reset: ResetVector) -> Result { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let mut hunks = Vec::with_capacity(tokens.len() / HUNK_LEN_HEUR); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | let hunks = hunks.into_boxed_slice(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | Ok(Layout { [INFO] [stdout] | ________^ [INFO] [stdout] 401 | | ctx, [INFO] [stdout] 402 | | references, [INFO] [stdout] 403 | | reset, [INFO] [stdout] 404 | | hunks, [INFO] [stdout] 405 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 136 | c: C, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | instr: c(reference, ind), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 144 | fn new_reg_io ReferenceToken>(ins: Span, c: C) -> ReferenceInstruction { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | instr: c(), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/parse.rs:600:8 [INFO] [stdout] | [INFO] [stdout] 284 | / LTokens { [INFO] [stdout] 285 | | ctx, [INFO] [stdout] 286 | | tokens: ltokens, [INFO] [stdout] 287 | | }: LTokens, [INFO] [stdout] | |______________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let mut tokens = Vec::with_capacity(len / HEUR); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | Ok(TokenTree { [INFO] [stdout] | ________^ [INFO] [stdout] 601 | | ctx, [INFO] [stdout] 602 | | tokens: tokens.into_boxed_slice(), [INFO] [stdout] 603 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/release.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 40 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 40 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 40 - for hunk in hunks.into_iter() { [INFO] [stdout] 40 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/release.rs:42:55 [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in hunk.instructions.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in hunk.instructions.iter().enumerate() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 42 | for (offset, (instr, _)) in IntoIterator::into_iter(hunk.instructions).enumerate() { [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ass/resolve.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 52 | / Layout { [INFO] [stdout] 53 | | ctx, [INFO] [stdout] 54 | | references, [INFO] [stdout] 55 | | reset, [INFO] [stdout] 56 | | hunks, [INFO] [stdout] 57 | | }: Layout, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut ohunks = Vec::with_capacity(hunks.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | Ok(Resolved { [INFO] [stdout] | ________^ [INFO] [stdout] 99 | | ctx, [INFO] [stdout] 100 | | references, [INFO] [stdout] 101 | | reset, [INFO] [stdout] 102 | | hunks: ohunks.into_boxed_slice(), [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/resolve.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 63 | for hunk in hunks.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 63 | for hunk in hunks.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 63 - for hunk in hunks.into_iter() { [INFO] [stdout] 63 + for hunk in hunks { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/ass/resolve.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | for instr in hunk.instructions.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 66 | for instr in hunk.instructions.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 66 - for instr in hunk.instructions.into_iter() { [INFO] [stdout] 66 + for instr in hunk.instructions { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rano` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9970d032b41d704f95fbe9d330a9e8ccec0f63537cce1799efaf9c5d79aa6bd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9970d032b41d704f95fbe9d330a9e8ccec0f63537cce1799efaf9c5d79aa6bd6", kill_on_drop: false }` [INFO] [stdout] 9970d032b41d704f95fbe9d330a9e8ccec0f63537cce1799efaf9c5d79aa6bd6