[INFO] fetching crate rand-distributions 0.1.2... [INFO] checking rand-distributions-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rand-distributions 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rand-distributions 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rand-distributions 0.1.2 [INFO] finished tweaking crates.io crate rand-distributions 0.1.2 [INFO] tweaked toml for crates.io crate rand-distributions 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc833690e6487b2551ef04cb7cffe03a7f09538973b6f95a4d3da5050ccddcab [INFO] running `Command { std: "docker" "start" "-a" "dc833690e6487b2551ef04cb7cffe03a7f09538973b6f95a4d3da5050ccddcab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc833690e6487b2551ef04cb7cffe03a7f09538973b6f95a4d3da5050ccddcab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc833690e6487b2551ef04cb7cffe03a7f09538973b6f95a4d3da5050ccddcab", kill_on_drop: false }` [INFO] [stdout] dc833690e6487b2551ef04cb7cffe03a7f09538973b6f95a4d3da5050ccddcab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f06b307a578731726f5727d1653ff691f2be11c6150b77c4bebba4ad470bb6fc [INFO] running `Command { std: "docker" "start" "-a" "f06b307a578731726f5727d1653ff691f2be11c6150b77c4bebba4ad470bb6fc", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking rand-distributions v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused macro definition: `random_simple_to_default_distribution` [INFO] [stdout] --> src/random.rs:44:14 [INFO] [stdout] | [INFO] [stdout] 44 | macro_rules! random_simple_to_default_distribution { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread_rng` [INFO] [stdout] --> src/random.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 60 | use rand::{self, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread_rng` [INFO] [stdout] --> src/impls.rs:165:27 [INFO] [stdout] | [INFO] [stdout] 165 | use rand::{self, Rng, thread_rng}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread_rng` [INFO] [stdout] --> src/rng_ext.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 47 | use rand::{self, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread_rng` [INFO] [stdout] --> src/uniform.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | use rand::{self, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread_rng` [INFO] [stdout] --> src/uniform_range.rs:117:22 [INFO] [stdout] | [INFO] [stdout] 117 | use rand::{self, thread_rng, Rng}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated type `PrimitiveInteger::Unsigned` is more private than the item `UniformPrimitiveIntegerRange` [INFO] [stdout] --> src/uniform_range.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl UniformPrimitiveIntegerRange [INFO] [stdout] 25 | | where Wrapping: Sub> [INFO] [stdout] | |____________________________________________________________________^ implementation `UniformPrimitiveIntegerRange` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but associated type `PrimitiveInteger::Unsigned` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/uniform_range.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | type Unsigned : PrimitiveInteger; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PrimitiveInteger` is more private than the item `UniformPrimitiveIntegerRange` [INFO] [stdout] --> src/uniform_range.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl UniformPrimitiveIntegerRange [INFO] [stdout] 25 | | where Wrapping: Sub> [INFO] [stdout] | |____________________________________________________________________^ implementation `UniformPrimitiveIntegerRange` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `PrimitiveInteger` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/uniform_range.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | trait PrimitiveInteger: PrimInt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng_ext.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 7 | fn generate>(&mut self, d: IntoD) -> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | d.into_distribution().sample(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng_ext.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 15 | fn generate_iter<'a, T, IntoD: IntoDistribution>(&'a mut self, d: IntoD) -> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | distribution: d.into_distribution() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rand-distributions` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated type `PrimitiveInteger::Unsigned` is more private than the item `uniform_range::UniformPrimitiveIntegerRange` [INFO] [stdout] --> src/uniform_range.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl UniformPrimitiveIntegerRange [INFO] [stdout] 25 | | where Wrapping: Sub> [INFO] [stdout] | |____________________________________________________________________^ implementation `uniform_range::UniformPrimitiveIntegerRange` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but associated type `PrimitiveInteger::Unsigned` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/uniform_range.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | type Unsigned : PrimitiveInteger; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `PrimitiveInteger` is more private than the item `uniform_range::UniformPrimitiveIntegerRange` [INFO] [stdout] --> src/uniform_range.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl UniformPrimitiveIntegerRange [INFO] [stdout] 25 | | where Wrapping: Sub> [INFO] [stdout] | |____________________________________________________________________^ implementation `uniform_range::UniformPrimitiveIntegerRange` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but trait `PrimitiveInteger` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/uniform_range.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | trait PrimitiveInteger: PrimInt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/random.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 63 | struct MyType(u8); [INFO] [stdout] | ------ ^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng_ext.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 7 | fn generate>(&mut self, d: IntoD) -> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | d.into_distribution().sample(self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rng_ext.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 15 | fn generate_iter<'a, T, IntoD: IntoDistribution>(&'a mut self, d: IntoD) -> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | distribution: d.into_distribution() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/uniform.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | fn foo, T, R: Rng>(d: D, rng: &mut R) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | d.into_distribution().sample(rng) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rand-distributions` (lib test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f06b307a578731726f5727d1653ff691f2be11c6150b77c4bebba4ad470bb6fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f06b307a578731726f5727d1653ff691f2be11c6150b77c4bebba4ad470bb6fc", kill_on_drop: false }` [INFO] [stdout] f06b307a578731726f5727d1653ff691f2be11c6150b77c4bebba4ad470bb6fc