[INFO] fetching crate rafx-renderer 0.0.16... [INFO] checking rafx-renderer-0.0.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rafx-renderer 0.0.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate rafx-renderer 0.0.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rafx-renderer 0.0.16 [INFO] finished tweaking crates.io crate rafx-renderer 0.0.16 [INFO] tweaked toml for crates.io crate rafx-renderer 0.0.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 175 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding ash v0.37.3+1.3.251 (latest: v0.38.0+1.3.281) [INFO] [stderr] Adding ash-window v0.12.0 (latest: v0.13.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.20.0 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cocoa v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding cocoa v0.25.0 (latest: v0.26.0) [INFO] [stderr] Adding cocoa-foundation v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding core-graphics v0.22.3 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics v0.23.2 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics-types v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glam v0.13.1 (latest: v0.29.0) [INFO] [stderr] Adding globwalk v0.8.1 (latest: v0.9.1) [INFO] [stderr] Adding gpu-allocator v0.22.0 (latest: v0.27.0) [INFO] [stderr] Adding hassle-rs v0.10.0 (latest: v0.11.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding metal v0.25.0 (latest: v0.29.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding raw-window-handle v0.5.2 (latest: v0.6.2) [INFO] [stderr] Adding raw-window-metal v0.3.2 (latest: v0.4.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding ron v0.6.6 (latest: v0.8.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding spirv-std v0.4.0-alpha.8 (latest: v0.9.0) [INFO] [stderr] Adding spirv-std-macros v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding spirv-std-types v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.44.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08a0f6468edf04b707ee832dba22b0b9c9b0ef31569cedb7846c12f3ec159406 [INFO] running `Command { std: "docker" "start" "-a" "08a0f6468edf04b707ee832dba22b0b9c9b0ef31569cedb7846c12f3ec159406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08a0f6468edf04b707ee832dba22b0b9c9b0ef31569cedb7846c12f3ec159406", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08a0f6468edf04b707ee832dba22b0b9c9b0ef31569cedb7846c12f3ec159406", kill_on_drop: false }` [INFO] [stdout] 08a0f6468edf04b707ee832dba22b0b9c9b0ef31569cedb7846c12f3ec159406 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef0782dd6ba503d37e9bb17fb5e3f76f47a62e4542e904c6396b71c69a6204f5 [INFO] running `Command { std: "docker" "start" "-a" "ef0782dd6ba503d37e9bb17fb5e3f76f47a62e4542e904c6396b71c69a6204f5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking const-fnv1a-hash v1.1.0 [INFO] [stderr] Compiling uuid v0.8.2 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rafx-base v0.0.16 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling type-uuid-derive v0.1.2 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking type-uuid v0.1.2 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking glam v0.13.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ron v0.6.6 [INFO] [stderr] Checking rafx-api v0.0.16 [INFO] [stderr] Checking hydrate-base v0.0.2 [INFO] [stderr] Checking hydrate-schema v0.0.2 [INFO] [stderr] Checking hydrate-loader v0.0.2 [INFO] [stderr] Checking hydrate-data v0.0.2 [INFO] [stderr] Checking rafx-visibility v0.0.16 [INFO] [stderr] Checking rafx-framework v0.0.16 [INFO] [stderr] Checking hydrate-pipeline v0.0.2 [INFO] [stderr] Checking rafx-assets v0.0.16 [INFO] [stderr] Checking rafx-renderer v0.0.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_thread.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 23 | let (job_tx, job_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (result_tx, result_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let join_handle = thread_builder [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | join_handle: Some(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_thread.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 23 | let (job_tx, job_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (result_tx, result_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | .spawn(|| match Self::render_thread(job_rx, result_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_frame_job.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 185 | frame_packets: Vec>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | ) -> Vec + 'prepare>> { [INFO] [stdout] 187 | / frame_packets [INFO] [stdout] 188 | | .into_iter() [INFO] [stdout] 189 | | .map(|frame_packet| { [INFO] [stdout] 190 | | RenderFrameJob::create_prepare_job(features, prepare_context, frame_packet) [INFO] [stdout] 191 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer_builder.rs:211:34 [INFO] [stdout] | [INFO] [stdout] 211 | .or_else(|| Some(Box::new(RendererThreadPoolNone::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 112 | extract_resources: ExtractResources, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | mut render_resources: RenderResources, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | feature_plugins: Vec>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | asset_plugins: Vec>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | pipeline_plugin: Arc, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | thread_pool: Box, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let asset_plugins = Arc::new(asset_plugins); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let feature_plugins = Arc::new(feature_plugins); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut upload = RafxTransferUpload::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let invalid_image_color = Self::upload_image_data( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let invalid_image_depth = Self::upload_image_data( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let invalid_cube_map_image_color = Self::upload_image_data( [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let invalid_cube_map_image_depth = Self::upload_image_data( [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let invalid_resources = InvalidResources { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let load_context = RendererLoadContext { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let render_thread = if use_render_thread { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let renderer = RendererInner { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Renderer { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | inner: Arc::new(Mutex::new(renderer)), [INFO] [stdout] 248 | | render_thread, [INFO] [stdout] 249 | | asset_plugins, [INFO] [stdout] ... | [INFO] [stdout] 254 | | transfer_queue: transfer_queue.clone(), [INFO] [stdout] 255 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | let image = resources.insert_image(texture); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | Ok(resources.get_or_create_image_view(&image, None)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:869:14 [INFO] [stdout] | [INFO] [stdout] 846 | let frame_packet_metadata = temporary_work [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 852 | let mut frame_packet = temporary_work [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | Some(feature.new_extract_job(extract_context, frame_packet)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:840:33 [INFO] [stdout] | [INFO] [stdout] 840 | .map(|frame_packet| frame_packet.borrow().is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_thread.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 23 | let (job_tx, job_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (result_tx, result_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let join_handle = thread_builder [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | join_handle: Some(join_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rafx-renderer` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_thread.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 23 | let (job_tx, job_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let (result_tx, result_rx) = crossbeam_channel::bounded(1); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | .spawn(|| match Self::render_thread(job_rx, result_tx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render_frame_job.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 185 | frame_packets: Vec>, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | ) -> Vec + 'prepare>> { [INFO] [stdout] 187 | / frame_packets [INFO] [stdout] 188 | | .into_iter() [INFO] [stdout] 189 | | .map(|frame_packet| { [INFO] [stdout] 190 | | RenderFrameJob::create_prepare_job(features, prepare_context, frame_packet) [INFO] [stdout] 191 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer_builder.rs:211:34 [INFO] [stdout] | [INFO] [stdout] 211 | .or_else(|| Some(Box::new(RendererThreadPoolNone::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 112 | extract_resources: ExtractResources, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | mut render_resources: RenderResources, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | feature_plugins: Vec>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | asset_plugins: Vec>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | pipeline_plugin: Arc, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | thread_pool: Box, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let asset_plugins = Arc::new(asset_plugins); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let feature_plugins = Arc::new(feature_plugins); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let mut upload = RafxTransferUpload::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let invalid_image_color = Self::upload_image_data( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let invalid_image_depth = Self::upload_image_data( [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let invalid_cube_map_image_color = Self::upload_image_data( [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let invalid_cube_map_image_depth = Self::upload_image_data( [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let invalid_resources = InvalidResources { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let load_context = RendererLoadContext { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let render_thread = if use_render_thread { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let renderer = RendererInner { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Renderer { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | inner: Arc::new(Mutex::new(renderer)), [INFO] [stdout] 248 | | render_thread, [INFO] [stdout] 249 | | asset_plugins, [INFO] [stdout] ... | [INFO] [stdout] 254 | | transfer_queue: transfer_queue.clone(), [INFO] [stdout] 255 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 315 | let image = resources.insert_image(texture); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | Ok(resources.get_or_create_image_view(&image, None)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:869:14 [INFO] [stdout] | [INFO] [stdout] 846 | let frame_packet_metadata = temporary_work [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 852 | let mut frame_packet = temporary_work [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | Some(feature.new_extract_job(extract_context, frame_packet)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/renderer.rs:840:33 [INFO] [stdout] | [INFO] [stdout] 840 | .map(|frame_packet| frame_packet.borrow().is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rafx-renderer` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "ef0782dd6ba503d37e9bb17fb5e3f76f47a62e4542e904c6396b71c69a6204f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef0782dd6ba503d37e9bb17fb5e3f76f47a62e4542e904c6396b71c69a6204f5", kill_on_drop: false }` [INFO] [stdout] ef0782dd6ba503d37e9bb17fb5e3f76f47a62e4542e904c6396b71c69a6204f5