[INFO] fetching crate rafx-assets 0.0.16... [INFO] checking rafx-assets-0.0.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rafx-assets 0.0.16 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate rafx-assets 0.0.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rafx-assets 0.0.16 [INFO] finished tweaking crates.io crate rafx-assets 0.0.16 [INFO] tweaked toml for crates.io crate rafx-assets 0.0.16 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 204 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding ash v0.37.3+1.3.251 (latest: v0.38.0+1.3.281) [INFO] [stderr] Adding ash-window v0.12.0 (latest: v0.13.0) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.20.0 (latest: v0.22.1) [INFO] [stderr] Adding basis-universal v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding basis-universal-sys v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cocoa v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding cocoa v0.25.0 (latest: v0.26.0) [INFO] [stderr] Adding cocoa-foundation v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding core-graphics v0.22.3 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics v0.23.2 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics-types v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding ddsfile v0.4.0 (latest: v0.5.2) [INFO] [stderr] Adding enum-primitive-derive v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding glam v0.13.1 (latest: v0.29.0) [INFO] [stderr] Adding globwalk v0.8.1 (latest: v0.9.1) [INFO] [stderr] Adding gpu-allocator v0.22.0 (latest: v0.27.0) [INFO] [stderr] Adding hassle-rs v0.10.0 (latest: v0.11.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding image_dds v0.3.0 (latest: v0.6.0) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding metal v0.25.0 (latest: v0.29.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding raw-window-handle v0.5.2 (latest: v0.6.2) [INFO] [stderr] Adding raw-window-metal v0.3.2 (latest: v0.4.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding ron v0.6.6 (latest: v0.8.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding spirv-std v0.4.0-alpha.8 (latest: v0.9.0) [INFO] [stderr] Adding spirv-std-macros v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding spirv-std-types v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows v0.44.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-targets v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1cf1da2962f307f3f845dce9ba70891ffb26cfdb2f218339087bc2180963dce [INFO] running `Command { std: "docker" "start" "-a" "d1cf1da2962f307f3f845dce9ba70891ffb26cfdb2f218339087bc2180963dce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1cf1da2962f307f3f845dce9ba70891ffb26cfdb2f218339087bc2180963dce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1cf1da2962f307f3f845dce9ba70891ffb26cfdb2f218339087bc2180963dce", kill_on_drop: false }` [INFO] [stdout] d1cf1da2962f307f3f845dce9ba70891ffb26cfdb2f218339087bc2180963dce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 292ffdbb128009d60df94ee727b949f0a466f047df58023d58c5475a7bf9092c [INFO] running `Command { std: "docker" "start" "-a" "292ffdbb128009d60df94ee727b949f0a466f047df58023d58c5475a7bf9092c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling uuid v0.8.2 [INFO] [stderr] Checking const-fnv1a-hash v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking rafx-base v0.0.16 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling type-uuid-derive v0.1.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking type-uuid v0.1.2 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking glam v0.13.1 [INFO] [stderr] Checking ron v0.6.6 [INFO] [stderr] Checking rafx-api v0.0.16 [INFO] [stderr] Checking hydrate-base v0.0.2 [INFO] [stderr] Checking hydrate-schema v0.0.2 [INFO] [stderr] Checking hydrate-loader v0.0.2 [INFO] [stderr] Checking hydrate-data v0.0.2 [INFO] [stderr] Checking rafx-visibility v0.0.16 [INFO] [stderr] Checking rafx-framework v0.0.16 [INFO] [stderr] Checking hydrate-pipeline v0.0.2 [INFO] [stderr] Checking rafx-assets v0.0.16 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `astc4x4_supported` and `bc7_supported` are never read [INFO] [stdout] --> src/assets/image/asset_upload_queue.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 83 | pub struct ImageAssetUploadQueue { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 96 | pub astc4x4_supported: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 97 | pub bc7_supported: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/asset_upload_queue.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 102 | upload_queue_context: UploadQueueContext, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let (image_upload_result_tx, image_upload_result_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(ImageAssetUploadQueue { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | upload_queue_context, [INFO] [stdout] 110 | | image_upload_result_rx, [INFO] [stdout] 111 | | image_upload_result_tx, [INFO] [stdout] ... | [INFO] [stdout] 116 | | upload_texture_row_alignment: device_info.upload_texture_row_alignment, [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/asset_type_handler.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 21 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let image_upload_queue = ImageAssetUploadQueue::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 34 | | load_queues, [INFO] [stdout] 35 | | image_upload_queue, [INFO] [stdout] 36 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/thumbnails.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 61 | _bytes: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> PipelineResult { [INFO] [stdout] 63 | Err("Cannot decode basis-universal image, the basis-universal feature was not enabled when compiling".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/thumbnails.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 96 | _bytes: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> PipelineResult { [INFO] [stdout] 98 | Err("Cannot decode BCn image, the ddsfile feature was not enabled when compiling".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/image/builder_compressed_image.rs:91:47 [INFO] [stdout] | [INFO] [stdout] 91 | for &layer_entry in layer_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 91 | for &layer_entry in layer_entries.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 91 - for &layer_entry in layer_entries.into_iter() { [INFO] [stdout] 91 + for &layer_entry in layer_entries { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/image/builder_compressed_image.rs:95:59 [INFO] [stdout] | [INFO] [stdout] 95 | for &mip_level_entry in mip_level_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 95 | for &mip_level_entry in mip_level_entries.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 95 - for &mip_level_entry in mip_level_entries.into_iter() { [INFO] [stdout] 95 + for &mip_level_entry in mip_level_entries { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/assets.rs:341:20 [INFO] [stdout] | [INFO] [stdout] 332 | passes: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | let inner = MaterialAssetInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/assets.rs:463:20 [INFO] [stdout] | [INFO] [stdout] 448 | material: Handle, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 449 | material_asset: MaterialAsset, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | material_descriptor_sets: Arc>>>, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | slot_assignments: Vec, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | descriptor_set_writes: Vec>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | ) -> Self { [INFO] [stdout] 454 | let inner = MaterialInstanceAssetInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_importer.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 130 | let mut passes = Vec::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(MaterialAssetData { passes }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_importer.rs:131:74 [INFO] [stdout] | [INFO] [stdout] 131 | for pass_entry in asset_data.passes().resolve_entries()?.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 131 | for pass_entry in asset_data.passes().resolve_entries()?.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 131 - for pass_entry in asset_data.passes().resolve_entries()?.into_iter() { [INFO] [stdout] 131 + for pass_entry in asset_data.passes().resolve_entries()? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_instance_importer.rs:193:20 [INFO] [stdout] | [INFO] [stdout] 148 | let material = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let mut slot_assignments = Vec::default(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(MaterialInstanceAssetData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 194 | | slot_assignments, [INFO] [stdout] 195 | | material, [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_instance_importer.rs:153:70 [INFO] [stdout] | [INFO] [stdout] 153 | asset_data.slot_assignments().resolve_entries()?.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 153 | asset_data.slot_assignments().resolve_entries()?.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 153 - asset_data.slot_assignments().resolve_entries()?.into_iter() [INFO] [stdout] 153 + asset_data.slot_assignments().resolve_entries()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/compute_pipeline/importer.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 107 | let shader_module = handle_factory.make_handle_to_default_artifact(shader_module); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Ok(ComputePipelineAssetData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | entry_name: (*entry_name).clone(), [INFO] [stdout] 110 | | shader_module, [INFO] [stdout] 111 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/buffer/asset_upload_queue.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(upload_queue_context: UploadQueueContext) -> RafxResult { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let (buffer_upload_result_tx, buffer_upload_result_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(BufferAssetUploadQueue { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | upload_queue_context, [INFO] [stdout] 24 | | buffer_upload_result_tx, [INFO] [stdout] 25 | | buffer_upload_result_rx, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/buffer/asset_type_handler.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 24 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let buffer_upload_queue = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 35 | | load_queues, [INFO] [stdout] 36 | | buffer_upload_queue, [INFO] [stdout] 37 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/asset_manager.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 73 | let resource_manager = ResourceManager::new(device_context, render_registry); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let upload_queue = UploadQueue::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(AssetManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | device_context: device_context.clone(), [INFO] [stdout] 83 | | resource_manager, [INFO] [stdout] 84 | | upload_queue, [INFO] [stdout] ... | [INFO] [stdout] 90 | | asset_registration_order: Default::default(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/upload_asset_op.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 38 | load_op: ArtifactLoadOp, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | load_handle: LoadHandle, [INFO] [stdout] 40 | asset_sender: Sender, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | sender: Sender>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> Self { [INFO] [stdout] 43 | let inner = UploadAssetOpInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | UploadAssetOp { inner: Some(inner) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/asset_type_handler.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 68 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 76 | | load_queues, [INFO] [stdout] 77 | | phantom_data: Default::default(), [INFO] [stdout] 78 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate_impl.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 36 | load_op: ArtifactLoadOp, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let asset = SerdeContext::with(loader_info, refop_sender.clone(), || { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let result = self.0.update_asset(load_handle, load_op, asset); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(UpdateArtifactResult::AsyncResult(result.result_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `astc4x4_supported` and `bc7_supported` are never read [INFO] [stdout] --> src/assets/image/asset_upload_queue.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 83 | pub struct ImageAssetUploadQueue { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 96 | pub astc4x4_supported: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 97 | pub bc7_supported: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/asset_upload_queue.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 102 | upload_queue_context: UploadQueueContext, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let (image_upload_result_tx, image_upload_result_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ---------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(ImageAssetUploadQueue { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | upload_queue_context, [INFO] [stdout] 110 | | image_upload_result_rx, [INFO] [stdout] 111 | | image_upload_result_tx, [INFO] [stdout] ... | [INFO] [stdout] 116 | | upload_texture_row_alignment: device_info.upload_texture_row_alignment, [INFO] [stdout] 117 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/asset_type_handler.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 21 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let image_upload_queue = ImageAssetUploadQueue::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 34 | | load_queues, [INFO] [stdout] 35 | | image_upload_queue, [INFO] [stdout] 36 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rafx-assets` (lib) due to 16 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/thumbnails.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 61 | _bytes: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | ) -> PipelineResult { [INFO] [stdout] 63 | Err("Cannot decode basis-universal image, the basis-universal feature was not enabled when compiling".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/image/thumbnails.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 96 | _bytes: Arc>, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | ) -> PipelineResult { [INFO] [stdout] 98 | Err("Cannot decode BCn image, the ddsfile feature was not enabled when compiling".into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/image/builder_compressed_image.rs:91:47 [INFO] [stdout] | [INFO] [stdout] 91 | for &layer_entry in layer_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 91 | for &layer_entry in layer_entries.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 91 - for &layer_entry in layer_entries.into_iter() { [INFO] [stdout] 91 + for &layer_entry in layer_entries { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/image/builder_compressed_image.rs:95:59 [INFO] [stdout] | [INFO] [stdout] 95 | for &mip_level_entry in mip_level_entries.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 95 | for &mip_level_entry in mip_level_entries.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 95 - for &mip_level_entry in mip_level_entries.into_iter() { [INFO] [stdout] 95 + for &mip_level_entry in mip_level_entries { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/assets.rs:341:20 [INFO] [stdout] | [INFO] [stdout] 332 | passes: Vec, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | let inner = MaterialAssetInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/assets.rs:463:20 [INFO] [stdout] | [INFO] [stdout] 448 | material: Handle, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 449 | material_asset: MaterialAsset, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | material_descriptor_sets: Arc>>>, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 451 | slot_assignments: Vec, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | descriptor_set_writes: Vec>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 453 | ) -> Self { [INFO] [stdout] 454 | let inner = MaterialInstanceAssetInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_importer.rs:185:20 [INFO] [stdout] | [INFO] [stdout] 130 | let mut passes = Vec::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(MaterialAssetData { passes }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_importer.rs:131:74 [INFO] [stdout] | [INFO] [stdout] 131 | for pass_entry in asset_data.passes().resolve_entries()?.into_iter() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 131 | for pass_entry in asset_data.passes().resolve_entries()?.iter() { [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 131 - for pass_entry in asset_data.passes().resolve_entries()?.into_iter() { [INFO] [stdout] 131 + for pass_entry in asset_data.passes().resolve_entries()? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_instance_importer.rs:193:20 [INFO] [stdout] | [INFO] [stdout] 148 | let material = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let mut slot_assignments = Vec::default(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(MaterialInstanceAssetData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 194 | | slot_assignments, [INFO] [stdout] 195 | | material, [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/assets/graphics_pipeline/importers/material_instance_importer.rs:153:70 [INFO] [stdout] | [INFO] [stdout] 153 | asset_data.slot_assignments().resolve_entries()?.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 153 | asset_data.slot_assignments().resolve_entries()?.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or remove `.into_iter()` to iterate by value [INFO] [stdout] | [INFO] [stdout] 153 - asset_data.slot_assignments().resolve_entries()?.into_iter() [INFO] [stdout] 153 + asset_data.slot_assignments().resolve_entries()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/compute_pipeline/importer.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 107 | let shader_module = handle_factory.make_handle_to_default_artifact(shader_module); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Ok(ComputePipelineAssetData { [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | entry_name: (*entry_name).clone(), [INFO] [stdout] 110 | | shader_module, [INFO] [stdout] 111 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/buffer/asset_upload_queue.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(upload_queue_context: UploadQueueContext) -> RafxResult { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | let (buffer_upload_result_tx, buffer_upload_result_rx) = crossbeam_channel::unbounded(); [INFO] [stdout] | ----------------------- ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | Ok(BufferAssetUploadQueue { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | upload_queue_context, [INFO] [stdout] 24 | | buffer_upload_result_tx, [INFO] [stdout] 25 | | buffer_upload_result_rx, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/buffer/asset_type_handler.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 24 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let buffer_upload_queue = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 35 | | load_queues, [INFO] [stdout] 36 | | buffer_upload_queue, [INFO] [stdout] 37 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/asset_manager.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 73 | let resource_manager = ResourceManager::new(device_context, render_registry); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let upload_queue = UploadQueue::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(AssetManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | device_context: device_context.clone(), [INFO] [stdout] 83 | | resource_manager, [INFO] [stdout] 84 | | upload_queue, [INFO] [stdout] ... | [INFO] [stdout] 90 | | asset_registration_order: Default::default(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/upload_asset_op.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 38 | load_op: ArtifactLoadOp, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | load_handle: LoadHandle, [INFO] [stdout] 40 | asset_sender: Sender, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | sender: Sender>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> Self { [INFO] [stdout] 43 | let inner = UploadAssetOpInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | UploadAssetOp { inner: Some(inner) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets/asset_type_handler.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 68 | let load_queues = LoadQueues::::default(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | asset_lookup: AssetLookup::default(), [INFO] [stdout] 76 | | load_queues, [INFO] [stdout] 77 | | phantom_data: Default::default(), [INFO] [stdout] 78 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hydrate_impl.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 36 | load_op: ArtifactLoadOp, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let asset = SerdeContext::with(loader_info, refop_sender.clone(), || { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let result = self.0.update_asset(load_handle, load_op, asset); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(UpdateArtifactResult::AsyncResult(result.result_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rafx-assets` (lib test) due to 16 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "292ffdbb128009d60df94ee727b949f0a466f047df58023d58c5475a7bf9092c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "292ffdbb128009d60df94ee727b949f0a466f047df58023d58c5475a7bf9092c", kill_on_drop: false }` [INFO] [stdout] 292ffdbb128009d60df94ee727b949f0a466f047df58023d58c5475a7bf9092c