[INFO] fetching crate raftlog 0.6.0... [INFO] checking raftlog-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate raftlog 0.6.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate raftlog 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate raftlog 0.6.0 [INFO] finished tweaking crates.io crate raftlog 0.6.0 [INFO] tweaked toml for crates.io crate raftlog 0.6.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nom v2.2.1 (latest: v7.1.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding splay_tree v0.2.10 (latest: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding trackable v0.2.24 (latest: v1.3.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7003f39f5fac01a92e4971fa0180602ebf006000290cd228b5c332767fd7d60 [INFO] running `Command { std: "docker" "start" "-a" "a7003f39f5fac01a92e4971fa0180602ebf006000290cd228b5c332767fd7d60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7003f39f5fac01a92e4971fa0180602ebf006000290cd228b5c332767fd7d60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7003f39f5fac01a92e4971fa0180602ebf006000290cd228b5c332767fd7d60", kill_on_drop: false }` [INFO] [stdout] a7003f39f5fac01a92e4971fa0180602ebf006000290cd228b5c332767fd7d60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16620d1509c55e6a8da764960df52e93811e466c09ba6e47c507ed2cd22a9ae4 [INFO] running `Command { std: "docker" "start" "-a" "16620d1509c55e6a8da764960df52e93811e466c09ba6e47c507ed2cd22a9ae4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking atomic_immut v0.1.4 [INFO] [stderr] Checking splay_tree v0.2.10 [INFO] [stderr] Checking nbchan v0.1.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling procinfo v0.4.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking fibers v0.1.13 [INFO] [stderr] Compiling trackable_derive v1.0.0 [INFO] [stderr] Checking trackable v1.3.0 [INFO] [stderr] Checking trackable v0.2.24 [INFO] [stderr] Checking prometrics v0.1.13 [INFO] [stderr] Checking raftlog v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | let node_state = track!(NodeStateMetrics::new(builder))?; [INFO] [stdout] | ---------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Self { node_state }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut builder: MetricBuilder = builder.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | builder.subsystem("node_state"); [INFO] [stdout] 35 | let transit_to_candidate_total = track!(builder [INFO] [stdout] | _____________--------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | .counter("transit_to_candidate_total") [INFO] [stdout] 37 | | .help("Number of transitions to candidate role") [INFO] [stdout] 38 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let transit_to_follower_total = track!(builder [INFO] [stdout] | _____________-------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | .counter("transit_to_follower_total") [INFO] [stdout] 41 | | .help("Number of transitions to follower role") [INFO] [stdout] 42 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let transit_to_leader_total = track!(builder [INFO] [stdout] | _____________-----------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | .counter("transit_to_leader_total") [INFO] [stdout] 45 | | .help("Number of transitions to leader role") [INFO] [stdout] 46 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let event_queue_len = track!(builder [INFO] [stdout] | _____________---------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | | .gauge("event_queue_len") [INFO] [stdout] 49 | | .help("Length of a raft event queue") [INFO] [stdout] 50 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let poll_timeout_total = track!(builder [INFO] [stdout] | _____________------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | .counter("poll_timeout_total") [INFO] [stdout] 53 | | .help("Number of timeout") [INFO] [stdout] 54 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let candidate_to_leader_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | builder [INFO] [stdout] 57 | | .histogram("candidate_to_leader_duration_seconds") [INFO] [stdout] 58 | | .help("Elapsed time moving from candidate to leader") [INFO] [stdout] 59 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let candidate_to_follower_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________--------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | | builder [INFO] [stdout] 62 | | .histogram("candidate_to_follower_duration_seconds") [INFO] [stdout] 63 | | .help("Elapsed time moving from candidate to follower") [INFO] [stdout] 64 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let loader_to_candidate_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | | builder [INFO] [stdout] 67 | | .histogram("loader_to_candidate_duration_seconds") [INFO] [stdout] 68 | | .help("Elapsed time moving from loader to candidate") [INFO] [stdout] 69 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 71 | | transit_to_candidate_total, [INFO] [stdout] 72 | | transit_to_follower_total, [INFO] [stdout] 73 | | transit_to_leader_total, [INFO] [stdout] ... | [INFO] [stdout] 78 | | loader_to_candidate_duration_seconds, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | ErrorKind::Other.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(f: prometrics::Error) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ErrorKind::Other.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/candidate.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | let future = common.save_ballot(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Candidate { [INFO] [stdout] 27 | init: Some(future), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/candidate.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 25 | let future = common.save_ballot(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | followers: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/common/mod.rs:53:29 [INFO] [stdout] | [INFO] [stdout] 39 | mut io: IO, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | config: ClusterConfig, [INFO] [stdout] 41 | metrics: NodeStateMetrics, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let timeout = io.create_timeout(Role::Follower); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | load_committed: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/common/mod.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 39 | mut io: IO, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | config: ClusterConfig, [INFO] [stdout] 41 | metrics: NodeStateMetrics, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let timeout = io.create_timeout(Role::Follower); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | install_snapshot: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicated_log.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 54 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut metric_builder = metric_builder.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | metric_builder.namespace("raftlog"); [INFO] [stdout] 60 | let metrics = track!(RaftlogMetrics::new(&metric_builder))?; [INFO] [stdout] | ------- -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let node = NodeState::load(node_id, config, io, metrics.node_state.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(ReplicatedLog { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | node, [INFO] [stdout] 64 | | metrics: Arc::new(metrics), [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raftlog` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `cluster` is never read [INFO] [stdout] --> src/test_util.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 54 | pub struct TestIoHandle { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 55 | pub cluster: ClusterConfig, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestIoHandle` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | let node_state = track!(NodeStateMetrics::new(builder))?; [INFO] [stdout] | ---------- -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Self { node_state }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metrics.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 33 | let mut builder: MetricBuilder = builder.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | builder.subsystem("node_state"); [INFO] [stdout] 35 | let transit_to_candidate_total = track!(builder [INFO] [stdout] | _____________--------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | .counter("transit_to_candidate_total") [INFO] [stdout] 37 | | .help("Number of transitions to candidate role") [INFO] [stdout] 38 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let transit_to_follower_total = track!(builder [INFO] [stdout] | _____________-------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | .counter("transit_to_follower_total") [INFO] [stdout] 41 | | .help("Number of transitions to follower role") [INFO] [stdout] 42 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let transit_to_leader_total = track!(builder [INFO] [stdout] | _____________-----------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | | .counter("transit_to_leader_total") [INFO] [stdout] 45 | | .help("Number of transitions to leader role") [INFO] [stdout] 46 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let event_queue_len = track!(builder [INFO] [stdout] | _____________---------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | | .gauge("event_queue_len") [INFO] [stdout] 49 | | .help("Length of a raft event queue") [INFO] [stdout] 50 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let poll_timeout_total = track!(builder [INFO] [stdout] | _____________------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | .counter("poll_timeout_total") [INFO] [stdout] 53 | | .help("Number of timeout") [INFO] [stdout] 54 | | .finish())?; [INFO] [stdout] | |______________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let candidate_to_leader_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | builder [INFO] [stdout] 57 | | .histogram("candidate_to_leader_duration_seconds") [INFO] [stdout] 58 | | .help("Elapsed time moving from candidate to leader") [INFO] [stdout] 59 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let candidate_to_follower_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________--------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | | builder [INFO] [stdout] 62 | | .histogram("candidate_to_follower_duration_seconds") [INFO] [stdout] 63 | | .help("Elapsed time moving from candidate to follower") [INFO] [stdout] 64 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let loader_to_candidate_duration_seconds = track!(make_role_change_histogram( [INFO] [stdout] | _____________------------------------------------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | | builder [INFO] [stdout] 67 | | .histogram("loader_to_candidate_duration_seconds") [INFO] [stdout] 68 | | .help("Elapsed time moving from loader to candidate") [INFO] [stdout] 69 | | ))?; [INFO] [stdout] | |__________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 71 | | transit_to_candidate_total, [INFO] [stdout] 72 | | transit_to_follower_total, [INFO] [stdout] 73 | | transit_to_leader_total, [INFO] [stdout] ... | [INFO] [stdout] 78 | | loader_to_candidate_duration_seconds, [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | fn from(f: std::io::Error) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | ErrorKind::Other.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(f: prometrics::Error) -> Self { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ErrorKind::Other.cause(f).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/candidate.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | let future = common.save_ballot(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Candidate { [INFO] [stdout] 27 | init: Some(future), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/candidate.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 25 | let future = common.save_ballot(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | followers: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/common/mod.rs:53:29 [INFO] [stdout] | [INFO] [stdout] 39 | mut io: IO, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | config: ClusterConfig, [INFO] [stdout] 41 | metrics: NodeStateMetrics, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let timeout = io.create_timeout(Role::Follower); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | load_committed: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_state/common/mod.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 39 | mut io: IO, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | config: ClusterConfig, [INFO] [stdout] 41 | metrics: NodeStateMetrics, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let timeout = io.create_timeout(Role::Follower); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | install_snapshot: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/replicated_log.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 54 | io: IO, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let mut metric_builder = metric_builder.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | metric_builder.namespace("raftlog"); [INFO] [stdout] 60 | let metrics = track!(RaftlogMetrics::new(&metric_builder))?; [INFO] [stdout] | ------- -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let node = NodeState::load(node_id, config, io, metrics.node_state.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Ok(ReplicatedLog { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | node, [INFO] [stdout] 64 | | metrics: Arc::new(metrics), [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_util.rs:235:30 [INFO] [stdout] | [INFO] [stdout] 235 | .map_err(|_| ErrorKind::Other.cause("Broken timer").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raftlog` (lib test) due to 11 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "16620d1509c55e6a8da764960df52e93811e466c09ba6e47c507ed2cd22a9ae4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16620d1509c55e6a8da764960df52e93811e466c09ba6e47c507ed2cd22a9ae4", kill_on_drop: false }` [INFO] [stdout] 16620d1509c55e6a8da764960df52e93811e466c09ba6e47c507ed2cd22a9ae4